Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0038448 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | trivial | have not tried | 2018-04-25 14:11 | 2018-04-27 09:19 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR18Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | e31ad8e9f7e6 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | caristu | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0038448: compilation warnings in src-core + buildvalidations: source/target value 6 is obsolete | |||||||
| Description | Some compilation tasks (openbravo-core and build validation) are still compiled with Java 6. Since Java 9, this causes compilation warnings. The purpose of this was: - There is a build validation (JdkVersionCheck) that ensures JDK is at least 7, this to show a proper message, needs to with JDK6 - As the engine that executes build validations is in openbrav-core it also requires to be compiled with JDK6 | |||||||
| Steps To Reproduce | With Java >=9 execute ant.core lib: ... compile: [javac] Compiling 131 source files to /srv/ci/workspace/try-full-pgsql/src-core/build/classes [javac] warning: [options] bootstrap class path not set in conjunction with -source 6 [javac] warning: [options] source value 6 is obsolete and will be removed in a future release [javac] warning: [options] target value 1.6 is obsolete and will be removed in a future release [javac] warning: [options] To suppress warnings about obsolete options, use -Xlint:-options. [javac] 4 warnings | |||||||
| Proposed Solution | JDK check can be performed directly in ant, without need of executing any build validation. Moving it, would allow to compile core + build validations with current JDK version. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0104085) hgbot (developer) 2018-04-26 09:36 |
Repository: erp/devel/pi Changeset: e31ad8e9f7e617f108f5253d93cf9d23179cc3ac Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu Apr 26 07:46:08 2018 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/e31ad8e9f7e617f108f5253d93cf9d23179cc3ac [^] fixes 38448: compilation warnings in src-core + buildvalidations with JDK10 JDK version validation is now performed directly in ant without need of executing and build validation (note checking only if it is 6 as before core was only compiled with 6, so it would have failed anyway if running with an older one). This allows to compile core and build validations with the same JDK as the rest. --- M build.xml M src-core/build.xml M src-core/src/org/openbravo/buildvalidation/BuildValidationHandler.java M src-util/buildvalidation/build.xml R src-core/.settings/org.eclipse.jdt.core.prefs R src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/JdkVersionCheck.class R src-util/buildvalidation/src/org/openbravo/buildvalidation/JdkVersionCheck.java --- |
|
(0104121) caristu (developer) 2018-04-27 09:19 |
Code reviewed + tested OK. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-04-25 14:11 | alostale | New Issue | |
| 2018-04-25 14:11 | alostale | Assigned To | => platform |
| 2018-04-25 14:11 | alostale | Modules | => Core |
| 2018-04-25 14:11 | alostale | Triggers an Emergency Pack | => No |
| 2018-04-25 14:11 | alostale | Relationship added | related to 0038196 |
| 2018-04-25 14:14 | alostale | Assigned To | platform => alostale |
| 2018-04-25 14:14 | alostale | Review Assigned To | => caristu |
| 2018-04-25 14:15 | alostale | Status | new => scheduled |
| 2018-04-26 09:36 | hgbot | Checkin | |
| 2018-04-26 09:36 | hgbot | Note Added: 0104085 | |
| 2018-04-26 09:36 | hgbot | Status | scheduled => resolved |
| 2018-04-26 09:36 | hgbot | Resolution | open => fixed |
| 2018-04-26 09:36 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/e31ad8e9f7e617f108f5253d93cf9d23179cc3ac [^] |
| 2018-04-27 09:19 | caristu | Note Added: 0104121 | |
| 2018-04-27 09:19 | caristu | Status | resolved => closed |
| 2018-04-27 09:19 | caristu | Fixed in Version | => 3.0PR18Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |