Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038448Openbravo ERPA. Platformpublic2018-04-25 14:112018-04-27 09:19
Reporteralostale 
Assigned Toalostale 
PrioritynormalSeveritytrivialReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version3.0PR18Q3 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038448: compilation warnings in src-core + buildvalidations: source/target value 6 is obsolete
DescriptionSome compilation tasks (openbravo-core and build validation) are still compiled with Java 6.

Since Java 9, this causes compilation warnings.

The purpose of this was:

- There is a build validation (JdkVersionCheck) that ensures JDK is at least 7, this to show a proper message, needs to with JDK6
- As the engine that executes build validations is in openbrav-core it also requires to be compiled with JDK6
Steps To ReproduceWith Java >=9 execute ant.core lib:


...
compile:
    [javac] Compiling 131 source files to /srv/ci/workspace/try-full-pgsql/src-core/build/classes
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 6
    [javac] warning: [options] source value 6 is obsolete and will be removed in a future release
    [javac] warning: [options] target value 1.6 is obsolete and will be removed in a future release
    [javac] warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
    [javac] 4 warnings
Proposed SolutionJDK check can be performed directly in ant, without need of executing any build validation. Moving it, would allow to compile core + build validations with current JDK version.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0038196 closed platform support for JDK 10 
depends on backport 00384493.0PR18Q2 closed alostale compilation warnings in src-core + buildvalidations: source/target value 6 is obsolete 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-04-25 14:11alostaleNew Issue
2018-04-25 14:11alostaleAssigned To => platform
2018-04-25 14:11alostaleModules => Core
2018-04-25 14:11alostaleTriggers an Emergency Pack => No
2018-04-25 14:11alostaleRelationship addedrelated to 0038196
2018-04-25 14:14alostaleAssigned Toplatform => alostale
2018-04-25 14:14alostaleReview Assigned To => caristu
2018-04-25 14:15alostaleStatusnew => scheduled
2018-04-26 09:36hgbotCheckin
2018-04-26 09:36hgbotNote Added: 0104085
2018-04-26 09:36hgbotStatusscheduled => resolved
2018-04-26 09:36hgbotResolutionopen => fixed
2018-04-26 09:36hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e31ad8e9f7e617f108f5253d93cf9d23179cc3ac [^]
2018-04-27 09:19caristuNote Added: 0104121
2018-04-27 09:19caristuStatusresolved => closed
2018-04-27 09:19caristuFixed in Version => 3.0PR18Q3

Notes
(0104085)
hgbot   
2018-04-26 09:36   
Repository: erp/devel/pi
Changeset: e31ad8e9f7e617f108f5253d93cf9d23179cc3ac
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Apr 26 07:46:08 2018 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e31ad8e9f7e617f108f5253d93cf9d23179cc3ac [^]

fixes 38448: compilation warnings in src-core + buildvalidations with JDK10

 JDK version validation is now performed directly in ant without need of executing
 and build validation (note checking only if it is 6 as before core was only compiled
 with 6, so it would have failed anyway if running with an older one).

 This allows to compile core and build validations with the same JDK as the rest.

---
M build.xml
M src-core/build.xml
M src-core/src/org/openbravo/buildvalidation/BuildValidationHandler.java
M src-util/buildvalidation/build.xml
R src-core/.settings/org.eclipse.jdt.core.prefs
R src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/JdkVersionCheck.class
R src-util/buildvalidation/src/org/openbravo/buildvalidation/JdkVersionCheck.java
---
(0104121)
caristu   
2018-04-27 09:19   
Code reviewed + tested OK.