Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | ||||||||||
| ID | |||||||||||
| 0038326 | |||||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||||
| feature request | [Modules] External Data Integration | minor | have not tried | 2018-04-11 11:31 | 2018-05-31 13:53 | ||||||
| Reporter | AugustoMauch | View Status | public | ||||||||
| Assigned To | AugustoMauch | ||||||||||
| Priority | normal | Resolution | open | Fixed in Version | |||||||
| Status | acknowledged | Fix in branch | Fixed in SCM revision | 31f65ae0a799 | |||||||
| Projection | none | ETA | none | Target Version | |||||||
| OS | Any | Database | Any | Java version | |||||||
| OS Version | Database version | Ant version | |||||||||
| Product Version | SCM revision | ||||||||||
| Regression date | |||||||||||
| Regression introduced by commit | |||||||||||
| Regression level | |||||||||||
| Review Assigned To | |||||||||||
| Regression introduced in release | |||||||||||
| Summary | 0038326: Sometimes the exception message is not descriptive, maybe show the full stack trace in the error message field | ||||||||||
| Description | Now when there is an error processing an EDL Request, only the exception message is saved [1]. In most cases the exception message is not enough, and the user/developer must look for more context in the Openbravo log. It would be useful if instead of storing only the exception message, the full stack trace (that includes the exception message) were stored. [1] https://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/file/tip/src/org/openbravo/externaldata/integration/process/AsynchronousProcessor.java#l233 [^] | ||||||||||
| Steps To Reproduce | In any EDL Item processor, force an exception: Object o = null; o.toString(); The EDL Request Line will show only "java.lang.NullPointerException", it would be much more useful for developers if the full stacktrace were shown. | ||||||||||
| Tags | No tags attached. | ||||||||||
| Attached Files |  stackTraceRequestLine.png [^] (71,967 bytes) 2018-04-16 16:44
| ||||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0103806) hgbot (developer) 2018-04-11 11:39 |
Repository: erp/pmods/org.openbravo.externaldata.integration Changeset: 31f65ae0a799f2f1cd43be05617aef558faac378 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed Apr 11 11:39:18 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/31f65ae0a799f2f1cd43be05617aef558faac378 [^] Fixes issue 38326: Store full stack trace in EDL Request line error field Before storing the stack trace string, it is truncated to ensure it fits in the error message column. --- M src/org/openbravo/externaldata/integration/process/AsynchronousProcessor.java --- |
|
(0103830) hgbot (developer) 2018-04-11 18:06 |
Repository: erp/pmods/org.openbravo.externaldata.integration Changeset: e08ea76e19a6576ab57240003dd84c52b0a57397 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Wed Apr 11 18:06:17 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/e08ea76e19a6576ab57240003dd84c52b0a57397 [^] Related with issue 38326: adds missing code that passes the whole stack trace --- M src/org/openbravo/externaldata/integration/process/AsynchronousProcessor.java --- |
|
(0103908) caristu (manager) 2018-04-16 16:43 |
Note that when the error message assigned to the request line is informative enough, including the stack trace could be confusing to the user. See attached image as an example. |
|
(0103911) AugustoMauch (manager) 2018-04-16 16:46 |
Carlos is right. In most cases the stack trace will add noise, instead of making the error message more clear. It is better to leave it as it was before this fix. |
|
(0103912) hgbot (developer) 2018-04-16 16:49 |
Repository: erp/pmods/org.openbravo.externaldata.integration Changeset: 22e17cb2ecbc6cdad051b98a6964564c8b5afec3 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Apr 16 16:48:41 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/22e17cb2ecbc6cdad051b98a6964564c8b5afec3 [^] Related with issue 38326: Backed out changeset e08ea76e19a6, fix is not needed --- M src/org/openbravo/externaldata/integration/process/AsynchronousProcessor.java --- |
|
(0103913) hgbot (developer) 2018-04-16 16:50 |
Repository: erp/pmods/org.openbravo.externaldata.integration Changeset: 1b4be5dc4f98059405a409a4918a306e440f735b Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Mon Apr 16 16:48:59 2018 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/1b4be5dc4f98059405a409a4918a306e440f735b [^] Related with issue 38326: Backed out changeset 31f65ae0a799, fix is not needed --- M src/org/openbravo/externaldata/integration/process/AsynchronousProcessor.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-04-11 11:31 | AugustoMauch | New Issue | |
| 2018-04-11 11:31 | AugustoMauch | Assigned To | => AugustoMauch |
| 2018-04-11 11:31 | AugustoMauch | Modules | => Core |
| 2018-04-11 11:31 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2018-04-11 11:39 | hgbot | Checkin | |
| 2018-04-11 11:39 | hgbot | Note Added: 0103806 | |
| 2018-04-11 11:39 | hgbot | Status | new => resolved |
| 2018-04-11 11:39 | hgbot | Resolution | open => fixed |
| 2018-04-11 11:39 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/31f65ae0a799f2f1cd43be05617aef558faac378 [^] |
| 2018-04-11 11:40 | AugustoMauch | Review Assigned To | => caristu |
| 2018-04-11 18:06 | hgbot | Checkin | |
| 2018-04-11 18:06 | hgbot | Note Added: 0103830 | |
| 2018-04-16 08:39 | caristu | Project | Openbravo ERP => Modules |
| 2018-04-16 08:40 | caristu | Category | A. Platform => External Data Integration |
| 2018-04-16 08:48 | caristu | Relationship added | related to 0038325 |
| 2018-04-16 08:51 | caristu | Relationship deleted | related to 0038325 |
| 2018-04-16 08:51 | caristu | Relationship added | related to 0038235 |
| 2018-04-16 13:52 | naiaramartinez | Issue Monitored: naiaramartinez | |
| 2018-04-16 16:43 | caristu | Note Added: 0103908 | |
| 2018-04-16 16:44 | caristu | File Added: stackTraceRequestLine.png | |
| 2018-04-16 16:46 | AugustoMauch | Note Added: 0103911 | |
| 2018-04-16 16:46 | AugustoMauch | Status | resolved => new |
| 2018-04-16 16:46 | AugustoMauch | Resolution | fixed => open |
| 2018-04-16 16:49 | hgbot | Checkin | |
| 2018-04-16 16:49 | hgbot | Note Added: 0103912 | |
| 2018-04-16 16:50 | hgbot | Checkin | |
| 2018-04-16 16:50 | hgbot | Note Added: 0103913 | |
| 2018-04-16 16:52 | AugustoMauch | Summary | When there is an Exception when processing an EDL Request, show the full stack trace in the error message field => Sometimes the exception message is not descriptive, maybe show the full stack trace in the error message field |
| 2018-04-16 16:52 | AugustoMauch | Status | new => acknowledged |
| 2018-05-31 13:53 | caristu | Review Assigned To | caristu => |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |