Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038326ModulesExternal Data Integrationpublic2018-04-11 11:312018-05-31 13:53
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusacknowledgedResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0038326: Sometimes the exception message is not descriptive, maybe show the full stack trace in the error message field
DescriptionNow when there is an error processing an EDL Request, only the exception message is saved [1].

In most cases the exception message is not enough, and the user/developer must look for more context in the Openbravo log.

It would be useful if instead of storing only the exception message, the full stack trace (that includes the exception message) were stored.


[1] https://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/file/tip/src/org/openbravo/externaldata/integration/process/AsynchronousProcessor.java#l233 [^]
Steps To ReproduceIn any EDL Item processor, force an exception:

 Object o = null;
 o.toString();

The EDL Request Line will show only "java.lang.NullPointerException", it would be much more useful for developers if the full stacktrace were shown.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0038235 closed AugustoMauch SERQA 3916: Errors while reprocessing an EDL Request are not logged 
Attached Filespng stackTraceRequestLine.png (71,967) 2018-04-16 16:44
https://issues.openbravo.com/file_download.php?file_id=11739&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-04-11 11:31AugustoMauchNew Issue
2018-04-11 11:31AugustoMauchAssigned To => AugustoMauch
2018-04-11 11:31AugustoMauchModules => Core
2018-04-11 11:31AugustoMauchTriggers an Emergency Pack => No
2018-04-11 11:39hgbotCheckin
2018-04-11 11:39hgbotNote Added: 0103806
2018-04-11 11:39hgbotStatusnew => resolved
2018-04-11 11:39hgbotResolutionopen => fixed
2018-04-11 11:39hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/31f65ae0a799f2f1cd43be05617aef558faac378 [^]
2018-04-11 11:40AugustoMauchReview Assigned To => caristu
2018-04-11 18:06hgbotCheckin
2018-04-11 18:06hgbotNote Added: 0103830
2018-04-16 08:39caristuProjectOpenbravo ERP => Modules
2018-04-16 08:40caristuCategoryA. Platform => External Data Integration
2018-04-16 08:48caristuRelationship addedrelated to 0038325
2018-04-16 08:51caristuRelationship deletedrelated to 0038325
2018-04-16 08:51caristuRelationship addedrelated to 0038235
2018-04-16 13:52naiaramartinezIssue Monitored: naiaramartinez
2018-04-16 16:43caristuNote Added: 0103908
2018-04-16 16:44caristuFile Added: stackTraceRequestLine.png
2018-04-16 16:46AugustoMauchNote Added: 0103911
2018-04-16 16:46AugustoMauchStatusresolved => new
2018-04-16 16:46AugustoMauchResolutionfixed => open
2018-04-16 16:49hgbotCheckin
2018-04-16 16:49hgbotNote Added: 0103912
2018-04-16 16:50hgbotCheckin
2018-04-16 16:50hgbotNote Added: 0103913
2018-04-16 16:52AugustoMauchSummaryWhen there is an Exception when processing an EDL Request, show the full stack trace in the error message field => Sometimes the exception message is not descriptive, maybe show the full stack trace in the error message field
2018-04-16 16:52AugustoMauchStatusnew => acknowledged
2018-05-31 13:53caristuReview Assigned Tocaristu =>

Notes
(0103806)
hgbot   
2018-04-11 11:39   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: 31f65ae0a799f2f1cd43be05617aef558faac378
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Apr 11 11:39:18 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/31f65ae0a799f2f1cd43be05617aef558faac378 [^]

Fixes issue 38326: Store full stack trace in EDL Request line error field

Before storing the stack trace string, it is truncated to ensure it fits in the error message column.

---
M src/org/openbravo/externaldata/integration/process/AsynchronousProcessor.java
---
(0103830)
hgbot   
2018-04-11 18:06   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: e08ea76e19a6576ab57240003dd84c52b0a57397
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Apr 11 18:06:17 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/e08ea76e19a6576ab57240003dd84c52b0a57397 [^]

Related with issue 38326: adds missing code that passes the whole stack trace

---
M src/org/openbravo/externaldata/integration/process/AsynchronousProcessor.java
---
(0103908)
caristu   
2018-04-16 16:43   
Note that when the error message assigned to the request line is informative enough, including the stack trace could be confusing to the user. See attached image as an example.
(0103911)
AugustoMauch   
2018-04-16 16:46   
Carlos is right. In most cases the stack trace will add noise, instead of making the error message more clear.

It is better to leave it as it was before this fix.
(0103912)
hgbot   
2018-04-16 16:49   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: 22e17cb2ecbc6cdad051b98a6964564c8b5afec3
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Apr 16 16:48:41 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/22e17cb2ecbc6cdad051b98a6964564c8b5afec3 [^]

Related with issue 38326: Backed out changeset e08ea76e19a6, fix is not needed

---
M src/org/openbravo/externaldata/integration/process/AsynchronousProcessor.java
---
(0103913)
hgbot   
2018-04-16 16:50   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: 1b4be5dc4f98059405a409a4918a306e440f735b
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Apr 16 16:48:59 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/1b4be5dc4f98059405a409a4918a306e440f735b [^]

Related with issue 38326: Backed out changeset 31f65ae0a799, fix is not needed

---
M src/org/openbravo/externaldata/integration/process/AsynchronousProcessor.java
---