Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0038235
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] External Data Integrationmajorhave not tried2018-03-27 17:262018-04-16 09:16
ReporterjavietxeView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision955c981fd5d3
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned Tocaristu
Regression introduced in release
Summary

0038235: SERQA 3916: Errors while reprocessing an EDL Request are not logged

DescriptionWhen reprocessing a Request, if any error happens, nothing appears in the logs
Steps To ReproduceReprocess a request that gives an exception while reprocessing
Proposed SolutionPut logs in the catch of exceptions in the reprocessRequest method in ProcessRequest class.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0038326 acknowledgedAugustoMauch Sometimes the exception message is not descriptive, maybe show the full stack trace in the error message field 

-  Notes
(0103798)
hgbot (developer)
2018-04-10 21:33

 Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: 955c981fd5d31c82c8bc48d154421722e088bfef
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Apr 10 16:37:05 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/955c981fd5d31c82c8bc48d154421722e088bfef [^]

Fixes issue 38235: Exceptions in ProcessRequest.reprocessRequest are logged

There were three catch blocks, for exceptions of type OBException, SQLException and Exception. The three catch blocks were doing the same,
the only difference being the only the Exception block was logging the exception.

Now the only catch block that remains is the one for Exception, so the log is written in all cases.

---
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---
(0103896)
hgbot (developer)
2018-04-16 09:15

 Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: 857df365f2273092bdc7dd73f1544ab5fe472a82
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Apr 16 09:14:25 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/857df365f2273092bdc7dd73f1544ab5fe472a82 [^]

related to issue 38235: Add some context to the log message

---
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---
(0103897)
caristu (manager)
2018-04-16 09:16
edited on: 2018-04-16 17:03

 Code reviewed + tested OK. Fixed in version 2.0.500.

- Issue History
Date Modified Username Field Change
2018-03-27 17:26 javietxe New Issue
2018-03-27 17:26 javietxe Assigned To => AugustoMauch
2018-03-27 17:26 javietxe Modules => Core
2018-03-27 17:26 javietxe Triggers an Emergency Pack => No
2018-03-27 17:27 javietxe Resolution time => 1523311200
2018-04-10 21:33 hgbot Checkin
2018-04-10 21:33 hgbot Note Added: 0103798
2018-04-10 21:33 hgbot Status new => resolved
2018-04-10 21:33 hgbot Resolution open => fixed
2018-04-10 21:33 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/955c981fd5d31c82c8bc48d154421722e088bfef [^]
2018-04-11 10:42 AugustoMauch Review Assigned To => caristu
2018-04-16 08:40 caristu Project Openbravo ERP => Modules
2018-04-16 08:40 caristu Category A. Platform => External Data Integration
2018-04-16 08:51 caristu Relationship added related to 0038326
2018-04-16 09:15 hgbot Checkin
2018-04-16 09:15 hgbot Note Added: 0103896
2018-04-16 09:16 caristu Note Added: 0103897
2018-04-16 09:16 caristu Status resolved => closed
2018-04-16 17:03 caristu Note Edited: 0103897 View Revisions

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker