Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038235ModulesExternal Data Integrationpublic2018-03-27 17:262018-04-16 09:16
Reporterjavietxe 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Tocaristu
Support ticket
OBNetwork customer
Regression introduced in release
Summary0038235: SERQA 3916: Errors while reprocessing an EDL Request are not logged
DescriptionWhen reprocessing a Request, if any error happens, nothing appears in the logs
Steps To ReproduceReprocess a request that gives an exception while reprocessing
Proposed SolutionPut logs in the catch of exceptions in the reprocessRequest method in ProcessRequest class.
Additional Information
TagsNo tags attached.
Relationships
related to feature request 0038326 acknowledged AugustoMauch Sometimes the exception message is not descriptive, maybe show the full stack trace in the error message field 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-27 17:26javietxeNew Issue
2018-03-27 17:26javietxeAssigned To => AugustoMauch
2018-03-27 17:26javietxeModules => Core
2018-03-27 17:26javietxeTriggers an Emergency Pack => No
2018-03-27 17:27javietxeResolution time => 1523311200
2018-04-10 21:33hgbotCheckin
2018-04-10 21:33hgbotNote Added: 0103798
2018-04-10 21:33hgbotStatusnew => resolved
2018-04-10 21:33hgbotResolutionopen => fixed
2018-04-10 21:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/955c981fd5d31c82c8bc48d154421722e088bfef [^]
2018-04-11 10:42AugustoMauchReview Assigned To => caristu
2018-04-16 08:40caristuProjectOpenbravo ERP => Modules
2018-04-16 08:40caristuCategoryA. Platform => External Data Integration
2018-04-16 08:51caristuRelationship addedrelated to 0038326
2018-04-16 09:15hgbotCheckin
2018-04-16 09:15hgbotNote Added: 0103896
2018-04-16 09:16caristuNote Added: 0103897
2018-04-16 09:16caristuStatusresolved => closed
2018-04-16 17:03caristuNote Edited: 0103897bug_revision_view_page.php?bugnote_id=0103897#r17001

Notes
(0103798)
hgbot   
2018-04-10 21:33   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: 955c981fd5d31c82c8bc48d154421722e088bfef
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Apr 10 16:37:05 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/955c981fd5d31c82c8bc48d154421722e088bfef [^]

Fixes issue 38235: Exceptions in ProcessRequest.reprocessRequest are logged

There were three catch blocks, for exceptions of type OBException, SQLException and Exception. The three catch blocks were doing the same,
the only difference being the only the Exception block was logging the exception.

Now the only catch block that remains is the one for Exception, so the log is written in all cases.

---
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---
(0103896)
hgbot   
2018-04-16 09:15   
Repository: erp/pmods/org.openbravo.externaldata.integration
Changeset: 857df365f2273092bdc7dd73f1544ab5fe472a82
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Mon Apr 16 09:14:25 2018 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.externaldata.integration/rev/857df365f2273092bdc7dd73f1544ab5fe472a82 [^]

related to issue 38235: Add some context to the log message

---
M src/org/openbravo/externaldata/integration/process/ProcessRequest.java
---
(0103897)
caristu   
2018-04-16 09:16   
(edited on: 2018-04-16 17:03)
Code reviewed + tested OK. Fixed in version 2.0.500.