0038138: LoginUtilsServlet.getUserImages is not using bind-variables

Description

This code is not using bind-variable:

      for (int i = 0; i < approvalType.length(); i++) {
        String iter = approvalType.getString(i);
        hqlUser += "and exists (from ADPreference as p"
            + " where property = '"
            + iter
            + "' and active = true"

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

design defect

0038136

acknowledged

Triage Platform Base

Openbravo ERP

Tracking issue: Find & Fix queries not using bind-params but embedding values into query string

Notes
(0103299) hgbot (developer) 2018-03-16 08:19	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 190f12b0a9df7de0120e95e8154ea24ec8e8d1ff Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Thu Mar 15 11:26:24 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/190f12b0a9df7de0120e95e8154ea24ec8e8d1ff [^] Fixed issue 38138 use bind-variables in LoginUtilsServlet.getUserImages --- M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java ---

Issue History
Date Modified	Username	Field	Change
2018-03-14 13:23	shuehner	New Issue
2018-03-14 13:23	shuehner	Assigned To	=> Retail
2018-03-14 13:23	shuehner	Triggers an Emergency Pack	=> No
2018-03-14 13:24	shuehner	Relationship added	blocks 0038136
2018-03-14 16:34	shuehner	Assigned To	Retail => Sandrahuguet
2018-03-14 17:13	Sandrahuguet	Status	new => scheduled
2018-03-16 08:19	hgbot	Checkin
2018-03-16 08:19	hgbot	Note Added: 0103299
2018-03-16 08:19	hgbot	Status	scheduled => resolved
2018-03-16 08:19	hgbot	Resolution	open => fixed
2018-03-16 08:19	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/190f12b0a9df7de0120e95e8154ea24ec8e8d1ff [^]
2018-03-16 08:29	Sandrahuguet	Review Assigned To	=> marvintm
2018-03-19 09:39	marvintm	Status	resolved => closed
2018-03-19 09:39	marvintm	Fixed in Version	=> RR18Q2