Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0038138Retail ModulesWeb POSpublic2018-03-14 13:232018-03-19 09:39
Reportershuehner 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0038138: LoginUtilsServlet.getUserImages is not using bind-variables
DescriptionThis code is not using bind-variable:

      for (int i = 0; i < approvalType.length(); i++) {
        String iter = approvalType.getString(i);
        hqlUser += "and exists (from ADPreference as p"
            + " where property = '"
            + iter
            + "' and active = true"



Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-03-14 13:23shuehnerNew Issue
2018-03-14 13:23shuehnerAssigned To => Retail
2018-03-14 13:23shuehnerTriggers an Emergency Pack => No
2018-03-14 13:24shuehnerRelationship addedblocks 0038136
2018-03-14 16:34shuehnerAssigned ToRetail => Sandrahuguet
2018-03-14 17:13SandrahuguetStatusnew => scheduled
2018-03-16 08:19hgbotCheckin
2018-03-16 08:19hgbotNote Added: 0103299
2018-03-16 08:19hgbotStatusscheduled => resolved
2018-03-16 08:19hgbotResolutionopen => fixed
2018-03-16 08:19hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/190f12b0a9df7de0120e95e8154ea24ec8e8d1ff [^]
2018-03-16 08:29SandrahuguetReview Assigned To => marvintm
2018-03-19 09:39marvintmStatusresolved => closed
2018-03-19 09:39marvintmFixed in Version => RR18Q2

Notes
(0103299)
hgbot   
2018-03-16 08:19   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 190f12b0a9df7de0120e95e8154ea24ec8e8d1ff
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Mar 15 11:26:24 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/190f12b0a9df7de0120e95e8154ea24ec8e8d1ff [^]

Fixed issue 38138 use bind-variables in LoginUtilsServlet.getUserImages

---
M src/org/openbravo/retail/posterminal/LoginUtilsServlet.java
---