Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037896
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformmajoralways2018-02-06 15:532018-02-15 11:03
ReportervmromanosView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0PR18Q1
StatusclosedFix in branchFixed in SCM revisionede43adfb31d
ProjectionnoneETAnoneTarget Version3.0PR18Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2016-01-28
Regression introduced in release3.0PR16Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/baf72de5b678a308c36d5946af3e143d08625eca [^]
Triggers an Emergency PackNo
Summary

0037896: Callout not triggered when clearing a selector

DescriptionA callout is associated to a nullable column with a OBUISEL_Selector Reference.
When the user selects something in the selector the callout is properly triggered. However when the user clears the selector (i.e. no value is selected) and the focus is changed to another field then the callout is NOT triggered.

I have noticed a special case where the callout is properly triggered: when you open a window and then you clear the selector of an existing record (i.e. a record previously saved in the DB) then the callout is properly triggered.
Steps To ReproduceAssociate a callout with a nullable column with a OBUISEL_Selector Reference.
Compile and restart tomcat in debug mode.
Set a break point at the beginning of the callout.
Create a new record in the correspondent window. Select any value in the selector and change the focus. Verify the callout is properly triggered. OK
Now clears the selector and change the focus. The callout is NOT triggered. WRONG.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0037842 closedplatform Callout not triggered when clearing a selector 

-  Notes
(0102389)
hgbot (developer)
2018-02-14 09:46

 Repository: erp/backports/3.0PR18Q1
Changeset: ede43adfb31dd8156f498fb29e2db75ef80af728
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Feb 14 09:40:23 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q1/rev/ede43adfb31dd8156f498fb29e2db75ef80af728 [^]

Fixes issue 37896: Callouts are invoked when clearing a non mandatory selector

This changeset [1] fixed a problem where a callout was being called twice when picking a value from a selector. The first request was done properly, but the
second one was done with a null value. The fix consisted in not notifying a change in selector when it was modified from a non-empty value to an empty value.

But as a result, when a non mandatory selector is emptied, callouts are no longer being invoked. The original issue is very hard to reproduce, I have not been
able to find a new way to reproduce it or fix it. To avoid the regression, now the code that was done to fix [1] will only take place if the selector is mandatory,
to make sure that it is possible to give empty values to non-mandatory selectors.

[1] https://code.openbravo.com/erp/devel/pi/rev/baf72de5b678a308c36d5946af3e143d08625eca [^]

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0102399)
caristu (developer)
2018-02-14 13:29

 Code reviewed + tested OK.

Tested with Product field in the Lines tab of Sales Invoice window.

- Issue History
Date Modified Username Field Change
2018-02-13 10:36 AugustoMauch Type defect => backport
2018-02-13 10:36 AugustoMauch Target Version => 3.0PR18Q1
2018-02-14 09:46 hgbot Checkin
2018-02-14 09:46 hgbot Note Added: 0102389
2018-02-14 09:46 hgbot Status scheduled => resolved
2018-02-14 09:46 hgbot Resolution open => fixed
2018-02-14 09:46 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q1/rev/ede43adfb31dd8156f498fb29e2db75ef80af728 [^]
2018-02-14 13:28 caristu Review Assigned To => caristu
2018-02-14 13:29 caristu Note Added: 0102399
2018-02-14 13:29 caristu Status resolved => closed
2018-02-14 13:29 caristu Fixed in Version => 3.0PR18Q1
2018-02-15 11:03 plujan Assigned To platform => AugustoMauch

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker