Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037896Openbravo ERPA. Platformpublic2018-02-06 15:532018-02-15 11:03
Reportervmromanos 
Assigned ToAugustoMauch 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR18Q1Fixed in Version3.0PR18Q1 
Merge Request Status
Review Assigned Tocaristu
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2016-01-28
Regression introduced in release3.0PR16Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/baf72de5b678a308c36d5946af3e143d08625eca [^]
Triggers an Emergency PackNo
Summary0037896: Callout not triggered when clearing a selector
DescriptionA callout is associated to a nullable column with a OBUISEL_Selector Reference.
When the user selects something in the selector the callout is properly triggered. However when the user clears the selector (i.e. no value is selected) and the focus is changed to another field then the callout is NOT triggered.

I have noticed a special case where the callout is properly triggered: when you open a window and then you clear the selector of an existing record (i.e. a record previously saved in the DB) then the callout is properly triggered.
Steps To ReproduceAssociate a callout with a nullable column with a OBUISEL_Selector Reference.
Compile and restart tomcat in debug mode.
Set a break point at the beginning of the callout.
Create a new record in the correspondent window. Select any value in the selector and change the focus. Verify the callout is properly triggered. OK
Now clears the selector and change the focus. The callout is NOT triggered. WRONG.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0037842 closed platform Callout not triggered when clearing a selector 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-02-13 10:36AugustoMauchTypedefect => backport
2018-02-13 10:36AugustoMauchTarget Version => 3.0PR18Q1
2018-02-14 09:46hgbotCheckin
2018-02-14 09:46hgbotNote Added: 0102389
2018-02-14 09:46hgbotStatusscheduled => resolved
2018-02-14 09:46hgbotResolutionopen => fixed
2018-02-14 09:46hgbotFixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR18Q1/rev/ede43adfb31dd8156f498fb29e2db75ef80af728 [^]
2018-02-14 13:28caristuReview Assigned To => caristu
2018-02-14 13:29caristuNote Added: 0102399
2018-02-14 13:29caristuStatusresolved => closed
2018-02-14 13:29caristuFixed in Version => 3.0PR18Q1
2018-02-15 11:03plujanAssigned Toplatform => AugustoMauch

Notes
(0102389)
hgbot   
2018-02-14 09:46   
Repository: erp/backports/3.0PR18Q1
Changeset: ede43adfb31dd8156f498fb29e2db75ef80af728
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Feb 14 09:40:23 2018 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR18Q1/rev/ede43adfb31dd8156f498fb29e2db75ef80af728 [^]

Fixes issue 37896: Callouts are invoked when clearing a non mandatory selector

This changeset [1] fixed a problem where a callout was being called twice when picking a value from a selector. The first request was done properly, but the
second one was done with a null value. The fix consisted in not notifying a change in selector when it was modified from a non-empty value to an empty value.

But as a result, when a non mandatory selector is emptied, callouts are no longer being invoked. The original issue is very hard to reproduce, I have not been
able to find a new way to reproduce it or fix it. To avoid the regression, now the code that was done to fix [1] will only take place if the selector is mandatory,
to make sure that it is possible to give empty values to non-mandatory selectors.

[1] https://code.openbravo.com/erp/devel/pi/rev/baf72de5b678a308c36d5946af3e143d08625eca [^]

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0102399)
caristu   
2018-02-14 13:29   
Code reviewed + tested OK.

Tested with Product field in the Lines tab of Sales Invoice window.