Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037776
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-01-30 17:592018-02-14 13:13
ReportermarvintmView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR18Q2
StatusclosedFix in branchFixed in SCM revisionb54ae04290e5
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-01-04
Regression introduced in releaseRR17Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/44c7e3f98c74a85be438d945dd0588217eecdd61 [^]
Triggers an Emergency PackNo
Summary

0037776: In a terminal without refundable payment methods, it should still be possible to pay a return on credit

DescriptionAfter the ability to mark a payment method as refundable was introduced, a new check was added to ensure that the user cannot go to the Payment tab for a return, if there are no refundable payment methods added.

This check makes sense, but affected a flow which was possible before: the ability to pay a return on credit, if the terminal and the selected business partner allows it.
Steps To Reproduce- Configure Arturo Montoro customer to add Credit limit
- Configure the VBS-1 terminal to allow pay on credit.
- Mark all its payment methods as non refundable
- Go to the Web POS, and create a Verified Return
- Click on the Total button. A popup is raised, explaining that there are no refundable payment methods. This is wrong, because you should still be able to pay on credit.
TagsNo tags attached.
Attached Filesdiff file icon payoncreditTerminalForSellers.diff [^] (883 bytes) 2018-01-30 18:03 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0037629 closedrqueralta "Verified return" menu option not present when none of the terminal's Terminal Type payment methods are counted in cash up. 
depends on backport 0037778RR18Q1 closedranjith_qualiantech_com In a terminal without refundable payment methods, it should still be possible to pay a return on credit 
depends on backport 0037779RR17Q4.2 closedranjith_qualiantech_com In a terminal without refundable payment methods, it should still be possible to pay a return on credit 
caused by feature request 0034549 closedguillermogil Create an structure to disable payment method buttons set as not refundables 

-  Notes
(0102325)
hgbot (developer)
2018-02-12 10:52

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e4b553d77662c83c3c1f4f842c965bf976e5a2d2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 12 15:20:20 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e4b553d77662c83c3c1f4f842c965bf976e5a2d2 [^]

Related to issue 37776 : Keypad should not be shown if the payment is disabled in keyboard

* Keypad should be displayed based on active payment methods while clicking payment switch

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0102326)
hgbot (developer)
2018-02-12 10:52

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eda268f376cec971ede0edeadb3c64c998d562ff
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 12 15:20:31 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eda268f376cec971ede0edeadb3c64c998d562ff [^]

Fixed issue 37776 : Payment should be shown if use credit is enabled with no refundable payment methods

* Keypad should be displayed based on active payment methods while clicking payment switch

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0102327)
hgbot (developer)
2018-02-12 10:52

 Repository: tools/automation/pi-mobile
Changeset: 18219b3d4c92f2a4a04aa6f472b305f7e45e41ac
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 12 15:20:14 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/18219b3d4c92f2a4a04aa6f472b305f7e45e41ac [^]

Verifies issue 37776 : Added automated test 'I37776_VerifyCreditButton'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I37776_VerifyCreditButton.java
---
(0102332)
marvintm (viewer)
2018-02-12 14:11

 Credit limit should not be checked in the case the payment status is negative, because when returning things it should always be possible to pay on credit.

So, this part of the condition should be removed:

"|| this.model.get('order').get('bp').get('creditLimit') <= 0"
(0102342)
hgbot (developer)
2018-02-13 07:25

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b54ae04290e5b59ba2c8478e9766e0566e228204
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Feb 13 11:55:27 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b54ae04290e5b59ba2c8478e9766e0566e228204 [^]

Fixed issue 37776 : Return can be paid using credit if there are no active payment methods

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---

- Issue History
Date Modified Username Field Change
2018-01-30 17:59 marvintm New Issue
2018-01-30 17:59 marvintm Assigned To => Retail
2018-01-30 17:59 marvintm OBNetwork customer => No
2018-01-30 17:59 marvintm Triggers an Emergency Pack => No
2018-01-30 18:02 marvintm OBNetwork customer No => Yes
2018-01-30 18:02 marvintm Resolution time => 1518649200
2018-01-30 18:02 marvintm Regression level => Production - Confirmed Stable
2018-01-30 18:02 marvintm Regression date => 2017-01-04
2018-01-30 18:02 marvintm Regression introduced in release => RR17Q2
2018-01-30 18:02 marvintm Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/44c7e3f98c74a85be438d945dd0588217eecdd61 [^]
2018-01-30 18:03 marvintm File Added: payoncreditTerminalForSellers.diff
2018-01-30 18:03 marvintm Relationship added related to 0037629
2018-01-30 18:03 marvintm Relationship added caused by 0034549
2018-01-30 18:06 marvintm Status new => scheduled
2018-02-05 11:36 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2018-02-12 10:52 hgbot Checkin
2018-02-12 10:52 hgbot Note Added: 0102325
2018-02-12 10:52 hgbot Checkin
2018-02-12 10:52 hgbot Note Added: 0102326
2018-02-12 10:52 hgbot Status scheduled => resolved
2018-02-12 10:52 hgbot Resolution open => fixed
2018-02-12 10:52 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eda268f376cec971ede0edeadb3c64c998d562ff [^]
2018-02-12 10:52 hgbot Checkin
2018-02-12 10:52 hgbot Note Added: 0102327
2018-02-12 14:11 marvintm Note Added: 0102332
2018-02-12 14:11 marvintm Status resolved => new
2018-02-12 14:11 marvintm Resolution fixed => open
2018-02-13 07:25 hgbot Checkin
2018-02-13 07:25 hgbot Note Added: 0102342
2018-02-13 07:25 hgbot Status new => resolved
2018-02-13 07:25 hgbot Resolution open => fixed
2018-02-13 07:25 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eda268f376cec971ede0edeadb3c64c998d562ff [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b54ae04290e5b59ba2c8478e9766e0566e228204 [^]
2018-02-14 13:13 marvintm Review Assigned To => marvintm
2018-02-14 13:13 marvintm Status resolved => closed
2018-02-14 13:13 marvintm Fixed in Version => RR18Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker