Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037776Retail ModulesWeb POSpublic2018-01-30 17:592018-02-14 13:13
Reportermarvintm 
Assigned Toranjith_qualiantech_com 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2017-01-04
Regression introduced in releaseRR17Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/44c7e3f98c74a85be438d945dd0588217eecdd61 [^]
Triggers an Emergency PackNo
Summary0037776: In a terminal without refundable payment methods, it should still be possible to pay a return on credit
DescriptionAfter the ability to mark a payment method as refundable was introduced, a new check was added to ensure that the user cannot go to the Payment tab for a return, if there are no refundable payment methods added.

This check makes sense, but affected a flow which was possible before: the ability to pay a return on credit, if the terminal and the selected business partner allows it.
Steps To Reproduce- Configure Arturo Montoro customer to add Credit limit
- Configure the VBS-1 terminal to allow pay on credit.
- Mark all its payment methods as non refundable
- Go to the Web POS, and create a Verified Return
- Click on the Total button. A popup is raised, explaining that there are no refundable payment methods. This is wrong, because you should still be able to pay on credit.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0037629 closed rqueralta "Verified return" menu option not present when none of the terminal's Terminal Type payment methods are counted in cash up. 
depends on backport 0037778RR18Q1 closed ranjith_qualiantech_com In a terminal without refundable payment methods, it should still be possible to pay a return on credit 
depends on backport 0037779RR17Q4.2 closed ranjith_qualiantech_com In a terminal without refundable payment methods, it should still be possible to pay a return on credit 
caused by feature request 0034549 closed guillermogil Create an structure to disable payment method buttons set as not refundables 
Attached Filesdiff payoncreditTerminalForSellers.diff (883) 2018-01-30 18:03
https://issues.openbravo.com/file_download.php?file_id=11502&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-01-30 17:59marvintmNew Issue
2018-01-30 17:59marvintmAssigned To => Retail
2018-01-30 17:59marvintmOBNetwork customer => No
2018-01-30 17:59marvintmTriggers an Emergency Pack => No
2018-01-30 18:02marvintmOBNetwork customerNo => Yes
2018-01-30 18:02marvintmResolution time => 1518649200
2018-01-30 18:02marvintmRegression level => Production - Confirmed Stable
2018-01-30 18:02marvintmRegression date => 2017-01-04
2018-01-30 18:02marvintmRegression introduced in release => RR17Q2
2018-01-30 18:02marvintmRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/44c7e3f98c74a85be438d945dd0588217eecdd61 [^]
2018-01-30 18:03marvintmFile Added: payoncreditTerminalForSellers.diff
2018-01-30 18:03marvintmRelationship addedrelated to 0037629
2018-01-30 18:03marvintmRelationship addedcaused by 0034549
2018-01-30 18:06marvintmStatusnew => scheduled
2018-02-05 11:36ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-02-12 10:52hgbotCheckin
2018-02-12 10:52hgbotNote Added: 0102325
2018-02-12 10:52hgbotCheckin
2018-02-12 10:52hgbotNote Added: 0102326
2018-02-12 10:52hgbotStatusscheduled => resolved
2018-02-12 10:52hgbotResolutionopen => fixed
2018-02-12 10:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eda268f376cec971ede0edeadb3c64c998d562ff [^]
2018-02-12 10:52hgbotCheckin
2018-02-12 10:52hgbotNote Added: 0102327
2018-02-12 14:11marvintmNote Added: 0102332
2018-02-12 14:11marvintmStatusresolved => new
2018-02-12 14:11marvintmResolutionfixed => open
2018-02-13 07:25hgbotCheckin
2018-02-13 07:25hgbotNote Added: 0102342
2018-02-13 07:25hgbotStatusnew => resolved
2018-02-13 07:25hgbotResolutionopen => fixed
2018-02-13 07:25hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eda268f376cec971ede0edeadb3c64c998d562ff [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b54ae04290e5b59ba2c8478e9766e0566e228204 [^]
2018-02-14 13:13marvintmReview Assigned To => marvintm
2018-02-14 13:13marvintmStatusresolved => closed
2018-02-14 13:13marvintmFixed in Version => RR18Q2

Notes
(0102325)
hgbot   
2018-02-12 10:52   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: e4b553d77662c83c3c1f4f842c965bf976e5a2d2
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 12 15:20:20 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/e4b553d77662c83c3c1f4f842c965bf976e5a2d2 [^]

Related to issue 37776 : Keypad should not be shown if the payment is disabled in keyboard

* Keypad should be displayed based on active payment methods while clicking payment switch

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---
(0102326)
hgbot   
2018-02-12 10:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: eda268f376cec971ede0edeadb3c64c998d562ff
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 12 15:20:31 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eda268f376cec971ede0edeadb3c64c998d562ff [^]

Fixed issue 37776 : Payment should be shown if use credit is enabled with no refundable payment methods

* Keypad should be displayed based on active payment methods while clicking payment switch

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---
(0102327)
hgbot   
2018-02-12 10:52   
Repository: tools/automation/pi-mobile
Changeset: 18219b3d4c92f2a4a04aa6f472b305f7e45e41ac
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Mon Feb 12 15:20:14 2018 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/18219b3d4c92f2a4a04aa6f472b305f7e45e41ac [^]

Verifies issue 37776 : Added automated test 'I37776_VerifyCreditButton'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I37776_VerifyCreditButton.java
---
(0102332)
marvintm   
2018-02-12 14:11   
Credit limit should not be checked in the case the payment status is negative, because when returning things it should always be possible to pay on credit.

So, this part of the condition should be removed:

"|| this.model.get('order').get('bp').get('creditLimit') <= 0"
(0102342)
hgbot   
2018-02-13 07:25   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b54ae04290e5b59ba2c8478e9766e0566e228204
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Feb 13 11:55:27 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b54ae04290e5b59ba2c8478e9766e0566e228204 [^]

Fixed issue 37776 : Return can be paid using credit if there are no active payment methods

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-left.js
---