Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0037769 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2018-01-30 12:57 | 2018-02-26 09:08 | |||
| Reporter | malsasua | View Status | public | |||||
| Assigned To | rqueralta | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR18Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 1009a30c23c7 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | RR17Q4 | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | OBPS | |||||||
| Support ticket | 50635 | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0037769: Verified returns is not working with scaled products: total line is set to 0 | |||||||
| Description | When a line of scaled product is selected in verified returns functionality, the line is added with 0 amount in the ticket | |||||||
| Steps To Reproduce | . reproducible in 17Q4, in pi there is another previous error BO: . create a new product (p1), with "is scaled" Y . add in pricelist (price: 5) and assortment . configure "pos terminal": hw manager: http://localhost:8090/printer [^] [^] Scale: http://localhost:8090/scale [^] [^] . open hw manager in localhost POS: . create new ticket: . new line: p1 -> qty: 1.181 . total ticket 5.91 . pay ticket . open verifier return selector:_ . select previous ticket . select all lines and add them to the current ticket . line 1: p1 - qty: 1.181 - total 0 -> WRONG:it should be -5.91 . total ticket: 0 -> WRONG: it should be -5.91 (see attachment) | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  error.png [^] (183,103 bytes) 2018-01-30 12:59
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0102220) hgbot (developer) 2018-02-06 15:21 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 1009a30c23c729e4033b592b12e40d1e034fb7d4 Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu> Date: Fri Feb 02 14:43:38 2018 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1009a30c23c729e4033b592b12e40d1e034fb7d4 [^] Fixed issue 37769: Verified returns is not working with scaled products: total line is set to 0 --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0102228) marvintm (viewer) 2018-02-06 19:32 |
The fix is not exactly correct. In this case, the main problem comes from the fact that in the scale flow, the callback of the main _addProduct function is not executed. The solution shouldn't be just calculate the order, or the line, but to call the callback, so that we ensure that any other logic which may be required will also be executed. Besides this, we should also most probably ensure that the hook OBPOS_PostAddProductToOrder, which should be executed always after a product is added to the order, is also called in this flow. |
|
(0102272) hgbot (developer) 2018-02-08 14:33 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 570f8066840e820d7b973d21749591dc32b1e66c Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu> Date: Wed Feb 07 14:17:27 2018 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/570f8066840e820d7b973d21749591dc32b1e66c [^] Related to issue 37769: Verified returns is not working with scaled products: total line is set to 0 --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-01-30 12:57 | malsasua | New Issue | |
| 2018-01-30 12:57 | malsasua | Assigned To | => Retail |
| 2018-01-30 12:57 | malsasua | OBNetwork customer | => Yes |
| 2018-01-30 12:57 | malsasua | Support ticket | => 50635 |
| 2018-01-30 12:57 | malsasua | Resolution time | => 1519254000 |
| 2018-01-30 12:57 | malsasua | Triggers an Emergency Pack | => No |
| 2018-01-30 12:58 | malsasua | Steps to Reproduce Updated | View Revisions |
| 2018-01-30 12:59 | malsasua | File Added: error.png | |
| 2018-01-30 12:59 | malsasua | Relationship added | related to 0037762 |
| 2018-01-30 13:01 | malsasua | Steps to Reproduce Updated | View Revisions |
| 2018-01-30 13:02 | malsasua | Relationship added | related to 0037771 |
| 2018-01-30 22:15 | rqueralta | Assigned To | Retail => rqueralta |
| 2018-01-30 22:22 | rqueralta | Status | new => scheduled |
| 2018-02-06 15:21 | hgbot | Checkin | |
| 2018-02-06 15:21 | hgbot | Note Added: 0102220 | |
| 2018-02-06 15:21 | hgbot | Status | scheduled => resolved |
| 2018-02-06 15:21 | hgbot | Resolution | open => fixed |
| 2018-02-06 15:21 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1009a30c23c729e4033b592b12e40d1e034fb7d4 [^] |
| 2018-02-06 19:32 | marvintm | Note Added: 0102228 | |
| 2018-02-06 19:32 | marvintm | Status | resolved => new |
| 2018-02-06 19:32 | marvintm | Resolution | fixed => open |
| 2018-02-08 14:33 | hgbot | Checkin | |
| 2018-02-08 14:33 | hgbot | Note Added: 0102272 | |
| 2018-02-08 16:09 | marvintm | Status | new => scheduled |
| 2018-02-08 16:09 | marvintm | Status | scheduled => resolved |
| 2018-02-08 16:09 | marvintm | Resolution | open => fixed |
| 2018-02-26 09:08 | marvintm | Review Assigned To | => marvintm |
| 2018-02-26 09:08 | marvintm | Status | resolved => closed |
| 2018-02-26 09:08 | marvintm | Fixed in Version | => RR18Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |