Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0037769 | Retail Modules | Web POS | public | 2018-01-30 12:57 | 2018-02-26 09:08 |
|
| Reporter | malsasua | |
| Assigned To | rqueralta | |
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | RR17Q4 | |
| Target Version | | Fixed in Version | RR18Q2 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0037769: Verified returns is not working with scaled products: total line is set to 0 |
| Description | When a line of scaled product is selected in verified returns functionality, the line is added with 0 amount in the ticket |
| Steps To Reproduce | . reproducible in 17Q4, in pi there is another previous error
BO:
. create a new product (p1), with "is scaled" Y
. add in pricelist (price: 5) and assortment
. configure "pos terminal":
hw manager: http://localhost:8090/printer [^] [^]
Scale: http://localhost:8090/scale [^] [^]
. open hw manager in localhost
POS:
. create new ticket:
. new line: p1 -> qty: 1.181
. total ticket 5.91
. pay ticket
. open verifier return selector:_
. select previous ticket
. select all lines and add them to the current ticket
. line 1: p1 - qty: 1.181 - total 0 -> WRONG:it should be -5.91
. total ticket: 0 -> WRONG: it should be -5.91
(see attachment) |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | related to | defect | 0037762 | | closed | rqueralta | Verified returns is not working with scaled products | | related to | defect | 0037771 | | closed | rqueralta | Verified returns is not working with scaled products: loading window never is hidden |
|
| Attached Files |  error.png (183,103) 2018-01-30 12:59
https://issues.openbravo.com/file_download.php?file_id=11501&type=bug
|
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2018-01-30 12:57 | malsasua | New Issue | |
| 2018-01-30 12:57 | malsasua | Assigned To | => Retail |
| 2018-01-30 12:57 | malsasua | Resolution time | => 1519254000 |
| 2018-01-30 12:57 | malsasua | Triggers an Emergency Pack | => No |
| 2018-01-30 12:58 | malsasua | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=16609#r16609 |
| 2018-01-30 12:59 | malsasua | File Added: error.png | |
| 2018-01-30 12:59 | malsasua | Relationship added | related to 0037762 |
| 2018-01-30 13:01 | malsasua | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=16611#r16611 |
| 2018-01-30 13:02 | malsasua | Relationship added | related to 0037771 |
| 2018-01-30 22:15 | rqueralta | Assigned To | Retail => rqueralta |
| 2018-01-30 22:22 | rqueralta | Status | new => scheduled |
| 2018-02-06 15:21 | hgbot | Checkin | |
| 2018-02-06 15:21 | hgbot | Note Added: 0102220 | |
| 2018-02-06 15:21 | hgbot | Status | scheduled => resolved |
| 2018-02-06 15:21 | hgbot | Resolution | open => fixed |
| 2018-02-06 15:21 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1009a30c23c729e4033b592b12e40d1e034fb7d4 [^] |
| 2018-02-06 19:32 | marvintm | Note Added: 0102228 | |
| 2018-02-06 19:32 | marvintm | Status | resolved => new |
| 2018-02-06 19:32 | marvintm | Resolution | fixed => open |
| 2018-02-08 14:33 | hgbot | Checkin | |
| 2018-02-08 14:33 | hgbot | Note Added: 0102272 | |
| 2018-02-08 16:09 | marvintm | Status | new => scheduled |
| 2018-02-08 16:09 | marvintm | Status | scheduled => resolved |
| 2018-02-08 16:09 | marvintm | Resolution | open => fixed |
| 2018-02-26 09:08 | marvintm | Review Assigned To | => marvintm |
| 2018-02-26 09:08 | marvintm | Status | resolved => closed |
| 2018-02-26 09:08 | marvintm | Fixed in Version | => RR18Q2 |
|
Notes |
|
|
(0102220)
|
|
hgbot
|
|
2018-02-06 15:21
|
|
|
|
|
|
The fix is not exactly correct. In this case, the main problem comes from the fact that in the scale flow, the callback of the main _addProduct function is not executed. The solution shouldn't be just calculate the order, or the line, but to call the callback, so that we ensure that any other logic which may be required will also be executed.
Besides this, we should also most probably ensure that the hook OBPOS_PostAddProductToOrder, which should be executed always after a product is added to the order, is also called in this flow. |
|
|
|
(0102272)
|
|
hgbot
|
|
2018-02-08 14:33
|
|
|