Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0037767 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2018-01-30 12:05 | 2018-03-06 18:43 | |||
| Reporter | jorge-garcia | View Status | public | |||||
| Assigned To | jorge-garcia | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | RR18Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d6e6623b3023 | ||||
| Projection | none | ETA | none | Target Version | RR18Q2 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0037767: Manual By Total Discounts are not applied with Discount Category module installed | |||||||
| Description | Manual By Total Discounts are not applied with Discount Category module installed | |||||||
| Steps To Reproduce | 1) Install Discounts By Total and Discounts Category modules 2) In The ERP 2.1) Create a new Fixed Amount By total discount and save it 3) Login webPOS 3.1) Add a product 3.2) Go to Receipt Discount menu entry in Menu 3.3) In The combo, select the previous discount created 3.4) Click on apply button 3.5) The manual promotion by total is not applied 4) Try the same steps without Discounts Category module and verify the promotion is applied correctly. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0102054) hgbot (developer) 2018-01-30 13:08 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: edb6a536b2a0144fa8ff8be5961adfeac09e6965 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 30 12:19:11 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/edb6a536b2a0144fa8ff8be5961adfeac09e6965 [^] Fixed issue 37767: Manual By Total Discounts are not applied with Discount Category module installed The changeDiscount function has changed: * Now, the function in posterminal implements a hook to be used by other modules. * The function should not be extended, it should register the hook to implement the code. * The function implement the UX logic for this part of webPOS. --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js --- |
|
(0102056) hgbot (developer) 2018-01-30 13:09 |
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal Changeset: d6393cadf54edff7388ca75a7587ebed13ac35d8 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 30 13:08:54 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/d6393cadf54edff7388ca75a7587ebed13ac35d8 [^] Related to issue 37767: Manual By Total Discounts are not applied with Discount Category module installed By total no longer wraps the function discountChaned, and use the hook OBPOS_preDiscountChangeHook implemented in posterminal to implements it’s code TicketLineChecked function as it was except for the jslint error fixed. --- M web/org.openbravo.retail.discounts.bytotal/js/preApplyDiscountsHook.js M web/org.openbravo.retail.discounts.bytotal/js/ticketdiscountExtension.js --- |
|
(0102065) hgbot (developer) 2018-01-30 16:53 |
Repository: erp/pmods/org.openbravo.retail.discounts.category Changeset: 3b025becb79a1fdac8c9ed56b1d08d4b009a2e20 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 30 16:53:05 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.category/rev/3b025becb79a1fdac8c9ed56b1d08d4b009a2e20 [^] Related to issue 37767: Manual By Total Discounts are not applied with Discount Category module installed Backed out changeset c0ad5b95fed3 --- M web/org.openbravo.retail.discounts.category/js/discountsButton.js --- |
|
(0102066) hgbot (developer) 2018-01-30 16:53 |
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal Changeset: 656045060254d80b4b15f94615612f8a140b7b31 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 30 16:52:05 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/656045060254d80b4b15f94615612f8a140b7b31 [^] Related to issue 37767: Manual By Total Discounts are not applied with Discount Category module installed Backed out changeset d6393cadf54e --- M web/org.openbravo.retail.discounts.bytotal/js/preApplyDiscountsHook.js M web/org.openbravo.retail.discounts.bytotal/js/ticketdiscountExtension.js --- |
|
(0102067) hgbot (developer) 2018-01-30 16:54 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ed1f6c9402e174e52fe0657ce8ba64e7a564a82e Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Jan 30 16:52:31 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ed1f6c9402e174e52fe0657ce8ba64e7a564a82e [^] Related to issue 37767: Manual By Total Discounts are not applied with Discount Category module installed Backed out changeset edb6a536b2a0 --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js --- |
|
(0102072) jorge-garcia (reporter) 2018-01-30 17:43 |
Revert changes due to errors in CI |
|
(0102126) hgbot (developer) 2018-02-02 08:28 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: d6e6623b30235b0a2663ae7ae893a737be489c8a Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Wed Jan 31 12:54:27 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d6e6623b30235b0a2663ae7ae893a737be489c8a [^] Fixed issue 37767: Manual By Total Discounts are not applied with Discount Category module installed The changeDiscount function has changed: * Now, the function in posterminal implements a hook to be used by other modules. * The function should not be extended, it should register the hook to implement the code. * The function implement the UX logic for this part of webPOS. --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/ticketdiscount.js --- |
|
(0102127) hgbot (developer) 2018-02-02 08:28 |
Repository: erp/pmods/org.openbravo.retail.discounts.bytotal Changeset: eeba11a435063392d6a643f3b8abd5e1a9996beb Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Wed Jan 31 12:05:41 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/eeba11a435063392d6a643f3b8abd5e1a9996beb [^] Related to issue 37767: Manual By Total Discounts are not applied with Discount Category module installed By total no longer wraps the function discountChaned, and use the hook OBPOS_preDiscountChangeHook implemented in posterminal to implements it’s code TicketLineChecked function as it was except for the jslint error fixed. --- M web/org.openbravo.retail.discounts.bytotal/js/preApplyDiscountsHook.js M web/org.openbravo.retail.discounts.bytotal/js/ticketdiscountExtension.js --- |
|
(0102128) hgbot (developer) 2018-02-02 08:28 |
Repository: erp/pmods/org.openbravo.retail.discounts.category Changeset: 9fff6be3b5de16787c0930e43b17d3638079469d Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Wed Jan 31 12:07:08 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.category/rev/9fff6be3b5de16787c0930e43b17d3638079469d [^] Related to issue 37767: Manual By Total Discounts are not applied with Discount Category module installed Discounts Category module uses now the hook OBPOS_preDiscountChangeHook to implement the logic instead of extending the logic implemented in posterminal module. Fixed performance problem with the search of manual discounts in discount category combo. --- M web/org.openbravo.retail.discounts.category/js/discountsButton.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2018-01-30 12:05 | jorge-garcia | New Issue | |
| 2018-01-30 12:05 | jorge-garcia | Assigned To | => jorge-garcia |
| 2018-01-30 12:05 | jorge-garcia | Triggers an Emergency Pack | => No |
| 2018-01-30 12:06 | jorge-garcia | Relationship added | related to 0037462 |
| 2018-01-30 13:08 | hgbot | Checkin | |
| 2018-01-30 13:08 | hgbot | Note Added: 0102054 | |
| 2018-01-30 13:08 | hgbot | Status | new => resolved |
| 2018-01-30 13:08 | hgbot | Resolution | open => fixed |
| 2018-01-30 13:08 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/edb6a536b2a0144fa8ff8be5961adfeac09e6965 [^] |
| 2018-01-30 13:09 | hgbot | Checkin | |
| 2018-01-30 13:09 | hgbot | Note Added: 0102056 | |
| 2018-01-30 16:53 | hgbot | Checkin | |
| 2018-01-30 16:53 | hgbot | Note Added: 0102065 | |
| 2018-01-30 16:53 | hgbot | Checkin | |
| 2018-01-30 16:53 | hgbot | Note Added: 0102066 | |
| 2018-01-30 16:54 | hgbot | Checkin | |
| 2018-01-30 16:54 | hgbot | Note Added: 0102067 | |
| 2018-01-30 17:43 | jorge-garcia | Note Added: 0102072 | |
| 2018-02-02 08:28 | hgbot | Checkin | |
| 2018-02-02 08:28 | hgbot | Note Added: 0102126 | |
| 2018-02-02 08:28 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/edb6a536b2a0144fa8ff8be5961adfeac09e6965 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d6e6623b30235b0a2663ae7ae893a737be489c8a [^] |
| 2018-02-02 08:28 | hgbot | Checkin | |
| 2018-02-02 08:28 | hgbot | Note Added: 0102127 | |
| 2018-02-02 08:28 | hgbot | Checkin | |
| 2018-02-02 08:28 | hgbot | Note Added: 0102128 | |
| 2018-03-06 18:43 | marvintm | Review Assigned To | => marvintm |
| 2018-03-06 18:43 | marvintm | Status | resolved => closed |
| 2018-03-06 18:43 | marvintm | Fixed in Version | => RR18Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |