Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037462
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorrandom2017-12-12 14:182018-01-30 13:09
ReportermalsasuaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR18Q1
StatusclosedFix in branchFixed in SCM revisionf47951bc013d
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037462: Error randomly with modules Discount rules for Retail by total and Discounts category for WebPOS

Descriptionwhen installed the below two modules:
.Discount rules for Retail by total
.Discounts category for WebPOS

depends of order that the static resources are included in the whole javascript (randomly because the two modules have got the same dependencies), one error is returned:
Uncaught TypeError: Cannot read property 'model' of undefined
at Object.discountChanged (8a6fdaecf35207c14a5eff5c0b7f047f.js:75568)

In DiscountsUIPrototype.discountChanged, it requires to call to the function bind with arrguments, but it is called without arguments

Steps To Reproduce. install the two modules
. in terminal, create a new ticket and apply a manual discount
Proposed Solutionsee attachment
TagsNo tags attached.
Attached Filesdiff file icon patchDiscByTotal.diff [^] (912 bytes) 2017-12-12 14:18 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0037767RR18Q2 closedjorge-garcia Manual By Total Discounts are not applied with Discount Category module installed 

-  Notes
(0101085)
hgbot (developer)
2017-12-17 18:48

 Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: f47951bc013de1d45e60d4589bfe0f268210efed
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Sun Dec 17 23:18:18 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/f47951bc013de1d45e60d4589bfe0f268210efed [^]

Fixed issue 37462 : Bind arguments in discountChanged function

---
M web/org.openbravo.retail.discounts.bytotal/js/ticketdiscountExtension.js
---
(0101145)
marvintm (manager)
2017-12-19 18:15

 It seems the fix still doesn't work correctly in the customer environment.
(0101177)
hgbot (developer)
2017-12-21 07:19

 Repository: erp/pmods/org.openbravo.retail.discounts.bytotal
Changeset: 2f219563540021b25e9b44866de273e34dfd4ec1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Thu Dec 21 11:49:21 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/2f219563540021b25e9b44866de273e34dfd4ec1 [^]

Related to issue 37462 : Get Discount Rule from model instead of discount combo

* If discount bytotal and category module are present, discount combo will be overridden by button.
  So for duscount Rule, fetch it from model assigned to discountsContainer instead of combo.

---
M web/org.openbravo.retail.discounts.bytotal/js/ticketdiscountExtension.js
---
(0102057)
hgbot (developer)
2018-01-30 13:09

 Repository: erp/pmods/org.openbravo.retail.discounts.category
Changeset: c0ad5b95fed35bd5e0b4c4b4d07c925fc298ebf0
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Jan 30 11:01:37 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.category/rev/c0ad5b95fed35bd5e0b4c4b4d07c925fc298ebf0 [^]

Related to issue 37462: Error randomly with modules Discount rules for
Retail by total and Discounts category for WebPOS

Discounts Category module uses now the hook OBPOS_preDiscountChangeHook
to implement the logic instead of extending the logic implemented in
posterminal module.

Fixed performance problem with the search of manual discounts in discount category
combo.

---
M web/org.openbravo.retail.discounts.category/js/discountsButton.js
---

- Issue History
Date Modified Username Field Change
2017-12-12 14:18 malsasua New Issue
2017-12-12 14:18 malsasua Assigned To => Retail
2017-12-12 14:18 malsasua File Added: patchDiscByTotal.diff
2017-12-12 14:18 malsasua Resolution time => 1515020400
2017-12-12 14:18 malsasua Triggers an Emergency Pack => No
2017-12-12 16:15 malsasua Description Updated View Revisions
2017-12-14 16:04 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2017-12-14 16:04 ranjith_qualiantech_com Status new => scheduled
2017-12-17 18:48 hgbot Checkin
2017-12-17 18:48 hgbot Note Added: 0101085
2017-12-17 18:48 hgbot Status scheduled => resolved
2017-12-17 18:48 hgbot Resolution open => fixed
2017-12-17 18:48 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts.bytotal/rev/f47951bc013de1d45e60d4589bfe0f268210efed [^]
2017-12-19 18:15 marvintm Note Added: 0101145
2017-12-19 18:15 marvintm Status resolved => new
2017-12-19 18:15 marvintm Resolution fixed => open
2017-12-21 07:06 ranjith_qualiantech_com Status new => scheduled
2017-12-21 07:19 hgbot Checkin
2017-12-21 07:19 hgbot Note Added: 0101177
2017-12-21 10:10 ranjith_qualiantech_com Status scheduled => resolved
2017-12-21 10:10 ranjith_qualiantech_com Resolution open => fixed
2017-12-22 11:40 marvintm Review Assigned To => marvintm
2017-12-22 11:40 marvintm Status resolved => closed
2017-12-22 11:40 marvintm Fixed in Version => RR18Q1
2018-01-30 12:06 jorge-garcia Relationship added related to 0037767
2018-01-30 13:09 hgbot Checkin
2018-01-30 13:09 hgbot Note Added: 0102057

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker