Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037749
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2018-01-29 11:212018-03-08 11:07
Reportersamuel_nicuesaView Statuspublic 
Assigned Tojorge-garcia 
PriorityhighResolutionfixedFixed in VersionRR18Q2
StatusclosedFix in branchFixed in SCM revisione12f960294f8
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket50716
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037749: Attribute set value doesn't start with L if it is Lot in Product window Transactions tab

DescriptionAttribute set value doesn't start with L if it is Lot in Product window Transactions tab
Steps To Reproduce-Login into ERP using The white valley group admin.

-Go to Product window and create one record.

-Fill attribute set field:
    -Organization : *
    -Name : TRUSS
    -Description : TRUSS
    -Flag lot : Y
    -Active : Y
    -Lot Control : TRUSS

-Fill Lot Control field:
    -Organization : *
    -Name : TRUSS
    -Starting No:1.000.000
    -Increment by : 1
    -Next Assigned Number
    -Prefix: T0000-
    -Active: Y

-Go to Goods Receipt window and create one record
    -Go to lines tab and choose the previous configured product.
    -Attibute set will be T0000-xxxxx and it is incorrect.
    -Movement Qty >0
    -Save and complete

-Go to Product window and search your product
    -Go to transactions tab and attribute set value is wrong because
         doesn't start with L an it is a Lot.
Proposed SolutionAfter a discussion with AMO here are the conclusions.

When LOT/SerialNo does not have control -> The prefix is transparent to the user. It means that in webPOS "L" or "#" will not be provided as an input. Server will add this characters instead.

When LOT/SerialNo has a control defined-> The prefix is NOT transparent to the user. It means that in webPOS prefix + sequence will be provided by the user as an input.

In terms of code (developer must ensure that this is true)

there is one function to be changed

private static String generateValidAttSetInstanceDescription in AttributeUtils.java class

There "L" and "#" are being added to the input. At that point developer should chjeck that lot and serial number have or not a control. If control is defined then we will not add these characters.

To verify by developer

-> Enable Web POS Enable support for product attributes
-> create sales order
-> Load quotations and layaway

New sample data and tests should be created to verify this new functionality (working with control)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0102041)
dmiguelez (viewer)
2018-01-30 09:09

 The Issue reported is the expected behavior.

However, there is an issue in Retail because at some point it is not following the same logic.

In Retail, there is an Attribute selector, that is used to select an Attribute if it does exist some with the same Lot Number, or it creates a new Attribute if it does not exists.

However, this selector does always put the "L" prefix before looking for the Attribute. If it has been created with a different suffix, like in the case reported by the issue, it does not find it and then it creates a new one, which is not the expected behavior.
(0103007)
hgbot (developer)
2018-03-06 08:38

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e12f960294f894265778506caeb345270e84d11f
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Feb 26 15:56:49 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e12f960294f894265778506caeb345270e84d11f [^]

Fixed issue 37749: Attribute set value doesn't start with L if it is Lot
in Product window Transactions tab

If lot or serial product has lot control or serial number control, the
attribute is set using the info provided by the user.

If no lot control or no serial number control the server generates an
attribute hardcoded.

---
M src/org/openbravo/retail/posterminal/utility/AttributesUtils.java
---
(0103008)
hgbot (developer)
2018-03-06 08:38

 Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: f2e69eea057828394edb3736c7bc3806e9eae962
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Feb 28 12:35:57 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/f2e69eea057828394edb3736c7bc3806e9eae962 [^]

Related to issue 37749: Attribute set value doesn't start with L if it is Lot in
Product window Transactions tab

Added new sampledata for this issue

---
M referencedata/sampledata/The_White_Valley_Group/AD_SEQUENCE.xml
M referencedata/sampledata/The_White_Valley_Group/M_ATTRIBUTESET.xml
M referencedata/sampledata/The_White_Valley_Group/M_ATTRIBUTESETINSTANCE.xml
M referencedata/sampledata/The_White_Valley_Group/M_INOUT.xml
M referencedata/sampledata/The_White_Valley_Group/M_INOUTLINE.xml
M referencedata/sampledata/The_White_Valley_Group/M_LOTCTL.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCTPRICE.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT_ACCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_SERNOCTL.xml
M referencedata/sampledata/The_White_Valley_Group/M_STORAGE_DETAIL.xml
M referencedata/sampledata/The_White_Valley_Group/M_TRANSACTION.xml
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_PROL_PRODUCT.xml
---
(0103009)
hgbot (developer)
2018-03-06 08:39

 Repository: tools/automation/pi-mobile
Changeset: e5ae9bb3436718e24001ea1f29774da69d38a1d3
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Mar 01 08:40:49 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e5ae9bb3436718e24001ea1f29774da69d38a1d3 [^]

Verifies issue 37749: Attribute set value doesn't start with L if it is Lot in
Product window Transactions tab

Added test I37749_AttributeSetsAndControls.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/attributes/I37749_AttributeSetsAndControls.java
---
(0103010)
hgbot (developer)
2018-03-06 08:39

 Repository: tools/automation/pi-mobile
Changeset: 8f9d73e177c7a98b8166760fe2d9cd9010a45fc3
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Mar 02 11:04:19 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/8f9d73e177c7a98b8166760fe2d9cd9010a45fc3 [^]

Related to issue 37749: Attribute set value doesn't start with L if it is Lot in
Product window Transactions tab

Change two test related to sampledata changes.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/attributes/ATT020A_AttributesLayawaysChecks.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/highvolume/ProductCharacteristicsSearchProductChangesCharacteristic_HV.java
---

- Issue History
Date Modified Username Field Change
2018-01-29 11:21 samuel_nicuesa New Issue
2018-01-29 11:21 samuel_nicuesa Assigned To => Triage Finance
2018-01-29 11:21 samuel_nicuesa OBNetwork customer => Yes
2018-01-29 11:21 samuel_nicuesa Modules => Core
2018-01-29 11:21 samuel_nicuesa Support ticket => 50716
2018-01-29 11:21 samuel_nicuesa Resolution time => 1518994800
2018-01-29 11:21 samuel_nicuesa Triggers an Emergency Pack => No
2018-01-29 16:03 dmiguelez Assigned To Triage Finance => collazoandy4
2018-01-30 09:06 dmiguelez Assigned To collazoandy4 => Retail
2018-01-30 09:09 dmiguelez Note Added: 0102041
2018-02-21 13:19 jorge-garcia Project Openbravo ERP => Retail Modules
2018-02-21 13:20 jorge-garcia Category 04. Warehouse management => Web POS
2018-02-21 13:27 jorge-garcia Status new => scheduled
2018-02-22 11:37 guilleaer Proposed Solution updated
2018-02-26 15:29 jorge-garcia Proposed Solution updated
2018-02-26 15:54 jorge-garcia Summary Attribute set value doesn't start with L if it is Lot in (Product window - tab Transactions) => Attribute set value doesn't start with L if it is Lot in Product window Transactions tab
2018-02-26 15:54 jorge-garcia Description Updated View Revisions
2018-02-27 09:38 jorge-garcia Assigned To Retail => jorge-garcia
2018-03-06 08:38 hgbot Checkin
2018-03-06 08:38 hgbot Note Added: 0103007
2018-03-06 08:38 hgbot Status scheduled => resolved
2018-03-06 08:38 hgbot Resolution open => fixed
2018-03-06 08:38 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e12f960294f894265778506caeb345270e84d11f [^]
2018-03-06 08:38 hgbot Checkin
2018-03-06 08:38 hgbot Note Added: 0103008
2018-03-06 08:39 hgbot Checkin
2018-03-06 08:39 hgbot Note Added: 0103009
2018-03-06 08:39 hgbot Checkin
2018-03-06 08:39 hgbot Note Added: 0103010
2018-03-08 11:07 marvintm Review Assigned To => marvintm
2018-03-08 11:07 marvintm Status resolved => closed
2018-03-08 11:07 marvintm Fixed in Version => RR18Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker