Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037749Retail ModulesWeb POSpublic2018-01-29 11:212018-03-08 11:07
Reportersamuel_nicuesa 
Assigned Tojorge-garcia 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket50716
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037749: Attribute set value doesn't start with L if it is Lot in Product window Transactions tab
DescriptionAttribute set value doesn't start with L if it is Lot in Product window Transactions tab
Steps To Reproduce-Login into ERP using The white valley group admin.

-Go to Product window and create one record.

-Fill attribute set field:
    -Organization : *
    -Name : TRUSS
    -Description : TRUSS
    -Flag lot : Y
    -Active : Y
    -Lot Control : TRUSS

-Fill Lot Control field:
    -Organization : *
    -Name : TRUSS
    -Starting No:1.000.000
    -Increment by : 1
    -Next Assigned Number
    -Prefix: T0000-
    -Active: Y

-Go to Goods Receipt window and create one record
    -Go to lines tab and choose the previous configured product.
    -Attibute set will be T0000-xxxxx and it is incorrect.
    -Movement Qty >0
    -Save and complete

-Go to Product window and search your product
    -Go to transactions tab and attribute set value is wrong because
         doesn't start with L an it is a Lot.
Proposed SolutionAfter a discussion with AMO here are the conclusions.

When LOT/SerialNo does not have control -> The prefix is transparent to the user. It means that in webPOS "L" or "#" will not be provided as an input. Server will add this characters instead.

When LOT/SerialNo has a control defined-> The prefix is NOT transparent to the user. It means that in webPOS prefix + sequence will be provided by the user as an input.

In terms of code (developer must ensure that this is true)

there is one function to be changed

private static String generateValidAttSetInstanceDescription in AttributeUtils.java class

There "L" and "#" are being added to the input. At that point developer should chjeck that lot and serial number have or not a control. If control is defined then we will not add these characters.

To verify by developer

-> Enable Web POS Enable support for product attributes
-> create sales order
-> Load quotations and layaway

New sample data and tests should be created to verify this new functionality (working with control)
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2018-01-29 11:21samuel_nicuesaNew Issue
2018-01-29 11:21samuel_nicuesaAssigned To => Triage Finance
2018-01-29 11:21samuel_nicuesaOBNetwork customer => Yes
2018-01-29 11:21samuel_nicuesaModules => Core
2018-01-29 11:21samuel_nicuesaSupport ticket => 50716
2018-01-29 11:21samuel_nicuesaResolution time => 1518994800
2018-01-29 11:21samuel_nicuesaTriggers an Emergency Pack => No
2018-01-29 16:03dmiguelezAssigned ToTriage Finance => collazoandy4
2018-01-30 09:06dmiguelezAssigned Tocollazoandy4 => Retail
2018-01-30 09:09dmiguelezNote Added: 0102041
2018-02-21 13:19jorge-garciaProjectOpenbravo ERP => Retail Modules
2018-02-21 13:20jorge-garciaCategory04. Warehouse management => Web POS
2018-02-21 13:27jorge-garciaStatusnew => scheduled
2018-02-22 11:37guilleaerProposed Solution updated
2018-02-26 15:29jorge-garciaProposed Solution updated
2018-02-26 15:54jorge-garciaSummaryAttribute set value doesn't start with L if it is Lot in (Product window - tab Transactions) => Attribute set value doesn't start with L if it is Lot in Product window Transactions tab
2018-02-26 15:54jorge-garciaDescription Updatedbug_revision_view_page.php?rev_id=16773#r16773
2018-02-27 09:38jorge-garciaAssigned ToRetail => jorge-garcia
2018-03-06 08:38hgbotCheckin
2018-03-06 08:38hgbotNote Added: 0103007
2018-03-06 08:38hgbotStatusscheduled => resolved
2018-03-06 08:38hgbotResolutionopen => fixed
2018-03-06 08:38hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e12f960294f894265778506caeb345270e84d11f [^]
2018-03-06 08:38hgbotCheckin
2018-03-06 08:38hgbotNote Added: 0103008
2018-03-06 08:39hgbotCheckin
2018-03-06 08:39hgbotNote Added: 0103009
2018-03-06 08:39hgbotCheckin
2018-03-06 08:39hgbotNote Added: 0103010
2018-03-08 11:07marvintmReview Assigned To => marvintm
2018-03-08 11:07marvintmStatusresolved => closed
2018-03-08 11:07marvintmFixed in Version => RR18Q2

Notes
(0102041)
dmiguelez   
2018-01-30 09:09   
The Issue reported is the expected behavior.

However, there is an issue in Retail because at some point it is not following the same logic.

In Retail, there is an Attribute selector, that is used to select an Attribute if it does exist some with the same Lot Number, or it creates a new Attribute if it does not exists.

However, this selector does always put the "L" prefix before looking for the Attribute. If it has been created with a different suffix, like in the case reported by the issue, it does not find it and then it creates a new one, which is not the expected behavior.
(0103007)
hgbot   
2018-03-06 08:38   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e12f960294f894265778506caeb345270e84d11f
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Feb 26 15:56:49 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e12f960294f894265778506caeb345270e84d11f [^]

Fixed issue 37749: Attribute set value doesn't start with L if it is Lot
in Product window Transactions tab

If lot or serial product has lot control or serial number control, the
attribute is set using the info provided by the user.

If no lot control or no serial number control the server generates an
attribute hardcoded.

---
M src/org/openbravo/retail/posterminal/utility/AttributesUtils.java
---
(0103008)
hgbot   
2018-03-06 08:38   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: f2e69eea057828394edb3736c7bc3806e9eae962
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Feb 28 12:35:57 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/f2e69eea057828394edb3736c7bc3806e9eae962 [^]

Related to issue 37749: Attribute set value doesn't start with L if it is Lot in
Product window Transactions tab

Added new sampledata for this issue

---
M referencedata/sampledata/The_White_Valley_Group/AD_SEQUENCE.xml
M referencedata/sampledata/The_White_Valley_Group/M_ATTRIBUTESET.xml
M referencedata/sampledata/The_White_Valley_Group/M_ATTRIBUTESETINSTANCE.xml
M referencedata/sampledata/The_White_Valley_Group/M_INOUT.xml
M referencedata/sampledata/The_White_Valley_Group/M_INOUTLINE.xml
M referencedata/sampledata/The_White_Valley_Group/M_LOTCTL.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCTPRICE.xml
M referencedata/sampledata/The_White_Valley_Group/M_PRODUCT_ACCT.xml
M referencedata/sampledata/The_White_Valley_Group/M_SERNOCTL.xml
M referencedata/sampledata/The_White_Valley_Group/M_STORAGE_DETAIL.xml
M referencedata/sampledata/The_White_Valley_Group/M_TRANSACTION.xml
M referencedata/sampledata/The_White_Valley_Group/OBRETCO_PROL_PRODUCT.xml
---
(0103009)
hgbot   
2018-03-06 08:39   
Repository: tools/automation/pi-mobile
Changeset: e5ae9bb3436718e24001ea1f29774da69d38a1d3
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Mar 01 08:40:49 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e5ae9bb3436718e24001ea1f29774da69d38a1d3 [^]

Verifies issue 37749: Attribute set value doesn't start with L if it is Lot in
Product window Transactions tab

Added test I37749_AttributeSetsAndControls.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/attributes/I37749_AttributeSetsAndControls.java
---
(0103010)
hgbot   
2018-03-06 08:39   
Repository: tools/automation/pi-mobile
Changeset: 8f9d73e177c7a98b8166760fe2d9cd9010a45fc3
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Fri Mar 02 11:04:19 2018 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/8f9d73e177c7a98b8166760fe2d9cd9010a45fc3 [^]

Related to issue 37749: Attribute set value doesn't start with L if it is Lot in
Product window Transactions tab

Change two test related to sampledata changes.

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/attributes/ATT020A_AttributesLayawaysChecks.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/highvolume/ProductCharacteristicsSearchProductChangesCharacteristic_HV.java
---