Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0037727

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2018-01-25 13:40

2018-02-05 12:09

Reporter

marvintm

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

normal

Resolution

fixed

Fixed in Version

RR18Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0037727: In some very specific cases the optimistic locking mechanism may fail to find a concurrent modification

Description

The optimistic locking mechanism which exists in the OrderLoader is using a flag which contains the timestap of the order. However, this timestamp is generated in PaidReceipts.java, and is generated from the current timestamp of the system, instead of reading the updated column of the order.

This works in most of the cases, but theoretically it could happen that a concurrent transaction may change the updated value while the PaidReceipts.java request is being executed, and in this case, the check in the OrderLoader would not detect the change.

Steps To Reproduce

It is very difficult to reproduce this problem using the system normally. The best way to reproduce it is by using Eclipse and setting timeouts in PaidReceipts.java (after the timestamp has been generated), and then changing the receipt.

Proposed Solution

Instead of generating a timestamp when reading the order, just use the "updated" column of the order itself.

Tags

No tags attached.

issue37727.patch [^] (1,933 bytes) 2018-01-25 14:07 [Show Content] [Hide Content]

diff -r 42e33274a65c src/org/openbravo/retail/posterminal/OrderLoader.java
--- a/src/org/openbravo/retail/posterminal/OrderLoader.java	Thu Jan 25 11:08:08 2018 +0100
+++ b/src/org/openbravo/retail/posterminal/OrderLoader.java	Thu Jan 25 14:06:49 2018 +0100
@@ -264,7 +264,7 @@
         if (order != null) {
           final Date loaded = POSUtils.dateFormatUTC.parse(jsonorder.getString("loaded")), updated = OBMOBCUtils
               .convertToUTC(order.getUpdated());
-          if (!(loaded.compareTo(updated) >= 0)) {
+          if (loaded.compareTo(updated) != 0) {
             throw new OutDatedDataChangeException(Utility.messageBD(
                 new DalConnectionProvider(false), "OBPOS_outdatedLayaway", OBContext.getOBContext()
                     .getLanguage().getLanguage()));
diff -r 42e33274a65c src/org/openbravo/retail/posterminal/PaidReceiptProperties.java
--- a/src/org/openbravo/retail/posterminal/PaidReceiptProperties.java	Thu Jan 25 11:08:08 2018 +0100
+++ b/src/org/openbravo/retail/posterminal/PaidReceiptProperties.java	Thu Jan 25 14:06:49 2018 +0100
@@ -62,6 +62,7 @@
         add(new HQLProperty("replacedOrder.id", "replacedorder"));
         add(new HQLProperty("ord.iscancelled", "iscancelled"));
         add(new HQLProperty("'false'", "isModified"));
+        add(new HQLProperty("ord.updated", "loaded"));
       }
     };
 
diff -r 42e33274a65c src/org/openbravo/retail/posterminal/PaidReceipts.java
--- a/src/org/openbravo/retail/posterminal/PaidReceipts.java	Thu Jan 25 11:08:08 2018 +0100
+++ b/src/org/openbravo/retail/posterminal/PaidReceipts.java	Thu Jan 25 14:06:49 2018 +0100
@@ -115,7 +115,6 @@
         }
 
         paidReceipt.put("orderid", orderid);
-        paidReceipt.put("loaded", parseDateFormat.format(new Date()));
 
         // get the Invoice for the Order
         String hqlPaidReceiptsInvoice = "select inv.id from Invoice as inv where inv.salesOrder.id = :orderId";

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0102168) hgbot (developer) 2018-02-05 09:33	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 7a9f2722b17516562a69692b6913fa0b04d520bb Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Feb 05 14:03:28 2018 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a9f2722b17516562a69692b6913fa0b04d520bb [^] Fixed issue 37727 : Verify Outdated data with order updated instead of timestamp --- M src/org/openbravo/retail/posterminal/OrderLoader.java M src/org/openbravo/retail/posterminal/PaidReceiptProperties.java M src/org/openbravo/retail/posterminal/PaidReceipts.java ---

(0102169) hgbot (developer) 2018-02-05 09:34	Repository: tools/automation/pi-mobile Changeset: 77363b563aee01450253db52d856acae105db4db Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Feb 05 14:03:36 2018 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/77363b563aee01450253db52d856acae105db4db [^] Verifies issue 37727 : Modified automated test 'BaseRetailOrderLoaderTest' --- M src-test/org/openbravo/test/mobile/retail/pack/webservice/tests/orderloader/BaseRetailOrderLoaderTest.java ---

Issue History
Date Modified	Username	Field	Change
2018-01-25 13:40	marvintm	New Issue
2018-01-25 13:40	marvintm	Assigned To	=> Retail
2018-01-25 13:40	marvintm	Triggers an Emergency Pack	=> No
2018-01-25 13:43	marvintm	File Added: issue37727.patch
2018-01-25 13:44	marvintm	Resolution time	=> 1518044400
2018-01-25 14:07	marvintm	File Deleted: issue37727.patch
2018-01-25 14:07	marvintm	File Added: issue37727.patch
2018-01-30 15:42	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2018-01-30 15:42	ranjith_qualiantech_com	Status	new => scheduled
2018-02-05 09:33	hgbot	Checkin
2018-02-05 09:33	hgbot	Note Added: 0102168
2018-02-05 09:33	hgbot	Status	scheduled => resolved
2018-02-05 09:33	hgbot	Resolution	open => fixed
2018-02-05 09:33	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a9f2722b17516562a69692b6913fa0b04d520bb [^]
2018-02-05 09:34	hgbot	Checkin
2018-02-05 09:34	hgbot	Note Added: 0102169
2018-02-05 12:09	marvintm	Review Assigned To	=> marvintm
2018-02-05 12:09	marvintm	Status	resolved => closed
2018-02-05 12:09	marvintm	Fixed in Version	=> RR18Q2

Copyright © 2000 - 2009 MantisBT Group