Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0037727 | Retail Modules | Web POS | public | 2018-01-25 13:40 | 2018-02-05 12:09 |
|
| Reporter | marvintm | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | RR18Q2 | |
| Merge Request Status | |
| Review Assigned To | marvintm |
| OBNetwork customer | OBPS |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0037727: In some very specific cases the optimistic locking mechanism may fail to find a concurrent modification |
| Description | The optimistic locking mechanism which exists in the OrderLoader is using a flag which contains the timestap of the order. However, this timestamp is generated in PaidReceipts.java, and is generated from the current timestamp of the system, instead of reading the updated column of the order.
This works in most of the cases, but theoretically it could happen that a concurrent transaction may change the updated value while the PaidReceipts.java request is being executed, and in this case, the check in the OrderLoader would not detect the change. |
| Steps To Reproduce | It is very difficult to reproduce this problem using the system normally. The best way to reproduce it is by using Eclipse and setting timeouts in PaidReceipts.java (after the timestamp has been generated), and then changing the receipt. |
| Proposed Solution | Instead of generating a timestamp when reading the order, just use the "updated" column of the order itself. |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files |  issue37727.patch (1,933) 2018-01-25 14:07
https://issues.openbravo.com/file_download.php?file_id=11488&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2018-01-25 13:40 | marvintm | New Issue | |
| 2018-01-25 13:40 | marvintm | Assigned To | => Retail |
| 2018-01-25 13:40 | marvintm | OBNetwork customer | => No |
| 2018-01-25 13:40 | marvintm | Triggers an Emergency Pack | => No |
| 2018-01-25 13:43 | marvintm | File Added: issue37727.patch | |
| 2018-01-25 13:44 | marvintm | OBNetwork customer | No => Yes |
| 2018-01-25 13:44 | marvintm | Resolution time | => 1518044400 |
| 2018-01-25 14:07 | marvintm | File Deleted: issue37727.patch | |
| 2018-01-25 14:07 | marvintm | File Added: issue37727.patch | |
| 2018-01-30 15:42 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2018-01-30 15:42 | ranjith_qualiantech_com | Status | new => scheduled |
| 2018-02-05 09:33 | hgbot | Checkin | |
| 2018-02-05 09:33 | hgbot | Note Added: 0102168 | |
| 2018-02-05 09:33 | hgbot | Status | scheduled => resolved |
| 2018-02-05 09:33 | hgbot | Resolution | open => fixed |
| 2018-02-05 09:33 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7a9f2722b17516562a69692b6913fa0b04d520bb [^] |
| 2018-02-05 09:34 | hgbot | Checkin | |
| 2018-02-05 09:34 | hgbot | Note Added: 0102169 | |
| 2018-02-05 12:09 | marvintm | Review Assigned To | => marvintm |
| 2018-02-05 12:09 | marvintm | Status | resolved => closed |
| 2018-02-05 12:09 | marvintm | Fixed in Version | => RR18Q2 |