Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037604
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2018-01-10 09:312019-01-31 10:00
ReporterjarmendarizView Statuspublic 
Assigned Tojarmendariz 
PrioritynormalResolutionduplicateFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037604: Clean up unused methods and parameters in ToolBar

DescriptionisTest is used in the following ToolBar methods:
- prepareInfoTemplate
- prepareRelationTemplate
- prepareSortableTemplate
- prepareEditionTemplate
- prepareQueryTemplate

It is used to decide whether to call removeAllTests() which is an empty private method.

Also, there are some methods that are no longer used anywhere and they can be removed:
- prepareInfoTemplate
- prepareEditionTemplate
- prepareEditionTemplateNoSearch(boolean,boolean,String,boolean)
- prepareEditionTemplateNoSearch(boolean, boolean, boolean, boolean) (deprecated)
- prepareEditionTemplate (deprecated)
- prepareRelationTemplate (only used for prepareRelationTemplateNoSearch, so it can be converted to private method)
- prepareSimpleToolBarTemplateFrame
- prepareSimpleSaveToolbarTemplate
- prepareExcelToolBarTemplate
- prepareSortableTemplate

Unused constructors: Lines 93, 101, 109 and 131.
Steps To ReproduceIn description
TagsNo tags attached.
Attached Filespatch file icon bug-37604.patch [^] (13,560 bytes) 2018-01-23 12:36 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
duplicate of defect 00382583.0PR19Q2 closedshuehner Remove lots of old obsolete code from ToolBar class 
related to defect 0037170 closedjarmendariz SQL Query window has unneeded buttons 
blocks design defect 0032688 acknowledgedplatform remove unused resources 

-  Notes
(0101914)
jarmendariz (developer)
2018-01-23 12:43

Checked usage of these methods in all Forge's modules. The only one that is used is prepareEditionTemplate, the rest of usages refers to a reimplementation of the ToolBar class with no relation with the core one.

- Issue History
Date Modified Username Field Change
2018-01-10 09:31 jarmendariz New Issue
2018-01-10 09:31 jarmendariz Assigned To => platform
2018-01-10 09:31 jarmendariz Modules => Core
2018-01-10 09:31 jarmendariz Triggers an Emergency Pack => No
2018-01-10 09:32 jarmendariz Relationship added related to 0037170
2018-01-11 10:15 jarmendariz Summary API Change: Remove isTest parameter in some public methods of ToolBar class => API Change: Remove isTest parameter and some public methods of ToolBar class
2018-01-11 10:15 jarmendariz Description Updated View Revisions
2018-01-11 10:23 jarmendariz File Added: bug-37604.patch
2018-01-11 10:38 jarmendariz File Added: bug-37604-1.patch
2018-01-16 13:49 jarmendariz File Deleted: bug-37604.patch
2018-01-23 12:36 jarmendariz File Deleted: bug-37604-1.patch
2018-01-23 12:36 jarmendariz File Added: bug-37604.patch
2018-01-23 12:43 jarmendariz Note Added: 0101914
2018-01-23 12:47 jarmendariz Type defect => feature request
2018-01-23 12:47 jarmendariz Summary API Change: Remove isTest parameter and some public methods of ToolBar class => Clean up unused methods and parameters in ToolBar
2018-01-23 12:53 caristu Status new => acknowledged
2018-01-23 12:55 caristu Type feature request => defect
2018-09-21 09:42 jarmendariz Assigned To platform => jarmendariz
2018-11-22 09:48 alostale Relationship added blocks 0032688
2019-01-31 09:59 alostale Status acknowledged => scheduled
2019-01-31 10:00 alostale Relationship added duplicate of 0038258
2019-01-31 10:00 alostale Status scheduled => closed
2019-01-31 10:00 alostale Resolution open => duplicate


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker