Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037604Openbravo ERPA. Platformpublic2018-01-10 09:312019-01-31 10:00
Reporterjarmendariz 
Assigned Tojarmendariz 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionduplicate 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037604: Clean up unused methods and parameters in ToolBar
DescriptionisTest is used in the following ToolBar methods:
- prepareInfoTemplate
- prepareRelationTemplate
- prepareSortableTemplate
- prepareEditionTemplate
- prepareQueryTemplate

It is used to decide whether to call removeAllTests() which is an empty private method.

Also, there are some methods that are no longer used anywhere and they can be removed:
- prepareInfoTemplate
- prepareEditionTemplate
- prepareEditionTemplateNoSearch(boolean,boolean,String,boolean)
- prepareEditionTemplateNoSearch(boolean, boolean, boolean, boolean) (deprecated)
- prepareEditionTemplate (deprecated)
- prepareRelationTemplate (only used for prepareRelationTemplateNoSearch, so it can be converted to private method)
- prepareSimpleToolBarTemplateFrame
- prepareSimpleSaveToolbarTemplate
- prepareExcelToolBarTemplate
- prepareSortableTemplate

Unused constructors: Lines 93, 101, 109 and 131.
Steps To ReproduceIn description
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
duplicate of defect 00382583.0PR19Q2 closed shuehner Remove lots of old obsolete code from ToolBar class 
related to defect 0037170 closed jarmendariz SQL Query window has unneeded buttons 
blocks design defect 0032688 acknowledged Triage Platform Base remove unused resources 
Attached Filespatch bug-37604.patch (13,560) 2018-01-23 12:36
https://issues.openbravo.com/file_download.php?file_id=11478&type=bug
Issue History
Date ModifiedUsernameFieldChange
2018-01-10 09:31jarmendarizNew Issue
2018-01-10 09:31jarmendarizAssigned To => platform
2018-01-10 09:31jarmendarizModules => Core
2018-01-10 09:31jarmendarizTriggers an Emergency Pack => No
2018-01-10 09:32jarmendarizRelationship addedrelated to 0037170
2018-01-11 10:15jarmendarizSummaryAPI Change: Remove isTest parameter in some public methods of ToolBar class => API Change: Remove isTest parameter and some public methods of ToolBar class
2018-01-11 10:15jarmendarizDescription Updatedbug_revision_view_page.php?rev_id=16519#r16519
2018-01-11 10:23jarmendarizFile Added: bug-37604.patch
2018-01-11 10:38jarmendarizFile Added: bug-37604-1.patch
2018-01-16 13:49jarmendarizFile Deleted: bug-37604.patch
2018-01-23 12:36jarmendarizFile Deleted: bug-37604-1.patch
2018-01-23 12:36jarmendarizFile Added: bug-37604.patch
2018-01-23 12:43jarmendarizNote Added: 0101914
2018-01-23 12:47jarmendarizTypedefect => feature request
2018-01-23 12:47jarmendarizSummaryAPI Change: Remove isTest parameter and some public methods of ToolBar class => Clean up unused methods and parameters in ToolBar
2018-01-23 12:53caristuStatusnew => acknowledged
2018-01-23 12:55caristuTypefeature request => defect
2018-09-21 09:42jarmendarizAssigned Toplatform => jarmendariz
2018-11-22 09:48alostaleRelationship addedblocks 0032688
2019-01-31 09:59alostaleStatusacknowledged => scheduled
2019-01-31 10:00alostaleRelationship addedduplicate of 0038258
2019-01-31 10:00alostaleStatusscheduled => closed
2019-01-31 10:00alostaleResolutionopen => duplicate

Notes
(0101914)
jarmendariz   
2018-01-23 12:43   
Checked usage of these methods in all Forge's modules. The only one that is used is prepareEditionTemplate, the rest of usages refers to a reimplementation of the ToolBar class with no relation with the core one.