Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037590
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2018-01-05 12:292018-02-02 16:08
ReporterumartirenaView Statuspublic 
Assigned Tojorge-garcia 
PriorityurgentResolutionfixedFixed in VersionRR18Q2
StatusclosedFix in branchFixed in SCM revision9761635384fc
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037590: Use Credit button raises a Javascript error if Credit Limit is exceeded

DescriptionUse Credit button raises a Javascript error if Credit Limit is exceeded.

d0df6bbab747b9de4462f1736c21b0c8.js:3182 TypeError: Cannot read property 'dispatchTarget' of undefined
    at Object.focus (enyo.js:3723)
    at https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/d0df6bbab747b9de4462f1736c21b0c8.js:9678:20; [^] line: Object.OB.UTIL.showError (d0df6bbab747b9de4462f1736c21b0c8.js:12080) (*,+)
processConsoleLevel @ d0df6bbab747b9de4462f1736c21b0c8.js:3182
enyo.js:3723 Uncaught TypeError: Cannot read property 'dispatchTarget' of undefined
    at Object.focus (enyo.js:3723)
    at d0df6bbab747b9de4462f1736c21b0c8.js:9678
Steps To ReproduceIn Livebuilds ERP:
 * Open Business partner window and set Credit Line Limit 100.00 to "Arturo Montoro" business partner.
 * In Pos Terminal Type window open "VBS POS Terminal Type" and check "Allow Pay on Credit" option.

Log in Web POS: https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]

 * Set "Arturo Montoro" as Customer.
 * Add lines with amount greater than 100.00
 * Go to Payment tab and click on "Use Credit" button.
 * The javascript error is raised.
Proposed SolutionSee attached patch
TagsNo tags attached.
Attached Filesdiff file icon issue37590.diff [^] (1,182 bytes) 2018-01-05 12:31 [Show Content]
png file icon Selection_122.png [^] (153,982 bytes) 2018-01-05 12:34

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0037784 closedRetail An error raises when the limit is exceeded 

-  Notes
(0101710)
hgbot (developer)
2018-01-15 17:42

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9761635384fc2c5766e8364bd04eebd85c5abde6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 15 11:42:16 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9761635384fc2c5766e8364bd04eebd85c5abde6 [^]

Fixed issue 37590: Use Credit button raises a Javascript error if Credit
Limit is exceeded

Changed popup defintion to be a ModalAction instead of a ModalInfo.

Implement required logic for confirmation button.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalcreditsales.js
---
(0101916)
migueldejuana (developer)
2018-01-23 16:22

 Tested and reviewed
(0102156)
hgbot (developer)
2018-02-02 16:08

 Repository: tools/automation/pi-mobile
Changeset: 6bfaa49498d79ad8da63f117ed2bcbd4e73d4109
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Jan 24 13:47:48 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6bfaa49498d79ad8da63f117ed2bcbd4e73d4109 [^]

Verifies issue 37590: Added automated test 'I37590_VerifyJSErrorOnCreditPayment'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I37590_VerifyJSErrorOnCreditPayment.java
---

- Issue History
Date Modified Username Field Change
2018-01-05 12:29 umartirena New Issue
2018-01-05 12:29 umartirena Assigned To => Retail
2018-01-05 12:29 umartirena Triggers an Emergency Pack => No
2018-01-05 12:30 umartirena Proposed Solution updated
2018-01-05 12:31 umartirena File Added: issue37590.diff
2018-01-05 12:34 umartirena File Added: Selection_122.png
2018-01-15 11:51 jorge-garcia Status new => scheduled
2018-01-15 11:51 jorge-garcia Assigned To Retail => jorge-garcia
2018-01-15 17:42 hgbot Checkin
2018-01-15 17:42 hgbot Note Added: 0101710
2018-01-15 17:42 hgbot Status scheduled => resolved
2018-01-15 17:42 hgbot Resolution open => fixed
2018-01-15 17:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9761635384fc2c5766e8364bd04eebd85c5abde6 [^]
2018-01-23 16:22 migueldejuana Review Assigned To => migueldejuana
2018-01-23 16:22 migueldejuana Note Added: 0101916
2018-01-23 16:22 migueldejuana Status resolved => closed
2018-01-23 16:22 migueldejuana Fixed in Version => RR18Q2
2018-02-02 16:08 hgbot Checkin
2018-02-02 16:08 hgbot Note Added: 0102156
2018-02-05 11:14 marvintm Relationship added has duplicate 0037784

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker