Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037590Retail ModulesWeb POSpublic2018-01-05 12:292018-02-02 16:08
Reporterumartirena 
Assigned Tojorge-garcia 
PriorityurgentSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR18Q2 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037590: Use Credit button raises a Javascript error if Credit Limit is exceeded
DescriptionUse Credit button raises a Javascript error if Credit Limit is exceeded.

d0df6bbab747b9de4462f1736c21b0c8.js:3182 TypeError: Cannot read property 'dispatchTarget' of undefined
    at Object.focus (enyo.js:3723)
    at https://livebuilds.openbravo.com/retail_pi_pgsql/web/js/gen/d0df6bbab747b9de4462f1736c21b0c8.js:9678:20; [^] line: Object.OB.UTIL.showError (d0df6bbab747b9de4462f1736c21b0c8.js:12080) (*,+)
processConsoleLevel @ d0df6bbab747b9de4462f1736c21b0c8.js:3182
enyo.js:3723 Uncaught TypeError: Cannot read property 'dispatchTarget' of undefined
    at Object.focus (enyo.js:3723)
    at d0df6bbab747b9de4462f1736c21b0c8.js:9678
Steps To ReproduceIn Livebuilds ERP:
 * Open Business partner window and set Credit Line Limit 100.00 to "Arturo Montoro" business partner.
 * In Pos Terminal Type window open "VBS POS Terminal Type" and check "Allow Pay on Credit" option.

Log in Web POS: https://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS-1 [^]

 * Set "Arturo Montoro" as Customer.
 * Add lines with amount greater than 100.00
 * Go to Payment tab and click on "Use Credit" button.
 * The javascript error is raised.
Proposed SolutionSee attached patch
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0037784 closed Retail An error raises when the limit is exceeded 
Attached Filesdiff issue37590.diff (1,182) 2018-01-05 12:31
https://issues.openbravo.com/file_download.php?file_id=11427&type=bug
png Selection_122.png (153,982) 2018-01-05 12:34
https://issues.openbravo.com/file_download.php?file_id=11428&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2018-01-05 12:29umartirenaNew Issue
2018-01-05 12:29umartirenaAssigned To => Retail
2018-01-05 12:29umartirenaOBNetwork customer => No
2018-01-05 12:29umartirenaTriggers an Emergency Pack => No
2018-01-05 12:29umartirenaOBNetwork customerNo => Yes
2018-01-05 12:30umartirenaProposed Solution updated
2018-01-05 12:31umartirenaFile Added: issue37590.diff
2018-01-05 12:34umartirenaFile Added: Selection_122.png
2018-01-15 11:51jorge-garciaStatusnew => scheduled
2018-01-15 11:51jorge-garciaAssigned ToRetail => jorge-garcia
2018-01-15 17:42hgbotCheckin
2018-01-15 17:42hgbotNote Added: 0101710
2018-01-15 17:42hgbotStatusscheduled => resolved
2018-01-15 17:42hgbotResolutionopen => fixed
2018-01-15 17:42hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9761635384fc2c5766e8364bd04eebd85c5abde6 [^]
2018-01-23 16:22migueldejuanaReview Assigned To => migueldejuana
2018-01-23 16:22migueldejuanaNote Added: 0101916
2018-01-23 16:22migueldejuanaStatusresolved => closed
2018-01-23 16:22migueldejuanaFixed in Version => RR18Q2
2018-02-02 16:08hgbotCheckin
2018-02-02 16:08hgbotNote Added: 0102156
2018-02-05 11:14marvintmRelationship addedhas duplicate 0037784

Notes
(0101710)
hgbot   
2018-01-15 17:42   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9761635384fc2c5766e8364bd04eebd85c5abde6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Jan 15 11:42:16 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9761635384fc2c5766e8364bd04eebd85c5abde6 [^]

Fixed issue 37590: Use Credit button raises a Javascript error if Credit
Limit is exceeded

Changed popup defintion to be a ModalAction instead of a ModalInfo.

Implement required logic for confirmation button.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalcreditsales.js
---
(0101916)
migueldejuana   
2018-01-23 16:22   
Tested and reviewed
(0102156)
hgbot   
2018-02-02 16:08   
Repository: tools/automation/pi-mobile
Changeset: 6bfaa49498d79ad8da63f117ed2bcbd4e73d4109
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Jan 24 13:47:48 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6bfaa49498d79ad8da63f117ed2bcbd4e73d4109 [^]

Verifies issue 37590: Added automated test 'I37590_VerifyJSErrorOnCreditPayment'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I37590_VerifyJSErrorOnCreditPayment.java
---