Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037585
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2018-01-04 16:562018-02-07 16:47
ReporterSandrahuguetView Statuspublic 
Assigned ToSandrahuguet 
PrioritynormalResolutionfixedFixed in VersionRR18Q2
StatusclosedFix in branchFixed in SCM revisione6f6ab0f0d31
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version7.x
OS VersionOpenbravo Appliance 14.04Database version9.3.xAnt version1.9.x
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037585: Performance problem in BPLocation query during the incremental refresh

DescriptionPerformance problem in BPLocation query during the incremental refresh

In environment with the following data:
116337 business partner
116828 bp location
117940 location

the query takes around 2.2s
Steps To ReproduceLog in ERP
 -Go to posterminal type window and select "VBS POS Terminal Type"
 -Set Time to incrementally refresh masterdata to 1
Log in the WebPOS using VBS-1
 -wait until the incremental refresh will be launched
TagsPerformance
Attached Filesdiff file icon BPLocation_2.diff [^] (2,729 bytes) 2018-01-08 10:15 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0037869 closedSandrahuguet Performance improvements in BPLocation query 

-  Notes
(0101613)
Sandrahuguet (developer)
2018-01-08 10:24
edited on: 2018-01-08 13:26

Attached a proposed solution.

Pending to fix LoadedCustomer model, a join with BusinessParner should be added in order to use same properties that BPLocation model.

(0101623)
hgbot (developer)
2018-01-08 17:22

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e6f6ab0f0d31ba2c93aa753cf1e99ecfc99d19ca
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Jan 08 13:32:54 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e6f6ab0f0d31ba2c93aa753cf1e99ecfc99d19ca [^]

Fixed bug 37585 delete unnecessary join and exists in BPLocation

Delete unnecessary join created by properties and exists in BPLocation
query in order to improve the performance

Added join with BusinessParner in LoadedCustomer in order to use
same properties that BPLocation model.

---
M src/org/openbravo/retail/posterminal/master/BPLocation.java
M src/org/openbravo/retail/posterminal/master/BPLocationProperties.java
M src/org/openbravo/retail/posterminal/master/LoadedCustomer.java
---
(0102258)
Sandrahuguet (developer)
2018-02-07 16:47
edited on: 2018-02-07 17:01

In environment with the following data:
116337 business partner
116828 bp location
117940 location

after fix query takes around 800ms


- Issue History
Date Modified Username Field Change
2018-01-04 16:56 Sandrahuguet New Issue
2018-01-04 16:56 Sandrahuguet Assigned To => Retail
2018-01-04 16:56 Sandrahuguet Triggers an Emergency Pack => No
2018-01-04 16:56 Sandrahuguet Tag Attached: Performance
2018-01-04 17:12 maite Resolution time => 1485298800
2018-01-04 17:13 maite Issue Monitored: networkb
2018-01-04 17:59 Sandrahuguet File Added: 37585.diff
2018-01-04 17:59 Sandrahuguet File Deleted: 37585.diff
2018-01-04 18:01 Sandrahuguet File Added: 37585.diff
2018-01-04 18:10 Sandrahuguet Note Added: 0101565
2018-01-08 08:58 marvintm Resolution time 1485298800 => 1516834800
2018-01-08 10:14 Sandrahuguet File Deleted: 37585.diff
2018-01-08 10:15 Sandrahuguet Note Deleted: 0101565
2018-01-08 10:15 Sandrahuguet File Added: BPLocation_2.diff
2018-01-08 10:24 Sandrahuguet Note Added: 0101613
2018-01-08 13:19 Sandrahuguet Assigned To Retail => Sandrahuguet
2018-01-08 13:26 Sandrahuguet Note Edited: 0101613 View Revisions
2018-01-08 17:21 Sandrahuguet Review Assigned To => marvintm
2018-01-08 17:22 hgbot Checkin
2018-01-08 17:22 hgbot Note Added: 0101623
2018-01-08 17:22 hgbot Status new => resolved
2018-01-08 17:22 hgbot Resolution open => fixed
2018-01-08 17:22 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e6f6ab0f0d31ba2c93aa753cf1e99ecfc99d19ca [^]
2018-01-09 13:57 marvintm Status resolved => closed
2018-01-09 13:57 marvintm Fixed in Version => RR18Q2
2018-02-07 16:47 Sandrahuguet Note Added: 0102258
2018-02-07 16:47 Sandrahuguet Note Edited: 0102258 View Revisions
2018-02-07 17:01 Sandrahuguet Note Edited: 0102258 View Revisions
2018-03-12 13:44 Sandrahuguet Relationship added related to 0037869


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker