Openbravo Issue Tracking System - Retail Modules
View Issue Details
0037585Retail ModulesWeb POSpublic2018-01-04 16:562018-02-07 16:47
Sandrahuguet 
Sandrahuguet 
normalmajorhave not tried
closedfixed 
30Openbravo Appliance 14.04
 
RR18Q2 
marvintm
No
0037585: Performance problem in BPLocation query during the incremental refresh
Performance problem in BPLocation query during the incremental refresh

In environment with the following data:
116337 business partner
116828 bp location
117940 location

the query takes around 2.2s
Log in ERP
 -Go to posterminal type window and select "VBS POS Terminal Type"
 -Set Time to incrementally refresh masterdata to 1
Log in the WebPOS using VBS-1
 -wait until the incremental refresh will be launched
Performance
related to defect 0037869 closed Sandrahuguet Performance improvements in BPLocation query 
diff BPLocation_2.diff (2,729) 2018-01-08 10:15
https://issues.openbravo.com/file_download.php?file_id=11433&type=bug
Issue History
2018-01-04 16:56SandrahuguetNew Issue
2018-01-04 16:56SandrahuguetAssigned To => Retail
2018-01-04 16:56SandrahuguetTriggers an Emergency Pack => No
2018-01-04 16:56SandrahuguetTag Attached: Performance
2018-01-04 17:12maiteResolution time => 1485298800
2018-01-04 17:13maiteIssue Monitored: networkb
2018-01-04 17:59SandrahuguetFile Added: 37585.diff
2018-01-04 17:59SandrahuguetFile Deleted: 37585.diff
2018-01-04 18:01SandrahuguetFile Added: 37585.diff
2018-01-04 18:10SandrahuguetNote Added: 0101565
2018-01-08 08:58marvintmResolution time1485298800 => 1516834800
2018-01-08 10:14SandrahuguetFile Deleted: 37585.diff
2018-01-08 10:15SandrahuguetNote Deleted: 0101565
2018-01-08 10:15SandrahuguetFile Added: BPLocation_2.diff
2018-01-08 10:24SandrahuguetNote Added: 0101613
2018-01-08 13:19SandrahuguetAssigned ToRetail => Sandrahuguet
2018-01-08 13:26SandrahuguetNote Edited: 0101613bug_revision_view_page.php?bugnote_id=0101613#r16514
2018-01-08 17:21SandrahuguetReview Assigned To => marvintm
2018-01-08 17:22hgbotCheckin
2018-01-08 17:22hgbotNote Added: 0101623
2018-01-08 17:22hgbotStatusnew => resolved
2018-01-08 17:22hgbotResolutionopen => fixed
2018-01-08 17:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e6f6ab0f0d31ba2c93aa753cf1e99ecfc99d19ca [^]
2018-01-09 13:57marvintmStatusresolved => closed
2018-01-09 13:57marvintmFixed in Version => RR18Q2
2018-02-07 16:47SandrahuguetNote Added: 0102258
2018-02-07 16:47SandrahuguetNote Edited: 0102258bug_revision_view_page.php?bugnote_id=0102258#r16647
2018-02-07 17:01SandrahuguetNote Edited: 0102258bug_revision_view_page.php?bugnote_id=0102258#r16648
2018-03-12 13:44SandrahuguetRelationship addedrelated to 0037869

Notes
(0101613)
Sandrahuguet   
2018-01-08 10:24   
(edited on: 2018-01-08 13:26)
Attached a proposed solution.

Pending to fix LoadedCustomer model, a join with BusinessParner should be added in order to use same properties that BPLocation model.

(0101623)
hgbot   
2018-01-08 17:22   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e6f6ab0f0d31ba2c93aa753cf1e99ecfc99d19ca
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Mon Jan 08 13:32:54 2018 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e6f6ab0f0d31ba2c93aa753cf1e99ecfc99d19ca [^]

Fixed bug 37585 delete unnecessary join and exists in BPLocation

Delete unnecessary join created by properties and exists in BPLocation
query in order to improve the performance

Added join with BusinessParner in LoadedCustomer in order to use
same properties that BPLocation model.

---
M src/org/openbravo/retail/posterminal/master/BPLocation.java
M src/org/openbravo/retail/posterminal/master/BPLocationProperties.java
M src/org/openbravo/retail/posterminal/master/LoadedCustomer.java
---
(0102258)
Sandrahuguet   
2018-02-07 16:47   
(edited on: 2018-02-07 17:01)
In environment with the following data:
116337 business partner
116828 bp location
117940 location

after fix query takes around 800ms