0037525: Duplicate document numbers if a POS Terminal "Order Document No Prefix*" contains "/" character

# HG changeset patch
# User Ranjith S R <ranjith@qualiantech.com>
# Date 1515047671 -19800
#      Thu Jan 04 12:04:31 2018 +0530
# Node ID f5f6ac767f4b92cfbdf4dc03906830e6896c85e7
# Parent  d32e076f211de5eb9ff1fca4bb1ce42bb7e0f023
Related to issue 37525 : Refactor get lastDocumentNumber in POSUtils

* Replace documentNumber with prefix value of lastINdex of "slash"

diff -r d32e076f211d -r f5f6ac767f4b src/org/openbravo/retail/posterminal/POSUtils.java
--- a/src/org/openbravo/retail/posterminal/POSUtils.java	Wed Jan 03 11:48:18 2018 +0000
+++ b/src/org/openbravo/retail/posterminal/POSUtils.java	Thu Jan 04 12:04:31 2018 +0530
@@ -387,25 +387,18 @@
         JSONObject jsonError = new JSONObject(error.getJsoninfo());
         if (jsonError.has("documentNo") && jsonError.has("isQuotation")
             && !jsonError.getBoolean("isQuotation")) {
-          String documentNo = jsonError.getString("documentNo");
+          String number = "0", documentNo = jsonError.getString("documentNo");
           if (documentNo.indexOf("/") > -1) {
-            String number = documentNo.substring(documentNo.indexOf("/") + 1);
-            if (number.indexOf("-") > -1) {
-              number = number.substring(0, number.indexOf("-"));
-            }
-            int errorNumber = new Long(number).intValue();
-            if (errorNumber > maxDocNo) {
-              maxDocNo = errorNumber;
-            }
+            number = documentNo.substring(documentNo.lastIndexOf("/") + 1);
           } else if (jsonError.has("documentnoPrefix")) {
-            String number = documentNo.replace(jsonError.getString("documentnoPrefix"), "");
-            if (number.indexOf("-") > -1) {
-              number = number.substring(0, number.indexOf("-"));
-            }
-            int errorNumber = new Long(number).intValue();
-            if (errorNumber > maxDocNo) {
-              maxDocNo = errorNumber;
-            }
+            number = documentNo.replace(jsonError.getString("documentnoPrefix"), "");
+          }
+          if (number.indexOf("-") > -1) {
+            number = number.substring(0, number.indexOf("-"));
+          }
+          int errorNumber = new Long(number).intValue();
+          if (errorNumber > maxDocNo) {
+            maxDocNo = errorNumber;
           }
         }
       } catch (Exception e) {
@@ -481,25 +474,18 @@
         JSONObject jsonError = new JSONObject(error.getJsoninfo());
         if (jsonError.has("documentNo") && jsonError.has("isQuotation")
             && jsonError.getBoolean("isQuotation")) {
-          String documentNo = jsonError.getString("documentNo");
+          String number = "0", documentNo = jsonError.getString("documentNo");
           if (documentNo.indexOf("/") > -1) {
-            String number = documentNo.substring(documentNo.indexOf("/") + 1);
-            if (number.indexOf("-") > -1) {
-              number = number.substring(0, number.indexOf("-"));
-            }
-            int errorNumber = new Long(number).intValue();
-            if (errorNumber > maxDocNo) {
-              maxDocNo = errorNumber;
-            }
+            number = documentNo.substring(documentNo.lastIndexOf("/") + 1);
           } else if (jsonError.has("quotationnoPrefix")) {
-            String number = documentNo.replace(jsonError.getString("quotationnoPrefix"), "");
-            if (number.indexOf("-") > -1) {
-              number = number.substring(0, number.indexOf("-"));
-            }
-            int errorNumber = new Long(number).intValue();
-            if (errorNumber > maxDocNo) {
-              maxDocNo = errorNumber;
-            }
+            number = documentNo.replace(jsonError.getString("quotationnoPrefix"), "");
+          }
+          if (number.indexOf("-") > -1) {
+            number = number.substring(0, number.indexOf("-"));
+          }
+          int errorNumber = new Long(number).intValue();
+          if (errorNumber > maxDocNo) {
+            maxDocNo = errorNumber;
           }
         }
       } catch (Exception e) {
@@ -572,25 +558,18 @@
       try {
         JSONObject jsonError = new JSONObject(error.getJsoninfo());
         if (jsonError.has("documentNo") && (jsonError.optLong("returnnoSuffix", -1L) > -1L)) {
-          String documentNo = jsonError.getString("documentNo");
+          String number = "0", documentNo = jsonError.getString("documentNo");
           if (documentNo.indexOf("/") > -1) {
-            String number = documentNo.substring(documentNo.indexOf("/") + 1);
-            if (number.indexOf("-") > -1) {
-              number = number.substring(0, number.indexOf("-"));
-            }
-            int errorNumber = new Long(number).intValue();
-            if (errorNumber > maxDocNo) {
-              maxDocNo = errorNumber;
-            }
+            number = documentNo.substring(documentNo.lastIndexOf("/") + 1);
           } else if (jsonError.has("returnnoPrefix")) {
-            String number = documentNo.replace(jsonError.getString("returnnoPrefix"), "");
-            if (number.indexOf("-") > -1) {
-              number = number.substring(0, number.indexOf("-"));
-            }
-            int errorNumber = new Long(number).intValue();
-            if (errorNumber > maxDocNo) {
-              maxDocNo = errorNumber;
-            }
+            number = documentNo.replace(jsonError.getString("returnnoPrefix"), "");
+          }
+          if (number.indexOf("-") > -1) {
+            number = number.substring(0, number.indexOf("-"));
+          }
+          int errorNumber = new Long(number).intValue();
+          if (errorNumber > maxDocNo) {
+            maxDocNo = errorNumber;
           }
         }
       } catch (Exception e) {