Openbravo Issue Tracking System - Retail Modules
View Issue Details
0037525Retail ModulesWeb POSpublic2017-12-20 15:162018-01-11 18:01
umartirena 
ranjith_qualiantech_com 
normalmajorhave not tried
closedfixed 
5
 
RR18Q2 
marvintm
OBPS
49726
No
0037525: Duplicate document numbers if a POS Terminal "Order Document No Prefix*" contains "/" character
If POS Terminal "Order Document No Prefix*" contains "/" character it can happen to end into a situation in were Sales Orders with duplicate document numbers can be created.

* Login into http://livebuilds.openbravo.com/retail_pi_pgsql/ [^]
* Open "Document Type" window.
* Search Document type with "VBS POS Order" name.
* Empty the value in "Document Type for Shipment" field. Save it.
* Open "POS Terminal" window.
* Search POS Terminal with "VBS1001" Search Key.
* Set in "Order Document No Prefix" field "VBS1001/TEST" value. Save it.
* Logout
* Login into http://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS1001 [^]
* Add a product.
* Go to Payment window, pay and complete the ticket.
* Logout
* Login into http://livebuilds.openbravo.com/retail_pi_pgsql/ [^]
* Open "Errors while importing window". Check that an error record has been created.
* Open "Document Type" window.
* Search Document type with "VBS POS Order" name.
* Set "VBS MM Shipment" in "Document Type for Shipment" field. Save it.
* Logout.
* Open a different profile in Google Chrome, or open google chrome in incognito mode, or delete cache memory.
* Login into http://livebuilds.openbravo.com/retail_pi_pgsql/web/org.openbravo.retail.posterminal/?terminal=VBS1001 [^]
* Add a product.
* Go to Payment window, pay and complete the ticket.
* Logout
* Login into http://livebuilds.openbravo.com/retail_pi_pgsql/ [^]
* Open Sales Order window. Check the document number of the created Sales Order: "VBS1001/TEST/xxxxx"
* Open "Errors while importing window". Select the previously created error record. Click on Save data. Check that the record is properly processed.
* Open Sales Order window. Check that there are 2 records with same document number: "VBS1001/TEST/xxxxx".

In the mean time, the following error has been raised in openbravo log:

java.lang.NumberFormatException: For input string: "TEST/0000003"
    at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
    at java.lang.Long.parseLong(Long.java:441)
    at java.lang.Long.<init>(Long.java:702)
    at org.openbravo.retail.posterminal.POSUtils.getLastDocumentNumberForPOS(POSUtils.java:396)
    at org.openbravo.retail.posterminal.term.Terminal.exec(Terminal.java:90)
    at org.openbravo.mobile.core.process.JSONProcessSimple.exec(JSONProcessSimple.java:61)
    at org.openbravo.mobile.core.process.SecuredJSONProcess.secureExec(SecuredJSONProcess.java:56)
    at org.openbravo.mobile.core.process.MobileServiceProcessor.execProcess(MobileServiceProcessor.java:97)
    at org.openbravo.mobile.core.process.MobileServiceProcessor.execServiceName(MobileServiceProcessor.java:71)
    at org.openbravo.mobile.core.process.MobileService.doGetOrPost(MobileService.java:134)
    at org.openbravo.mobile.core.process.MobileService.doGet(MobileService.java:62)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:620)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:221)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:462)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87)
    at org.openbravo.mobile.core.process.WebServiceAuthenticatedServlet.service(WebServiceAuthenticatedServlet.java:62)
    at org.openbravo.mobile.core.process.MobileService.service(MobileService.java:99)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:501)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:170)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408)
    at org.apache.coyote.ajp.AjpProcessor.process(AjpProcessor.java:193)
    at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:607)
    at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:313)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1152)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:622)
    at java.lang.Thread.run(Thread.java:748)
 
No tags attached.
patch issue 37525 posterminal v2.patch (5,709) 2018-01-04 07:36
https://issues.openbravo.com/file_download.php?file_id=11417&type=bug
Issue History
2017-12-20 15:16umartirenaNew Issue
2017-12-20 15:16umartirenaAssigned To => Retail
2017-12-20 15:16umartirenaOBNetwork customer => No
2017-12-20 15:16umartirenaTriggers an Emergency Pack => No
2017-12-20 15:33malsasuaOBNetwork customerNo => Yes
2017-12-20 15:33malsasuaSupport ticket => 49726
2017-12-20 15:33malsasuaResolution time => 1515625200
2017-12-20 16:13malsasuaIssue Monitored: malsasua
2017-12-28 08:05ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2018-01-03 10:29ranjith_qualiantech_comStatusnew => scheduled
2018-01-03 10:29ranjith_qualiantech_comFile Added: issue 37525 posterminal.patch
2018-01-04 07:18ranjith_qualiantech_comFile Deleted: issue 37525 posterminal.patch
2018-01-04 07:36ranjith_qualiantech_comFile Added: issue 37525 posterminal v2.patch
2018-01-05 12:47hgbotCheckin
2018-01-05 12:47hgbotNote Added: 0101590
2018-01-05 12:47hgbotStatusscheduled => resolved
2018-01-05 12:47hgbotResolutionopen => fixed
2018-01-05 12:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1b163aa256178bd6d1ad1cd814ad5aca8d6d40f3 [^]
2018-01-11 18:01marvintmReview Assigned To => marvintm
2018-01-11 18:01marvintmStatusresolved => closed
2018-01-11 18:01marvintmFixed in Version => RR18Q2

Notes
(0101590)
hgbot   
2018-01-05 12:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1b163aa256178bd6d1ad1cd814ad5aca8d6d40f3
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jan 05 17:17:24 2018 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1b163aa256178bd6d1ad1cd814ad5aca8d6d40f3 [^]

Fixed issue 37525 : Refactor get lastDocumentNumber in POSUtils

* Replace documentNumber with prefix value by lastIndex of "slash"

---
M src/org/openbravo/retail/posterminal/POSUtils.java
---