Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0037490 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] StoreServer | major | have not tried | 2017-12-15 10:45 | 2017-12-31 13:47 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | cb358631eb44 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | mtaal | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0037490: API change in mobile.core breaks login | |||||||
| Description | This changeset [1] moves the definition of the HandleResponseCallbacks function from OB.RR to OB.RR.RequestRouter. This breaks the login because these two calls fail [2], [3]. [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b0cc9e85b88c#l16.7 [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/web/org.openbravo.retail.storeserver.synchronization/js/incompatibleVersionHandler.js#l24 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/web/org.openbravo.retail.storeserver.synchronization/js/serverReloadHandler.js#l24 [^] [4] http://ci.openbravo.com/view/storeserver/job/ret-ms-store1-pgsql/1051/ [^] This issue has been caught by the store server CI tests [4] | |||||||
| Steps To Reproduce | Update the org.openbravo.mobile.core to the latest version. Login in the POS in a server that includes the org.openbravo.retail.storeserver.synchronization.module. The login will fail and the following error will be shown in the console: TypeError: Cannot read property 'push' of undefined | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0101056) hgbot (developer) 2017-12-15 11:31 |
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization Changeset: 621c9148d715b5f224aee995c3e9e2fc86d3adfd Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Fri Dec 15 11:30:58 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/621c9148d715b5f224aee995c3e9e2fc86d3adfd [^] Fixes issue 37490: Adapts code to placement change of HandleResponseCallbacks Instead of just replacing OB.RR.HandleResponseCallbacks with OB.RR.RequestRouter.HandleResponseCallbacks, now both locations are checked, to ensure the current code will work with versions of mobile.core that have and that don't have the API change. --- M web/org.openbravo.retail.storeserver.synchronization/js/incompatibleVersionHandler.js M web/org.openbravo.retail.storeserver.synchronization/js/serverReloadHandler.js --- |
|
(0101058) AugustoMauch (manager) 2017-12-15 12:59 |
Fix is not proper |
|
(0101059) hgbot (developer) 2017-12-15 13:02 |
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization Changeset: cb358631eb442351e6302f7f6111a215a9e131a4 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Fri Dec 15 13:02:42 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/cb358631eb442351e6302f7f6111a215a9e131a4 [^] Fixes issue 37490: fixes typo --- M web/org.openbravo.retail.storeserver.synchronization/js/incompatibleVersionHandler.js M web/org.openbravo.retail.storeserver.synchronization/js/serverReloadHandler.js --- |
|
(0101299) mtaal (manager) 2017-12-31 13:47 |
Reviewed and tested |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-12-15 10:45 | AugustoMauch | New Issue | |
| 2017-12-15 10:45 | AugustoMauch | Assigned To | => AugustoMauch |
| 2017-12-15 10:45 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2017-12-15 11:31 | hgbot | Checkin | |
| 2017-12-15 11:31 | hgbot | Note Added: 0101056 | |
| 2017-12-15 11:31 | hgbot | Status | new => resolved |
| 2017-12-15 11:31 | hgbot | Resolution | open => fixed |
| 2017-12-15 11:31 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/621c9148d715b5f224aee995c3e9e2fc86d3adfd [^] |
| 2017-12-15 11:31 | AugustoMauch | Relationship added | caused by 0037271 |
| 2017-12-15 11:32 | AugustoMauch | Review Assigned To | => mtaal |
| 2017-12-15 12:59 | AugustoMauch | Note Added: 0101058 | |
| 2017-12-15 12:59 | AugustoMauch | Status | resolved => new |
| 2017-12-15 12:59 | AugustoMauch | Resolution | fixed => open |
| 2017-12-15 13:02 | hgbot | Checkin | |
| 2017-12-15 13:02 | hgbot | Note Added: 0101059 | |
| 2017-12-15 13:02 | hgbot | Status | new => resolved |
| 2017-12-15 13:02 | hgbot | Resolution | open => fixed |
| 2017-12-15 13:02 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/621c9148d715b5f224aee995c3e9e2fc86d3adfd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/cb358631eb442351e6302f7f6111a215a9e131a4 [^] |
| 2017-12-31 13:47 | mtaal | Note Added: 0101299 | |
| 2017-12-31 13:47 | mtaal | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |