Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037490Retail ModulesStoreServerpublic2017-12-15 10:452017-12-31 13:47
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037490: API change in mobile.core breaks login
DescriptionThis changeset [1] moves the definition of the HandleResponseCallbacks function from OB.RR to OB.RR.RequestRouter.

This breaks the login because these two calls fail [2], [3].

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b0cc9e85b88c#l16.7 [^]
[2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/web/org.openbravo.retail.storeserver.synchronization/js/incompatibleVersionHandler.js#l24 [^]
[3] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/tip/web/org.openbravo.retail.storeserver.synchronization/js/serverReloadHandler.js#l24 [^]

[4] http://ci.openbravo.com/view/storeserver/job/ret-ms-store1-pgsql/1051/ [^]
This issue has been caught by the store server CI tests [4]
Steps To ReproduceUpdate the org.openbravo.mobile.core to the latest version.
Login in the POS in a server that includes the org.openbravo.retail.storeserver.synchronization.module.

The login will fail and the following error will be shown in the console:

TypeError: Cannot read property 'push' of undefined
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by design defect 0037271 new Retail Web POS offline behaviour should be improved 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2017-12-15 10:45AugustoMauchNew Issue
2017-12-15 10:45AugustoMauchAssigned To => AugustoMauch
2017-12-15 10:45AugustoMauchTriggers an Emergency Pack => No
2017-12-15 11:31hgbotCheckin
2017-12-15 11:31hgbotNote Added: 0101056
2017-12-15 11:31hgbotStatusnew => resolved
2017-12-15 11:31hgbotResolutionopen => fixed
2017-12-15 11:31hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/621c9148d715b5f224aee995c3e9e2fc86d3adfd [^]
2017-12-15 11:31AugustoMauchRelationship addedcaused by 0037271
2017-12-15 11:32AugustoMauchReview Assigned To => mtaal
2017-12-15 12:59AugustoMauchNote Added: 0101058
2017-12-15 12:59AugustoMauchStatusresolved => new
2017-12-15 12:59AugustoMauchResolutionfixed => open
2017-12-15 13:02hgbotCheckin
2017-12-15 13:02hgbotNote Added: 0101059
2017-12-15 13:02hgbotStatusnew => resolved
2017-12-15 13:02hgbotResolutionopen => fixed
2017-12-15 13:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/621c9148d715b5f224aee995c3e9e2fc86d3adfd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/cb358631eb442351e6302f7f6111a215a9e131a4 [^]
2017-12-31 13:47mtaalNote Added: 0101299
2017-12-31 13:47mtaalStatusresolved => closed

Notes
(0101056)
hgbot   
2017-12-15 11:31   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 621c9148d715b5f224aee995c3e9e2fc86d3adfd
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Dec 15 11:30:58 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/621c9148d715b5f224aee995c3e9e2fc86d3adfd [^]

Fixes issue 37490: Adapts code to placement change of HandleResponseCallbacks

Instead of just replacing OB.RR.HandleResponseCallbacks with OB.RR.RequestRouter.HandleResponseCallbacks, now both locations are checked, to ensure the current code will work with versions of mobile.core that have and that don't have the API change.

---
M web/org.openbravo.retail.storeserver.synchronization/js/incompatibleVersionHandler.js
M web/org.openbravo.retail.storeserver.synchronization/js/serverReloadHandler.js
---
(0101058)
AugustoMauch   
2017-12-15 12:59   
Fix is not proper
(0101059)
hgbot   
2017-12-15 13:02   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: cb358631eb442351e6302f7f6111a215a9e131a4
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Dec 15 13:02:42 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/cb358631eb442351e6302f7f6111a215a9e131a4 [^]

Fixes issue 37490: fixes typo

---
M web/org.openbravo.retail.storeserver.synchronization/js/incompatibleVersionHandler.js
M web/org.openbravo.retail.storeserver.synchronization/js/serverReloadHandler.js
---
(0101299)
mtaal   
2017-12-31 13:47   
Reviewed and tested