Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0037380
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] StoreServermajorhave not tried2017-11-24 07:162017-11-29 15:57
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision54883ed296c8
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037380: Only do transition to online when it is possible

DescriptionWhen a store server is offline it will automatically transition to online when the connection to the CS is restored.

However if there are blocking issues (like related to replication) then the SS will go offline again.

During this transition to online and back the system can not be used. As the system will retry transitioning this makes the system much less available.

Related docs:
http://wiki.openbravo.com/wiki/Store_Server_Online_and_Offline_Concepts [^]

http://wiki.openbravo.com/wiki/Store_and_Multi_Server_Preferences#Behavioral_Preferences [^]
(see transition to online wait time)
Steps To ReproduceInstall multi-server, set low transition to online failed wait time)
Cause a replication error from store to central
Put down CS, SS goes offline
Restart CS
SS will retry transition to online continuously
Proposed SolutionDo a pre-check in transition to online code if transition to online is possible
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
causes defect 0037425 closedmtaal Repair formatting error and typos in submitted code 

-  Notes
(0100716)
mtaal (manager)
2017-11-26 13:33

 Easiest way to check the code is implement the transition to online handler and check server offline handlers as below.

Implement the handlers as shown below
Run multi-server
Stop CS so the SS goes offline
Restart CS, send a force transition to online
Check that the transition to online does not start even
Change the test handlers below to allow transition, send transition to online
Now it should go online

  public static class TESTForOffline extends CheckServerOfflineHandler {
    @Override
    public boolean isServerOffline() {
      return true;
    }
  }

  public static class TESTOnlineTransitionHandler extends
      MobileServerTransitionToOnlineHandler {

    @Override
    public void processTransactions() {
    }

    @Override
    public String getOfflineLog() {
      return "Checking offline TEST";
    }

    @Override
    public boolean isReadyToGoOnline() {
      return false;
    }
  }
}
(0100718)
hgbot (developer)
2017-11-26 23:10

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 54883ed296c8fc6b984af3f81166896ebd346643
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Nov 26 23:10:17 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/54883ed296c8fc6b984af3f81166896ebd346643 [^]

Fixes issue 37380: Only do transition to online when it is possible
Do transition to online in two steps: only do it when possible, adding a new method to the api for checking if transition to online is possible, also call the check servers offline before actually going to transition

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerTransitionToOnlineHandler.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerUtils.java
---
(0100813)
migueldejuana (developer)
2017-11-29 15:57

 Reviewed

- Issue History
Date Modified Username Field Change
2017-11-24 07:16 mtaal New Issue
2017-11-24 07:16 mtaal Assigned To => mtaal
2017-11-24 07:16 mtaal Triggers an Emergency Pack => No
2017-11-26 13:33 mtaal Note Added: 0100716
2017-11-26 23:07 mtaal Review Assigned To => AugustoMauch
2017-11-26 23:10 hgbot Checkin
2017-11-26 23:10 hgbot Note Added: 0100718
2017-11-26 23:10 hgbot Status new => resolved
2017-11-26 23:10 hgbot Resolution open => fixed
2017-11-26 23:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/54883ed296c8fc6b984af3f81166896ebd346643 [^]
2017-11-27 10:18 mtaal Review Assigned To AugustoMauch => migueldejuana
2017-11-29 15:57 migueldejuana Note Added: 0100813
2017-11-29 15:57 migueldejuana Status resolved => closed
2017-11-30 11:27 mtaal Relationship added causes 0037425

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker