0037348: After execute the hook OBPOS_PreShowPane web POS is not listening tabName changes done in the hook implementation

Description

After execute the hook OBPOS_PreShowPane web POS is not listening tabName changes done in the hook implementation

Steps To Reproduce

create an implementation for hook OBPOS_PreShowPane and try to change the tab which is being shown.

It is not working

example:

enyo.kind({
  name: 'OB.OBPOSPointOfSale.UI.TabBrowseGal',
  kind: 'OB.UI.TabPane',
  components: [{
    kind: 'OB.UI.ProductBrowserGAL',
    name: 'catalogTabContentGal'
  }]
});

enyo.kind({
  name: 'OB.UI.ProductBrowserGAL',
  useCharacteristics: true,
  style: 'background-color: #ffffff;color: black;height: 612px; margin: 5px;',
  components: [{
    kind: 'OB.UI.FlexComponent',
    flexDirection: 'column',
    flexContent: [{content: 'Categories'}, {content: 'Products'}]
  }],
  executeOnShow: function () {
    console.log('executeOnShow ProductBrowserGAL');
  }
});

OB.OBPOSPointOfSale.UI.RightToolbarPane.prototype.kindComponents.push({
  kind: 'OB.OBPOSPointOfSale.UI.TabBrowseGal',
  name: 'catalogGal'
});

OB.UTIL.HookManager.registerHook('OBPOS_PreShowPane', function (args, callbacks) {
  //TODO Here the correct condition
  if (args.tabName === 'catalog') {
    args.tabName = 'catalogGal';
  }
  OB.UTIL.HookManager.callbackExecutor(args, callbacks);
});

Proposed Solution

Read the object returned by hook

Tags

No tags attached.

Attached Files

issue_37348.diff [^] (851 bytes) 2017-11-22 07:33 [Show Content] [Hide Content]

diff -r e3123e163d62 web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js	Mon Nov 20 18:04:06 2017 +0100
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js	Wed Nov 22 10:33:05 2017 +0400
@@ -585,12 +585,12 @@
           i;
       for (i = 0; i < paneArray.length; i++) {
         paneArray[i].removeClass('active');
-        if (paneArray[i].name === tabName) {
+        if (paneArray[i].name === args.tabName) {
           if (paneArray[i].executeOnShow) {
             paneArray[i].executeOnShow(options);
           }
           paneArray[i].addClass('active');
-          OB.MobileApp.model.set('lastPaneShown', tabName);
+          OB.MobileApp.model.set('lastPaneShown', args.tabName);
         }
       }
     });

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0100674) hgbot (developer) 2017-11-22 20:32	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 0c8e957224fa3a06be9e66d4776ea314a4805748 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Wed Nov 22 10:37:19 2017 +0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0c8e957224fa3a06be9e66d4776ea314a4805748 [^] Fixed issue 37348: Returned data from hook OBPOS_PreShowPane is readed --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js ---

(0100924) migueldejuana (developer) 2017-12-04 17:16	Reviewed

Issue History
Date Modified	Username	Field	Change
2017-11-22 07:32	guilleaer	New Issue
2017-11-22 07:32	guilleaer	Assigned To	=> guilleaer
2017-11-22 07:32	guilleaer	Triggers an Emergency Pack	=> No
2017-11-22 07:33	guilleaer	File Added: issue_37348.diff
2017-11-22 07:55	guilleaer	Status	new => scheduled
2017-11-22 20:32	hgbot	Checkin
2017-11-22 20:32	hgbot	Note Added: 0100674
2017-11-22 20:32	hgbot	Status	scheduled => resolved
2017-11-22 20:32	hgbot	Resolution	open => fixed
2017-11-22 20:32	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0c8e957224fa3a06be9e66d4776ea314a4805748 [^]
2017-12-04 17:16	migueldejuana	Review Assigned To	=> migueldejuana
2017-12-04 17:16	migueldejuana	Note Added: 0100924
2017-12-04 17:16	migueldejuana	Status	resolved => closed
2017-12-04 17:16	migueldejuana	Fixed in Version	=> RR18Q1