Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0037348Retail ModulesWeb POSpublic2017-11-22 07:322017-12-04 17:16
Reporterguilleaer 
Assigned Toguilleaer 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q1Fixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0037348: After execute the hook OBPOS_PreShowPane web POS is not listening tabName changes done in the hook implementation
DescriptionAfter execute the hook OBPOS_PreShowPane web POS is not listening tabName changes done in the hook implementation
Steps To Reproducecreate an implementation for hook OBPOS_PreShowPane and try to change the tab which is being shown.

It is not working

example:

enyo.kind({
  name: 'OB.OBPOSPointOfSale.UI.TabBrowseGal',
  kind: 'OB.UI.TabPane',
  components: [{
    kind: 'OB.UI.ProductBrowserGAL',
    name: 'catalogTabContentGal'
  }]
});

enyo.kind({
  name: 'OB.UI.ProductBrowserGAL',
  useCharacteristics: true,
  style: 'background-color: #ffffff;color: black;height: 612px; margin: 5px;',
  components: [{
    kind: 'OB.UI.FlexComponent',
    flexDirection: 'column',
    flexContent: [{content: 'Categories'}, {content: 'Products'}]
  }],
  executeOnShow: function () {
    console.log('executeOnShow ProductBrowserGAL');
  }
});

OB.OBPOSPointOfSale.UI.RightToolbarPane.prototype.kindComponents.push({
  kind: 'OB.OBPOSPointOfSale.UI.TabBrowseGal',
  name: 'catalogGal'
});

OB.UTIL.HookManager.registerHook('OBPOS_PreShowPane', function (args, callbacks) {
  //TODO Here the correct condition
  if (args.tabName === 'catalog') {
    args.tabName = 'catalogGal';
  }
  OB.UTIL.HookManager.callbackExecutor(args, callbacks);
});
Proposed SolutionRead the object returned by hook
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff issue_37348.diff (851) 2017-11-22 07:33
https://issues.openbravo.com/file_download.php?file_id=11312&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-11-22 07:32guilleaerNew Issue
2017-11-22 07:32guilleaerAssigned To => guilleaer
2017-11-22 07:32guilleaerOBNetwork customer => No
2017-11-22 07:32guilleaerTriggers an Emergency Pack => No
2017-11-22 07:33guilleaerFile Added: issue_37348.diff
2017-11-22 07:55guilleaerStatusnew => scheduled
2017-11-22 20:32hgbotCheckin
2017-11-22 20:32hgbotNote Added: 0100674
2017-11-22 20:32hgbotStatusscheduled => resolved
2017-11-22 20:32hgbotResolutionopen => fixed
2017-11-22 20:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0c8e957224fa3a06be9e66d4776ea314a4805748 [^]
2017-12-04 17:16migueldejuanaReview Assigned To => migueldejuana
2017-12-04 17:16migueldejuanaNote Added: 0100924
2017-12-04 17:16migueldejuanaStatusresolved => closed
2017-12-04 17:16migueldejuanaFixed in Version => RR18Q1

Notes
(0100674)
hgbot   
2017-11-22 20:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0c8e957224fa3a06be9e66d4776ea314a4805748
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Wed Nov 22 10:37:19 2017 +0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0c8e957224fa3a06be9e66d4776ea314a4805748 [^]

Fixed issue 37348: Returned data from hook OBPOS_PreShowPane is readed

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/toolbar-right.js
---
(0100924)
migueldejuana   
2017-12-04 17:16   
Reviewed