Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0037290 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2017-11-14 14:12 | 2018-01-09 15:38 | |||
| Reporter | maite | View Status | public | |||||
| Assigned To | rqueralta | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | RR18Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 69419e71c5d1 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | OBPS | |||||||
| Support ticket | 49189 | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0037290: "Save" button blocked in Edit Customer window in case custom hook set args.passValidation=false | |||||||
| Description | Save button is not enabled again when a OBPOS_PreCustomerSave hook which leaves "args.passValidation" in FALSE status is executed | |||||||
| Steps To Reproduce | 1. Log in the terminal 2. Open Developers Tool and register following hook in the console: OB.UTIL.HookManager.registerHook('OBPOS_PreCustomerSave', function(args, callbacks) {args.passValidation=false; alert("1");OB.UTIL.HookManager.callbackExecutor(args, callbacks);}); 3. Click on customer and set Arturo Montoro 4. Click again on Arturo Montoro and run Edit option. Add any change and press SAVE button. Realize that button is not enabled | |||||||
| Proposed Solution | Solution proposed by the partner: - Edit sharedcomponents.js file to add following code in: line 388: } else { OB.UTIL.showError(args.error); + me.waterfall('onDisableButton', { + disabled: false + }); line 470 - args.windowComponent.waterfall('onDisableButton', { + me.waterfall('onDisableButton', { | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0100940) hgbot (developer) 2017-12-07 14:24 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 69419e71c5d133a328e13e0452f66e87fa02f512 Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu> Date: Wed Nov 15 13:37:39 2017 -0500 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69419e71c5d133a328e13e0452f66e87fa02f512 [^] Fixed issue 37290: "Save" button blocked in Edit Customer window in case custom hook set args.passValidation=false --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js --- |
|
(0101640) hgbot (developer) 2018-01-09 15:38 |
Repository: tools/automation/pi-mobile Changeset: e491e9740570ec1d38315b815cfbf9fb793dea7e Author: Alejandro <alekosmp86 <at> gmail.com> Date: Mon Jan 08 11:31:54 2018 -0500 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e491e9740570ec1d38315b815cfbf9fb793dea7e [^] Verifies issue 37290: "Save" button blocked in Edit Customer window in case custom hook set args.passValidation=false --- M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/I37290_VerifySaveInEditCustomerWithCustomHook.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-11-14 14:12 | maite | New Issue | |
| 2017-11-14 14:12 | maite | Assigned To | => Retail |
| 2017-11-14 14:12 | maite | OBNetwork customer | => Yes |
| 2017-11-14 14:12 | maite | Support ticket | => 49189 |
| 2017-11-14 14:12 | maite | Resolution time | => 1512428400 |
| 2017-11-14 14:12 | maite | Triggers an Emergency Pack | => No |
| 2017-11-14 14:13 | maite | Relationship added | related to 0037186 |
| 2017-11-15 16:28 | rqueralta | Assigned To | Retail => rqueralta |
| 2017-11-15 16:30 | rqueralta | Status | new => scheduled |
| 2017-12-07 14:24 | hgbot | Checkin | |
| 2017-12-07 14:24 | hgbot | Note Added: 0100940 | |
| 2017-12-07 14:24 | hgbot | Status | scheduled => resolved |
| 2017-12-07 14:24 | hgbot | Resolution | open => fixed |
| 2017-12-07 14:24 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69419e71c5d133a328e13e0452f66e87fa02f512 [^] |
| 2017-12-07 15:54 | marvintm | Review Assigned To | => marvintm |
| 2017-12-07 15:54 | marvintm | Status | resolved => closed |
| 2017-12-07 15:54 | marvintm | Fixed in Version | => RR18Q1 |
| 2018-01-09 15:38 | hgbot | Checkin | |
| 2018-01-09 15:38 | hgbot | Note Added: 0101640 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |