Openbravo Issue Tracking System - Retail Modules
View Issue Details
0037290Retail ModulesWeb POSpublic2017-11-14 14:122018-01-09 15:38
maite 
rqueralta 
urgentmajoralways
closedfixed 
5
 
RR18Q1 
marvintm
No
0037290: "Save" button blocked in Edit Customer window in case custom hook set args.passValidation=false
Save button is not enabled again when a OBPOS_PreCustomerSave hook which leaves "args.passValidation" in FALSE status is executed
1. Log in the terminal
2. Open Developers Tool and register following hook in the console:

OB.UTIL.HookManager.registerHook('OBPOS_PreCustomerSave', function(args, callbacks) {args.passValidation=false; alert("1");OB.UTIL.HookManager.callbackExecutor(args, callbacks);});

3. Click on customer and set Arturo Montoro
4. Click again on Arturo Montoro and run Edit option. Add any change and press SAVE button. Realize that button is not enabled
Solution proposed by the partner:

- Edit sharedcomponents.js file to add following code in:

line 388:
} else {
OB.UTIL.showError(args.error);
+ me.waterfall('onDisableButton', {
+ disabled: false
+ });

line 470
- args.windowComponent.waterfall('onDisableButton', {
+ me.waterfall('onDisableButton', {
No tags attached.
related to defect 0037186 closed ranjith_qualiantech_com "Save" button blocked in Edit Customer window when pressed after leaving mandatory field empty 
Issue History
2017-11-14 14:12maiteNew Issue
2017-11-14 14:12maiteAssigned To => Retail
2017-11-14 14:12maiteResolution time => 1512428400
2017-11-14 14:12maiteTriggers an Emergency Pack => No
2017-11-14 14:13maiteRelationship addedrelated to 0037186
2017-11-15 16:28rqueraltaAssigned ToRetail => rqueralta
2017-11-15 16:30rqueraltaStatusnew => scheduled
2017-12-07 14:24hgbotCheckin
2017-12-07 14:24hgbotNote Added: 0100940
2017-12-07 14:24hgbotStatusscheduled => resolved
2017-12-07 14:24hgbotResolutionopen => fixed
2017-12-07 14:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69419e71c5d133a328e13e0452f66e87fa02f512 [^]
2017-12-07 15:54marvintmReview Assigned To => marvintm
2017-12-07 15:54marvintmStatusresolved => closed
2017-12-07 15:54marvintmFixed in Version => RR18Q1
2018-01-09 15:38hgbotCheckin
2018-01-09 15:38hgbotNote Added: 0101640

Notes
(0100940)
hgbot   
2017-12-07 14:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 69419e71c5d133a328e13e0452f66e87fa02f512
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Wed Nov 15 13:37:39 2017 -0500
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69419e71c5d133a328e13e0452f66e87fa02f512 [^]

Fixed issue 37290: "Save" button blocked in Edit Customer window in case custom
hook set args.passValidation=false

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customers/components/sharedcomponents.js
---
(0101640)
hgbot   
2018-01-09 15:38   
Repository: tools/automation/pi-mobile
Changeset: e491e9740570ec1d38315b815cfbf9fb793dea7e
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Mon Jan 08 11:31:54 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e491e9740570ec1d38315b815cfbf9fb793dea7e [^]

Verifies issue 37290: "Save" button blocked in Edit Customer window
in case custom hook set args.passValidation=false

---
M src-test/org/openbravo/test/mobile/core/utils/AllowedErrorsHelper.java
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/I37290_VerifySaveInEditCustomerWithCustomHook.java
---