Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0037171
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-10-27 07:302017-11-03 08:40
ReporterguillermogilView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityurgentResolutionfixedFixed in VersionRR18Q1
StatusclosedFix in branchFixed in SCM revision4348fba3d257
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0037171: OB.MobileApp.model.get('terminal').currencySymbolAtTheRight is not returning boolean

DescriptionOB.MobileApp.model.get('terminal').currencySymbolAtTheRight is not returning boolean values.
That is generating error while trying to use OB.I18N.formatCurrencyWithSymbol function.
the definition is the following:
Terminal.java:
          + "'"
          + pricesList.getCurrency().isCurrencySymbolAtTheRight()
          + "' as currencySymbolAtTheRight, "
in here it is generating the string.

ob-i18n.js
  OB.I18N.formatCurrencyWithSymbol = function (number, symbol, currencySymbolToTheRight) {
    if (currencySymbolToTheRight) {
      return OB.I18N.formatCurrency(number) + symbol;
    } else {
      return symbol + OB.I18N.formatCurrency(number);
    }
  };
Then values like 'false' are going to the first return
Steps To ReproduceLogin on WebPOS
Open developer tools
Execute the following:
OB.MobileApp.model.get('terminal').currencySymbolAtTheRight

You will see that it returns a 'true' or a 'false'
Proposed SolutionModify Terminal.java to ensure it is a boolean.
See patch attached
TagsNo tags attached.
Attached Filesdiff file icon pricelist.diff [^] (2,950 bytes) 2017-10-27 09:11 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0100205)
hgbot (developer)
2017-11-01 06:32

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4348fba3d2572cbd47bf4276548ef3ebeab60911
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 01 11:01:59 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4348fba3d2572cbd47bf4276548ef3ebeab60911 [^]

Fixed issue 37171 : Terminal property currencySymbolAtRight changed to boolean

---
M src/org/openbravo/retail/posterminal/term/Terminal.java
---

- Issue History
Date Modified Username Field Change
2017-10-27 07:30 guillermogil New Issue
2017-10-27 07:30 guillermogil Assigned To => Retail
2017-10-27 07:30 guillermogil Resolution time => 1510873200
2017-10-27 07:30 guillermogil Triggers an Emergency Pack => No
2017-10-27 07:32 guillermogil Description Updated View Revisions
2017-10-27 07:34 guillermogil Proposed Solution updated
2017-10-27 09:11 marvintm File Added: pricelist.diff
2017-10-27 09:25 guillermogil Proposed Solution updated
2017-10-31 06:13 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2017-10-31 06:14 ranjith_qualiantech_com Status new => scheduled
2017-11-01 06:32 hgbot Checkin
2017-11-01 06:32 hgbot Note Added: 0100205
2017-11-01 06:32 hgbot Status scheduled => resolved
2017-11-01 06:32 hgbot Resolution open => fixed
2017-11-01 06:32 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4348fba3d2572cbd47bf4276548ef3ebeab60911 [^]
2017-11-03 08:40 marvintm Review Assigned To => marvintm
2017-11-03 08:40 marvintm Status resolved => closed
2017-11-03 08:40 marvintm Fixed in Version => RR18Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker