Openbravo Issue Tracking System - Retail Modules
View Issue Details
0037171Retail ModulesWeb POSpublic2017-10-27 07:302017-11-03 08:40
guillermogil 
ranjith_qualiantech_com 
urgentmajoralways
closedfixed 
5
 
RR18Q1 
marvintm
No
0037171: OB.MobileApp.model.get('terminal').currencySymbolAtTheRight is not returning boolean
OB.MobileApp.model.get('terminal').currencySymbolAtTheRight is not returning boolean values.
That is generating error while trying to use OB.I18N.formatCurrencyWithSymbol function.
the definition is the following:
Terminal.java:
          + "'"
          + pricesList.getCurrency().isCurrencySymbolAtTheRight()
          + "' as currencySymbolAtTheRight, "
in here it is generating the string.

ob-i18n.js
  OB.I18N.formatCurrencyWithSymbol = function (number, symbol, currencySymbolToTheRight) {
    if (currencySymbolToTheRight) {
      return OB.I18N.formatCurrency(number) + symbol;
    } else {
      return symbol + OB.I18N.formatCurrency(number);
    }
  };
Then values like 'false' are going to the first return
Login on WebPOS
Open developer tools
Execute the following:
OB.MobileApp.model.get('terminal').currencySymbolAtTheRight

You will see that it returns a 'true' or a 'false'
Modify Terminal.java to ensure it is a boolean.
See patch attached
No tags attached.
diff pricelist.diff (2,950) 2017-10-27 09:11
https://issues.openbravo.com/file_download.php?file_id=11241&type=bug
Issue History
2017-10-27 07:30guillermogilNew Issue
2017-10-27 07:30guillermogilAssigned To => Retail
2017-10-27 07:30guillermogilResolution time => 1510873200
2017-10-27 07:30guillermogilTriggers an Emergency Pack => No
2017-10-27 07:32guillermogilDescription Updatedbug_revision_view_page.php?rev_id=16190#r16190
2017-10-27 07:34guillermogilProposed Solution updated
2017-10-27 09:11marvintmFile Added: pricelist.diff
2017-10-27 09:25guillermogilProposed Solution updated
2017-10-31 06:13ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2017-10-31 06:14ranjith_qualiantech_comStatusnew => scheduled
2017-11-01 06:32hgbotCheckin
2017-11-01 06:32hgbotNote Added: 0100205
2017-11-01 06:32hgbotStatusscheduled => resolved
2017-11-01 06:32hgbotResolutionopen => fixed
2017-11-01 06:32hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4348fba3d2572cbd47bf4276548ef3ebeab60911 [^]
2017-11-03 08:40marvintmReview Assigned To => marvintm
2017-11-03 08:40marvintmStatusresolved => closed
2017-11-03 08:40marvintmFixed in Version => RR18Q1

Notes
(0100205)
hgbot   
2017-11-01 06:32   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4348fba3d2572cbd47bf4276548ef3ebeab60911
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Nov 01 11:01:59 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4348fba3d2572cbd47bf4276548ef3ebeab60911 [^]

Fixed issue 37171 : Terminal property currencySymbolAtRight changed to boolean

---
M src/org/openbravo/retail/posterminal/term/Terminal.java
---