Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036977 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | always | 2017-09-29 14:36 | 2018-01-22 20:57 | |||
| Reporter | jorgewederago | View Status | public | |||||
| Assigned To | rqueralta | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR18Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | ae5f211d6c8f | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | guilleaer | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036977: Under certain circumstances an overpayment is not evaluated properly | |||||||
| Description | If you set a maximum amount for overpayment/max limit change it can be ignored under certain circumstances. | |||||||
| Steps To Reproduce | Backend: *Go to backend > POSTerminal Type window. *Open Credit Card payment method. *Set Overpayment/MaxLimit Change as 100 WebPOS: *Add Avalanche Transceiver *Add credit card payment with 500 as value *Check that an error message appears and Done button is disabled *Remove the payment and add a new one with Credit Card with value 5000 In this case you will be able to close the transaction ignoring the maxLimit Change/Overpayment value. | |||||||
| Proposed Solution | } else if (selectedPayment.paymentMethod.overpaymentLimit < requiredCash) { The line above compares a number against an string, this wont work if the string contains both "," and "." symbols. It might be a good idea to convert requiredCash to a number too. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0099941) hgbot (developer) 2017-10-18 16:24 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ae5f211d6c8fee8aa7d834f5a41ee6be95dfa591 Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu> Date: Tue Oct 17 10:24:07 2017 -0400 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ae5f211d6c8fee8aa7d834f5a41ee6be95dfa591 [^] Fixed issue 36977: Under certain circumstances an overpayment is not evaluated properly --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0099943) hgbot (developer) 2017-10-18 16:46 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: fc635c7445b8e4ac7019de0adef28956b24c088e Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Wed Oct 18 16:32:06 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fc635c7445b8e4ac7019de0adef28956b24c088e [^] Related to issue 36977: Under certain circumstances an overpayment is not evaluated properly Fix also some other problem with overpayment currency formats. --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0100839) hgbot (developer) 2017-11-30 15:25 |
Repository: tools/automation/pi-mobile Changeset: 02af56b93836306c72bb0e2c4b3927aa4e38e5c5 Author: Alejandro <alekosmp86 <at> gmail.com> Date: Wed Nov 29 09:24:59 2017 -0500 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/02af56b93836306c72bb0e2c4b3927aa4e38e5c5 [^] Verifies issue 36977: Under certain circumstances an overpayment is not evaluated properly --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36977_VerifyOverpaymentEvaluation.java --- |
|
(0101866) hgbot (developer) 2018-01-22 20:57 |
Repository: tools/automation/pi-mobile Changeset: c664214945f21c661f65b94594e90bab3573f1cc Author: Alejandro <alekosmp86 <at> gmail.com> Date: Tue Jan 16 08:32:15 2018 -0500 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/c664214945f21c661f65b94594e90bab3573f1cc [^] Test refactor for issue 36977: Changes in database are made in beforeWithReload and afterWithReload classes --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36977_VerifyOverpaymentEvaluation.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-09-29 14:36 | jorgewederago | New Issue | |
| 2017-09-29 14:36 | jorgewederago | Assigned To | => Retail |
| 2017-09-29 14:36 | jorgewederago | Triggers an Emergency Pack | => No |
| 2017-09-29 14:49 | marvintm | Resolution time | => 1508450400 |
| 2017-10-10 15:52 | rqueralta | Assigned To | Retail => rqueralta |
| 2017-10-10 15:53 | rqueralta | Status | new => scheduled |
| 2017-10-18 16:24 | hgbot | Checkin | |
| 2017-10-18 16:24 | hgbot | Note Added: 0099941 | |
| 2017-10-18 16:24 | hgbot | Status | scheduled => resolved |
| 2017-10-18 16:24 | hgbot | Resolution | open => fixed |
| 2017-10-18 16:24 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ae5f211d6c8fee8aa7d834f5a41ee6be95dfa591 [^] |
| 2017-10-18 16:46 | hgbot | Checkin | |
| 2017-10-18 16:46 | hgbot | Note Added: 0099943 | |
| 2017-10-23 15:00 | guilleaer | Review Assigned To | => guilleaer |
| 2017-10-23 15:00 | guilleaer | Status | resolved => closed |
| 2017-10-23 15:00 | guilleaer | Fixed in Version | => RR18Q1 |
| 2017-11-30 15:25 | hgbot | Checkin | |
| 2017-11-30 15:25 | hgbot | Note Added: 0100839 | |
| 2018-01-22 20:57 | hgbot | Checkin | |
| 2018-01-22 20:57 | hgbot | Note Added: 0101866 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |