Openbravo Issue Tracking System - Retail Modules
View Issue Details
0036977Retail ModulesWeb POSpublic2017-09-29 14:362018-01-22 20:57
jorgewederago 
rqueralta 
normalminoralways
closedfixed 
5
 
RR18Q1 
guilleaer
No
0036977: Under certain circumstances an overpayment is not evaluated properly
If you set a maximum amount for overpayment/max limit change it can be ignored under certain circumstances.
Backend:
*Go to backend > POSTerminal Type window.
*Open Credit Card payment method.
*Set Overpayment/MaxLimit Change as 100
WebPOS:
*Add Avalanche Transceiver
*Add credit card payment with 500 as value
*Check that an error message appears and Done button is disabled
*Remove the payment and add a new one with Credit Card with value 5000

In this case you will be able to close the transaction ignoring the maxLimit Change/Overpayment value.
} else if (selectedPayment.paymentMethod.overpaymentLimit < requiredCash) {

The line above compares a number against an string, this wont work if the string contains both "," and "." symbols.

It might be a good idea to convert requiredCash to a number too.
No tags attached.
Issue History
2017-09-29 14:36jorgewederagoNew Issue
2017-09-29 14:36jorgewederagoAssigned To => Retail
2017-09-29 14:36jorgewederagoTriggers an Emergency Pack => No
2017-09-29 14:49marvintmResolution time => 1508450400
2017-10-10 15:52rqueraltaAssigned ToRetail => rqueralta
2017-10-10 15:53rqueraltaStatusnew => scheduled
2017-10-18 16:24hgbotCheckin
2017-10-18 16:24hgbotNote Added: 0099941
2017-10-18 16:24hgbotStatusscheduled => resolved
2017-10-18 16:24hgbotResolutionopen => fixed
2017-10-18 16:24hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ae5f211d6c8fee8aa7d834f5a41ee6be95dfa591 [^]
2017-10-18 16:46hgbotCheckin
2017-10-18 16:46hgbotNote Added: 0099943
2017-10-23 15:00guilleaerReview Assigned To => guilleaer
2017-10-23 15:00guilleaerStatusresolved => closed
2017-10-23 15:00guilleaerFixed in Version => RR18Q1
2017-11-30 15:25hgbotCheckin
2017-11-30 15:25hgbotNote Added: 0100839
2018-01-22 20:57hgbotCheckin
2018-01-22 20:57hgbotNote Added: 0101866

Notes
(0099941)
hgbot   
2017-10-18 16:24   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ae5f211d6c8fee8aa7d834f5a41ee6be95dfa591
Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu>
Date: Tue Oct 17 10:24:07 2017 -0400
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ae5f211d6c8fee8aa7d834f5a41ee6be95dfa591 [^]

Fixed issue 36977: Under certain circumstances an overpayment is not evaluated
properly

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0099943)
hgbot   
2017-10-18 16:46   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fc635c7445b8e4ac7019de0adef28956b24c088e
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Oct 18 16:32:06 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fc635c7445b8e4ac7019de0adef28956b24c088e [^]

Related to issue 36977: Under certain circumstances an overpayment is not evaluated
properly

Fix also some other problem with overpayment currency formats.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0100839)
hgbot   
2017-11-30 15:25   
Repository: tools/automation/pi-mobile
Changeset: 02af56b93836306c72bb0e2c4b3927aa4e38e5c5
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Wed Nov 29 09:24:59 2017 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/02af56b93836306c72bb0e2c4b3927aa4e38e5c5 [^]

Verifies issue 36977: Under certain circumstances an overpayment is not evaluated
properly

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36977_VerifyOverpaymentEvaluation.java
---
(0101866)
hgbot   
2018-01-22 20:57   
Repository: tools/automation/pi-mobile
Changeset: c664214945f21c661f65b94594e90bab3573f1cc
Author: Alejandro <alekosmp86 <at> gmail.com>
Date: Tue Jan 16 08:32:15 2018 -0500
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/c664214945f21c661f65b94594e90bab3573f1cc [^]

Test refactor for issue 36977: Changes in database are made in beforeWithReload
and afterWithReload classes

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36977_VerifyOverpaymentEvaluation.java
---