Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0036959
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2017-09-27 10:252017-10-13 11:47
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in VersionRR18Q1
StatusclosedFix in branchFixed in SCM revisione017003eded3
ProjectionnoneETAnoneTarget VersionRR18Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036959: Handle remove payment cancellation also in pay open tickets (relevant also for external payment providers)

DescriptionThere are differences between the removePayment implementation for the single ticket [1] and pay-open-ticket [2] functionality.

Specifically that the pay-open-ticket implementation misses a cancellationcallback means that in case of external payment provider if the removepayment fails that the user interface remains stuck (see screenshot) and the user can not remove the payment (he/she can do f5 and try removing again then).

[1]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.posterminal-but/file/tip/web/org.openbravo.retail.posterminal/js/model/order.js#l3472 [^]

[2]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.posterminal-but/file/tip/web/org.openbravo.retail.posterminal/js/model/order.js#l5625 [^]
Steps To ReproduceUse external payment provider
Remove payment
Let the external payment provider fail on it
See that X button remains disabled, meaning the turning wheel is shown
Proposed SolutionImplement callback also for cancellation and success
TagsNo tags attached.
Attached Filespng file icon Selection_029.png [^] (36,833 bytes) 2017-09-27 10:25


diff file icon 36959-snap-q2.diff [^] (1,270 bytes) 2017-10-03 09:50 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0099714)
hgbot (developer)
2017-10-03 09:51

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e017003eded39eb603c6ed4a36903ecabdf16280
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Oct 03 09:35:04 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e017003eded39eb603c6ed4a36903ecabdf16280 [^]

Fixes issue 36959: Handle remove payment cancellation also in pay open tickets (relevant also for external payment providers)
Also support cancelation callback in pay open tickets in case of remove payment

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---

- Issue History
Date Modified Username Field Change
2017-09-27 10:25 mtaal New Issue
2017-09-27 10:25 mtaal Assigned To => mtaal
2017-09-27 10:25 mtaal File Added: Selection_029.png
2017-09-27 10:25 mtaal Triggers an Emergency Pack => No
2017-10-03 09:50 mtaal Review Assigned To => migueldejuana
2017-10-03 09:50 mtaal Review Assigned To migueldejuana => marvintm
2017-10-03 09:50 mtaal File Added: 36959-snap-q2.diff
2017-10-03 09:51 hgbot Checkin
2017-10-03 09:51 hgbot Note Added: 0099714
2017-10-03 09:51 hgbot Status new => resolved
2017-10-03 09:51 hgbot Resolution open => fixed
2017-10-03 09:51 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e017003eded39eb603c6ed4a36903ecabdf16280 [^]
2017-10-13 11:47 marvintm Status resolved => closed
2017-10-13 11:47 marvintm Fixed in Version => RR18Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker