Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036959Retail ModulesWeb POSpublic2017-09-27 10:252017-10-13 11:47
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q1Fixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036959: Handle remove payment cancellation also in pay open tickets (relevant also for external payment providers)
DescriptionThere are differences between the removePayment implementation for the single ticket [1] and pay-open-ticket [2] functionality.

Specifically that the pay-open-ticket implementation misses a cancellationcallback means that in case of external payment provider if the removepayment fails that the user interface remains stuck (see screenshot) and the user can not remove the payment (he/she can do f5 and try removing again then).

[1]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.posterminal-but/file/tip/web/org.openbravo.retail.posterminal/js/model/order.js#l3472 [^]

[2]
https://code.openbravo.com/erp/pmods-branches/org.openbravo.retail.posterminal-but/file/tip/web/org.openbravo.retail.posterminal/js/model/order.js#l5625 [^]
Steps To ReproduceUse external payment provider
Remove payment
Let the external payment provider fail on it
See that X button remains disabled, meaning the turning wheel is shown
Proposed SolutionImplement callback also for cancellation and success
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Selection_029.png (36,833) 2017-09-27 10:25
https://issues.openbravo.com/file_download.php?file_id=11107&type=bug
png

diff 36959-snap-q2.diff (1,270) 2017-10-03 09:50
https://issues.openbravo.com/file_download.php?file_id=11132&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-09-27 10:25mtaalNew Issue
2017-09-27 10:25mtaalAssigned To => mtaal
2017-09-27 10:25mtaalFile Added: Selection_029.png
2017-09-27 10:25mtaalOBNetwork customer => No
2017-09-27 10:25mtaalTriggers an Emergency Pack => No
2017-10-03 09:50mtaalReview Assigned To => migueldejuana
2017-10-03 09:50mtaalReview Assigned Tomigueldejuana => marvintm
2017-10-03 09:50mtaalFile Added: 36959-snap-q2.diff
2017-10-03 09:51hgbotCheckin
2017-10-03 09:51hgbotNote Added: 0099714
2017-10-03 09:51hgbotStatusnew => resolved
2017-10-03 09:51hgbotResolutionopen => fixed
2017-10-03 09:51hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e017003eded39eb603c6ed4a36903ecabdf16280 [^]
2017-10-13 11:47marvintmStatusresolved => closed
2017-10-13 11:47marvintmFixed in Version => RR18Q1

Notes
(0099714)
hgbot   
2017-10-03 09:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e017003eded39eb603c6ed4a36903ecabdf16280
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Oct 03 09:35:04 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e017003eded39eb603c6ed4a36903ecabdf16280 [^]

Fixes issue 36959: Handle remove payment cancellation also in pay open tickets (relevant also for external payment providers)
Also support cancelation callback in pay open tickets in case of remove payment

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---