Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2017-09-12 12:562017-10-31 09:19
ReporteregoitzView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR17Q2.4
StatusclosedFix in branchFixed in SCM revision841b5fd9039d
ProjectionnoneETAnoneTarget VersionRR17Q2.4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo

0036941: Unneeded query executed on the orderloader process

DescriptionDuring the orderloader process a query to set one attributeset is executed when there is not stock and the product has an attribute set defined.
It is setting on the new shipment line the same attributesetvalue than in the last one, what has not sense.
Steps To Reproduce-Define a product with an attribute set.
-Create on the terminal a ticket with that prodduct.
-Check that a query on the m_inoutline table is executed.
The query: [^]
Proposed SolutionREview the following code on the orderload process:

[12:48:20] Egoitz: if (!foundStockProposed && orderLine.getProduct().getAttributeSet() != null) {
            // M_GetStock couldn't find any valid stock, and the product has an attribute set. We
            // will
            // attempt to find an old transaction for this product, and get the attribute values
            // from
            // there
            OBCriteria<ShipmentInOutLine> oldLines = OBDal.getInstance().createCriteria(
                .add(Restrictions.eq(ShipmentInOutLine.PROPERTY_PRODUCT, orderLine.getProduct()));
            oldLines.addOrderBy(ShipmentInOutLine.PROPERTY_CREATIONDATE, false);
            List<ShipmentInOutLine> oldLine = oldLines.list();
            if (oldLine.size() > 0) {
              oldAttributeSetValues = oldLine.get(0).getAttributeSetValue();

TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0036840 closedranjith_qualiantech_com Unneeded query executed on the orderloader process 

-  Notes
hgbot (developer)
2017-09-26 08:15

Repository: retail/backports/3.0RR17Q2.4/org.openbravo.retail.posterminal
Changeset: 841b5fd9039d27dc9f9e355380b7fb59fa3af49e
Author: Ranjith S R <ranjith <at>>
Date: Tue Sep 26 11:27:09 2017 +0530
URL: [^]

Fixed issue 36941 : Removed unused logic in OrderLoader

* Following condition is removed, if the stock is not present and product doesn't have attribute set, then attribute set is fetched from last transaction

M src/org/openbravo/retail/posterminal/

- Issue History
Date Modified Username Field Change
2017-09-25 11:33 marvintm Type defect => backport
2017-09-25 11:33 marvintm Target Version => RR17Q2.4
2017-09-26 08:15 hgbot Checkin
2017-09-26 08:15 hgbot Note Added: 0099570
2017-09-26 08:15 hgbot Status scheduled => resolved
2017-09-26 08:15 hgbot Resolution open => fixed
2017-09-26 08:15 hgbot Fixed in SCM revision [^] => [^]
2017-10-31 09:19 marvintm Status resolved => closed
2017-10-31 09:19 marvintm Fixed in Version => RR17Q2.4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker