Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036840
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-09-12 12:562017-09-25 11:33
ReporteregoitzView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR17Q4
StatusclosedFix in branchFixed in SCM revision1aa6dec4e0ad
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036840: Unneeded query executed on the orderloader process

DescriptionDuring the orderloader process a query to set one attributeset is executed when there is not stock and the product has an attribute set defined.
It is setting on the new shipment line the same attributesetvalue than in the last one, what has not sense.
Steps To Reproduce-Define a product with an attribute set.
-Create on the terminal a ticket with that prodduct.
-Check that a query on the m_inoutline table is executed.
The query:

https://docs.google.com/document/d/1pWsaB-yj2pzBWU3v9R0nGYNpv4k1iXZXmCw6qGJ_kh0/edit [^]
Proposed SolutionREview the following code on the orderload process:

[12:48:20] Egoitz: if (!foundStockProposed && orderLine.getProduct().getAttributeSet() != null) {
            // M_GetStock couldn't find any valid stock, and the product has an attribute set. We
            // will
            // attempt to find an old transaction for this product, and get the attribute values
            // from
            // there
            OBCriteria<ShipmentInOutLine> oldLines = OBDal.getInstance().createCriteria(
                ShipmentInOutLine.class);
            oldLines
                .add(Restrictions.eq(ShipmentInOutLine.PROPERTY_PRODUCT, orderLine.getProduct()));
            oldLines.setMaxResults(1);
            oldLines.addOrderBy(ShipmentInOutLine.PROPERTY_CREATIONDATE, false);
            List<ShipmentInOutLine> oldLine = oldLines.list();
            if (oldLine.size() > 0) {
              oldAttributeSetValues = oldLine.get(0).getAttributeSetValue();
            }

          }
TagsPerformance
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0036940RR17Q3.1 closedranjith_qualiantech_com Unneeded query executed on the orderloader process 
depends on backport 0036941RR17Q2.4 closedranjith_qualiantech_com Unneeded query executed on the orderloader process 

-  Notes
(0099170)
hgbot (developer)
2017-09-20 10:37

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1aa6dec4e0ad4c1354194ef1796e5d195017920c
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Wed Sep 20 13:47:55 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1aa6dec4e0ad4c1354194ef1796e5d195017920c [^]

Fixed issue 36840 : Removed unused logic in OrderLoader

* Following condition is removed, if the stock is not present and product doesn't have attribute set, then attribute set is fetched from last transaction

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---

- Issue History
Date Modified Username Field Change
2017-09-12 12:56 egoitz New Issue
2017-09-12 12:56 egoitz Assigned To => Retail
2017-09-12 12:56 egoitz Resolution time => 1505858400
2017-09-12 12:56 egoitz Triggers an Emergency Pack => No
2017-09-19 15:27 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2017-09-19 15:28 ranjith_qualiantech_com Status new => scheduled
2017-09-20 10:37 hgbot Checkin
2017-09-20 10:37 hgbot Note Added: 0099170
2017-09-20 10:37 hgbot Status scheduled => resolved
2017-09-20 10:37 hgbot Resolution open => fixed
2017-09-20 10:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1aa6dec4e0ad4c1354194ef1796e5d195017920c [^]
2017-09-20 10:46 marvintm Review Assigned To => marvintm
2017-09-20 10:46 marvintm Status resolved => closed
2017-09-20 10:46 marvintm Fixed in Version => RR17Q4
2017-09-24 17:20 shuehner Tag Attached: Performance
2017-09-24 17:23 shuehner Issue Monitored: shuehner
2017-09-25 11:33 marvintm Status closed => new
2017-09-25 11:33 marvintm Resolution fixed => open
2017-09-25 11:33 marvintm Fixed in Version RR17Q4 =>
2017-09-25 11:33 marvintm Status new => scheduled
2017-09-25 11:33 marvintm Status scheduled => resolved
2017-09-25 11:33 marvintm Fixed in Version => RR17Q4
2017-09-25 11:33 marvintm Resolution open => fixed
2017-09-25 11:33 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker