Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0036906 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | have not tried | 2017-09-20 17:49 | 2017-10-26 13:02 | |||
| Reporter | adrianromero | View Status | public | |||||
| Assigned To | guilleaer | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | RR18Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | afe00a02a28c | ||||
| Projection | none | ETA | none | Target Version | RR18Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0036906: [SCO][Contribution] Approval dialog content is created every time the dialog is displayed but never destroyed | |||||||
| Description | When displaying the approval dialog the body is created as a new enyo component every time. This means a memory leak of all previous approval bodies attached to the DOM but hidden. This is also problematic not only for the memory leak but also in tests because the testIDs of all enyo compoments in the approval body change every time the approval dialog is displayed making it impossible to make a single test with more than one approval without doing awful things like reloading the page. | |||||||
| Steps To Reproduce | * Configure the approval to delete the receipt * Login in Web POS and force to display the approval dialog several times * Open the Chrome developer tools * Execute in the console TestRegistry.appendIdTestToDOM() * go to the DOM and search for confirmationContainer_approval * Observe that as son of the confirmation container dialog "confirmationContainer" there are serveral sons only one displayed an the rest hidden forever. | |||||||
| Proposed Solution | See the attached patches Take into account that the attached patch in mobile.core, modify the testIDs of approval compoments. There is attached also the pi-mobile patch that fixes these approval IDs | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  32906-mobilecore.export [^] (1,228 bytes) 2017-09-20 18:00 36906-pimobile.export [^] (1,297 bytes) 2017-09-20 18:01 36906-pimobile-2.export [^] (1,117 bytes) 2017-10-03 18:11 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0099765) hgbot (developer) 2017-10-04 16:30 |
Repository: tools/automation/pi-mobile Changeset: a9e6b8af6d7857bb7ad28d414b5663eea5d27da8 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Tue Oct 03 20:59:58 2017 +0200 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a9e6b8af6d7857bb7ad28d414b5663eea5d27da8 [^] related to issue 36906: Use new approval name --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java --- |
|
(0099767) hgbot (developer) 2017-10-04 16:30 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: afe00a02a28cc51004ab36aca0ee8e4f5e88c207 Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Tue Oct 03 20:58:59 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/afe00a02a28cc51004ab36aca0ee8e4f5e88c207 [^] Fixed issue 36906: Give name to approval component. It allows to use it from pi-mobile --- M web/org.openbravo.mobile.core/source/component/obpos-approval.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2017-09-20 17:49 | adrianromero | New Issue | |
| 2017-09-20 17:49 | adrianromero | Assigned To | => Retail |
| 2017-09-20 17:49 | adrianromero | Triggers an Emergency Pack | => No |
| 2017-09-20 18:00 | adrianromero | File Added: 32906-mobilecore.export | |
| 2017-09-20 18:01 | adrianromero | File Added: 36906-pimobile.export | |
| 2017-09-20 18:14 | guilleaer | Summary | Approval dialog content is created every time the dialog is displayed but never destroyed => [SCO][18Q1] Approval dialog content is created every time the dialog is displayed but never destroyed |
| 2017-09-20 18:14 | guilleaer | Proposed Solution updated | |
| 2017-09-21 08:46 | guilleaer | Target Version | => RR18Q1 |
| 2017-09-21 08:46 | guilleaer | Summary | [SCO][18Q1] Approval dialog content is created every time the dialog is displayed but never destroyed => [SCO][Contribution] Approval dialog content is created every time the dialog is displayed but never destroyed |
| 2017-10-03 18:11 | adrianromero | File Added: 36906-pimobile-2.export | |
| 2017-10-04 16:30 | hgbot | Checkin | |
| 2017-10-04 16:30 | hgbot | Note Added: 0099765 | |
| 2017-10-04 16:30 | hgbot | Checkin | |
| 2017-10-04 16:30 | hgbot | Note Added: 0099767 | |
| 2017-10-04 16:30 | hgbot | Status | new => resolved |
| 2017-10-04 16:30 | hgbot | Resolution | open => fixed |
| 2017-10-04 16:30 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/afe00a02a28cc51004ab36aca0ee8e4f5e88c207 [^] |
| 2017-10-05 16:44 | marvintm | Assigned To | Retail => guilleaer |
| 2017-10-17 16:22 | guilleaer | Review Assigned To | => marvintm |
| 2017-10-26 13:02 | marvintm | Status | resolved => closed |
| 2017-10-26 13:02 | marvintm | Fixed in Version | => RR18Q1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |