Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036906Retail ModulesWeb POSpublic2017-09-20 17:492017-10-26 13:02
Reporteradrianromero 
Assigned Toguilleaer 
PriorityurgentSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q1Fixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036906: [SCO][Contribution] Approval dialog content is created every time the dialog is displayed but never destroyed
DescriptionWhen displaying the approval dialog the body is created as a new enyo component every time. This means a memory leak of all previous approval bodies attached to the DOM but hidden.

This is also problematic not only for the memory leak but also in tests because the testIDs of all enyo compoments in the approval body change every time the approval dialog is displayed making it impossible to make a single test with more than one approval without doing awful things like reloading the page.
Steps To Reproduce* Configure the approval to delete the receipt
* Login in Web POS and force to display the approval dialog several times
* Open the Chrome developer tools
* Execute in the console TestRegistry.appendIdTestToDOM()
* go to the DOM and search for confirmationContainer_approval
* Observe that as son of the confirmation container dialog "confirmationContainer" there are serveral sons only one displayed an the rest hidden forever.
Proposed SolutionSee the attached patches

Take into account that the attached patch in mobile.core, modify the testIDs of approval compoments. There is attached also the pi-mobile patch that fixes these approval IDs

Additional Information
TagsNo tags attached.
Relationships
Attached Files? 32906-mobilecore.export (1,228) 2017-09-20 18:00
https://issues.openbravo.com/file_download.php?file_id=11083&type=bug
? 36906-pimobile.export (1,297) 2017-09-20 18:01
https://issues.openbravo.com/file_download.php?file_id=11084&type=bug
? 36906-pimobile-2.export (1,117) 2017-10-03 18:11
https://issues.openbravo.com/file_download.php?file_id=11136&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-09-20 17:49adrianromeroNew Issue
2017-09-20 17:49adrianromeroAssigned To => Retail
2017-09-20 17:49adrianromeroOBNetwork customer => No
2017-09-20 17:49adrianromeroTriggers an Emergency Pack => No
2017-09-20 18:00adrianromeroFile Added: 32906-mobilecore.export
2017-09-20 18:01adrianromeroFile Added: 36906-pimobile.export
2017-09-20 18:14guilleaerSummaryApproval dialog content is created every time the dialog is displayed but never destroyed => [SCO][18Q1] Approval dialog content is created every time the dialog is displayed but never destroyed
2017-09-20 18:14guilleaerProposed Solution updated
2017-09-21 08:46guilleaerTarget Version => RR18Q1
2017-09-21 08:46guilleaerSummary[SCO][18Q1] Approval dialog content is created every time the dialog is displayed but never destroyed => [SCO][Contribution] Approval dialog content is created every time the dialog is displayed but never destroyed
2017-10-03 18:11adrianromeroFile Added: 36906-pimobile-2.export
2017-10-04 16:30hgbotCheckin
2017-10-04 16:30hgbotNote Added: 0099765
2017-10-04 16:30hgbotCheckin
2017-10-04 16:30hgbotNote Added: 0099767
2017-10-04 16:30hgbotStatusnew => resolved
2017-10-04 16:30hgbotResolutionopen => fixed
2017-10-04 16:30hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/afe00a02a28cc51004ab36aca0ee8e4f5e88c207 [^]
2017-10-05 16:44marvintmAssigned ToRetail => guilleaer
2017-10-17 16:22guilleaerReview Assigned To => marvintm
2017-10-26 13:02marvintmStatusresolved => closed
2017-10-26 13:02marvintmFixed in Version => RR18Q1

Notes
(0099765)
hgbot   
2017-10-04 16:30   
Repository: tools/automation/pi-mobile
Changeset: a9e6b8af6d7857bb7ad28d414b5663eea5d27da8
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Oct 03 20:59:58 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a9e6b8af6d7857bb7ad28d414b5663eea5d27da8 [^]

related to issue 36906: Use new approval name

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/TestIdPack.java
---
(0099767)
hgbot   
2017-10-04 16:30   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: afe00a02a28cc51004ab36aca0ee8e4f5e88c207
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Oct 03 20:58:59 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/afe00a02a28cc51004ab36aca0ee8e4f5e88c207 [^]

Fixed issue 36906: Give name to approval component. It allows to use it from pi-mobile

---
M web/org.openbravo.mobile.core/source/component/obpos-approval.js
---