Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0036895
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POStrivialalways2017-09-19 17:022017-10-26 13:37
ReporterguilleaerView Statuspublic 
Assigned Toguilleaer 
PrioritynormalResolutionfixedFixed in VersionRR18Q1
StatusclosedFix in branchFixed in SCM revision9f6df6e56714
ProjectionnoneETAnoneTarget VersionRR18Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036895: [SCO][Contribution] Code executed to close an order is dispersed and linked to UI components. It is not reusable

DescriptionCurrently, when an order is closed in webPOS two main events are executed:
1st: event: payment done
2nd: event: Payment accepted
3th: function: Prepare to send
4th: event: closed

The main problem here is that.
1. Code who manages these events is mixing business logic and UI(show loading, show errors etc)
2. To reuse that code we will need to launch an event which is something dangerous
Steps To ReproduceN/A
Proposed SolutionWe need to have an API where business code is executed from the different UIs that wants to use that code.
Every UI will implement the UI behaivor individually
TagsNo tags attached.
Attached Filesdiff file icon 36895.diff [^] (25,121 bytes) 2017-09-19 17:11 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0099745)
hgbot (developer)
2017-10-03 21:13

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9f6df6e567148ac0e608b50c7812132d10ff8f0e
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Oct 03 09:11:50 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9f6df6e567148ac0e608b50c7812132d10ff8f0e [^]

Fixed issue 36895: Code executed when an order is closed is now reusable

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
A web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
---
(0099808)
hgbot (developer)
2017-10-06 14:55

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2226479a394527112d04f71eb8850854de845ad6
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Oct 06 18:09:56 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2226479a394527112d04f71eb8850854de845ad6 [^]

Related to issue 36895 : Enable Layaway button when the payment process is cancelled

* If PostPaymentHook is cancelled, then receipt process should be stopped

---
M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
---

- Issue History
Date Modified Username Field Change
2017-09-19 17:02 guilleaer New Issue
2017-09-19 17:02 guilleaer Assigned To => guilleaer
2017-09-19 17:02 guilleaer Triggers an Emergency Pack => No
2017-09-19 17:11 guilleaer File Added: 36895.diff
2017-09-21 08:45 guilleaer Target Version => RR18Q1
2017-09-21 08:45 guilleaer Summary [SCO][Contribution][18Q1] Code executed to close an order is dispersed and linked to UI components. It is not reusable => [SCO][Contribution] Code executed to close an order is dispersed and linked to UI components. It is not reusable
2017-10-03 21:13 hgbot Checkin
2017-10-03 21:13 hgbot Note Added: 0099745
2017-10-03 21:13 hgbot Status new => resolved
2017-10-03 21:13 hgbot Resolution open => fixed
2017-10-03 21:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9f6df6e567148ac0e608b50c7812132d10ff8f0e [^]
2017-10-06 14:55 hgbot Checkin
2017-10-06 14:55 hgbot Note Added: 0099808
2017-10-17 16:28 guilleaer Review Assigned To => marvintm
2017-10-26 13:37 marvintm Status resolved => closed
2017-10-26 13:37 marvintm Fixed in Version => RR18Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker