Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036895Retail ModulesWeb POSpublic2017-09-19 17:022017-10-26 13:37
Reporterguilleaer 
Assigned Toguilleaer 
PrioritynormalSeveritytrivialReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR18Q1Fixed in VersionRR18Q1 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036895: [SCO][Contribution] Code executed to close an order is dispersed and linked to UI components. It is not reusable
DescriptionCurrently, when an order is closed in webPOS two main events are executed:
1st: event: payment done
2nd: event: Payment accepted
3th: function: Prepare to send
4th: event: closed

The main problem here is that.
1. Code who manages these events is mixing business logic and UI(show loading, show errors etc)
2. To reuse that code we will need to launch an event which is something dangerous
Steps To ReproduceN/A
Proposed SolutionWe need to have an API where business code is executed from the different UIs that wants to use that code.
Every UI will implement the UI behaivor individually
Additional Information
TagsNo tags attached.
Relationships
Attached Filesdiff 36895.diff (25,121) 2017-09-19 17:11
https://issues.openbravo.com/file_download.php?file_id=11075&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-09-19 17:02guilleaerNew Issue
2017-09-19 17:02guilleaerAssigned To => guilleaer
2017-09-19 17:02guilleaerTriggers an Emergency Pack => No
2017-09-19 17:11guilleaerFile Added: 36895.diff
2017-09-21 08:45guilleaerTarget Version => RR18Q1
2017-09-21 08:45guilleaerSummary[SCO][Contribution][18Q1] Code executed to close an order is dispersed and linked to UI components. It is not reusable => [SCO][Contribution] Code executed to close an order is dispersed and linked to UI components. It is not reusable
2017-10-03 21:13hgbotCheckin
2017-10-03 21:13hgbotNote Added: 0099745
2017-10-03 21:13hgbotStatusnew => resolved
2017-10-03 21:13hgbotResolutionopen => fixed
2017-10-03 21:13hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9f6df6e567148ac0e608b50c7812132d10ff8f0e [^]
2017-10-06 14:55hgbotCheckin
2017-10-06 14:55hgbotNote Added: 0099808
2017-10-17 16:28guilleaerReview Assigned To => marvintm
2017-10-26 13:37marvintmStatusresolved => closed
2017-10-26 13:37marvintmFixed in Version => RR18Q1

Notes
(0099745)
hgbot   
2017-10-03 21:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9f6df6e567148ac0e608b50c7812132d10ff8f0e
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Oct 03 09:11:50 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9f6df6e567148ac0e608b50c7812132d10ff8f0e [^]

Fixed issue 36895: Code executed when an order is closed is now reusable

---
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
A web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
---
(0099808)
hgbot   
2017-10-06 14:55   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2226479a394527112d04f71eb8850854de845ad6
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Oct 06 18:09:56 2017 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2226479a394527112d04f71eb8850854de845ad6 [^]

Related to issue 36895 : Enable Layaway button when the payment process is cancelled

* If PostPaymentHook is cancelled, then receipt process should be stopped

---
M web/org.openbravo.retail.posterminal/js/utils/ticketCloseUtils.js
---