Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0036850
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-09-13 19:432017-09-14 10:36
ReportermarvintmView Statuspublic 
Assigned ToRetail 
PriorityurgentResolutionfixedFixed in VersionRR17Q4
StatusclosedFix in branchFixed in SCM revisionc4e5ea1ec8ec
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036850: It's possible to log in a POS which contains errors in a cashup in synchronized mode

DescriptionIt's currently possible to log in a terminal which contains errors from a previous cashup, if Synchronize mode is enabled.

This is wrong, because it will immediately cause further data corruption in the cashup data, as the Synchronized Mode requires the cashup data to be continuously consistent in the backend to work correctly.
Steps To Reproduce- Enable synchronize mode.
- Login and execute a cashup in the Web POS, forcing an error (for example adding an exception in the CashCloseProcessor class).
- Logout. Login again, and verify that you can complete the login without problems. After that, creating any orders will cause new cashups to be generated everytime, due to the Synchronized Mode forcing a reload of the last cashup, and failing to achieve it.

Proposed SolutionLogin should be disallowed if synchronized mode is enabled, and there are cashup errors pending to be processed for this terminal.
TagsNo tags attached.
Attached Filespatch file icon issue36850.patch [^] (9,349 bytes) 2017-09-13 19:49 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0099021)
hgbot (developer)
2017-09-14 08:52

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c4e5ea1ec8ec0d2ff0c097b0fe471f191421ef20
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Sep 13 19:44:47 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c4e5ea1ec8ec0d2ff0c097b0fe471f191421ef20 [^]

Fixed issue 36850. Login will be disallowed if synchronized mode is enabled, and there are cashup errors pending to be saved correctly in this terminal.
Moved some utility functions useful to validate this check to POSUtils class, and called them from there.

---
M src/org/openbravo/retail/posterminal/InitialValidations.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/UpdateCashup.java
M src/org/openbravo/retail/posterminal/master/Cashup.java
---
(0099029)
migueldejuana (developer)
2017-09-14 10:36

Tested and reviewed

- Issue History
Date Modified Username Field Change
2017-09-13 19:43 marvintm New Issue
2017-09-13 19:43 marvintm Assigned To => Retail
2017-09-13 19:43 marvintm Triggers an Emergency Pack => No
2017-09-13 19:49 marvintm File Added: issue36850.patch
2017-09-13 19:52 marvintm Proposed Solution updated
2017-09-13 19:52 marvintm Resolution time => 1506636000
2017-09-14 08:52 hgbot Checkin
2017-09-14 08:52 hgbot Note Added: 0099021
2017-09-14 08:52 hgbot Status new => resolved
2017-09-14 08:52 hgbot Resolution open => fixed
2017-09-14 08:52 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c4e5ea1ec8ec0d2ff0c097b0fe471f191421ef20 [^]
2017-09-14 10:36 migueldejuana Review Assigned To => migueldejuana
2017-09-14 10:36 migueldejuana Note Added: 0099029
2017-09-14 10:36 migueldejuana Status resolved => closed
2017-09-14 10:36 migueldejuana Fixed in Version => RR17Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker