Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0036850Retail ModulesWeb POSpublic2017-09-13 19:432017-09-14 10:36
Reportermarvintm 
Assigned ToRetail 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR17Q4 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0036850: It's possible to log in a POS which contains errors in a cashup in synchronized mode
DescriptionIt's currently possible to log in a terminal which contains errors from a previous cashup, if Synchronize mode is enabled.

This is wrong, because it will immediately cause further data corruption in the cashup data, as the Synchronized Mode requires the cashup data to be continuously consistent in the backend to work correctly.
Steps To Reproduce- Enable synchronize mode.
- Login and execute a cashup in the Web POS, forcing an error (for example adding an exception in the CashCloseProcessor class).
- Logout. Login again, and verify that you can complete the login without problems. After that, creating any orders will cause new cashups to be generated everytime, due to the Synchronized Mode forcing a reload of the last cashup, and failing to achieve it.

Proposed SolutionLogin should be disallowed if synchronized mode is enabled, and there are cashup errors pending to be processed for this terminal.
Additional Information
TagsNo tags attached.
Relationships
Attached Filespatch issue36850.patch (9,349) 2017-09-13 19:49
https://issues.openbravo.com/file_download.php?file_id=11059&type=bug
Issue History
Date ModifiedUsernameFieldChange
2017-09-13 19:43marvintmNew Issue
2017-09-13 19:43marvintmAssigned To => Retail
2017-09-13 19:43marvintmOBNetwork customer => No
2017-09-13 19:43marvintmTriggers an Emergency Pack => No
2017-09-13 19:49marvintmFile Added: issue36850.patch
2017-09-13 19:52marvintmProposed Solution updated
2017-09-13 19:52marvintmOBNetwork customerNo => Yes
2017-09-13 19:52marvintmResolution time => 1506636000
2017-09-14 08:52hgbotCheckin
2017-09-14 08:52hgbotNote Added: 0099021
2017-09-14 08:52hgbotStatusnew => resolved
2017-09-14 08:52hgbotResolutionopen => fixed
2017-09-14 08:52hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c4e5ea1ec8ec0d2ff0c097b0fe471f191421ef20 [^]
2017-09-14 10:36migueldejuanaReview Assigned To => migueldejuana
2017-09-14 10:36migueldejuanaNote Added: 0099029
2017-09-14 10:36migueldejuanaStatusresolved => closed
2017-09-14 10:36migueldejuanaFixed in Version => RR17Q4

Notes
(0099021)
hgbot   
2017-09-14 08:52   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: c4e5ea1ec8ec0d2ff0c097b0fe471f191421ef20
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Wed Sep 13 19:44:47 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/c4e5ea1ec8ec0d2ff0c097b0fe471f191421ef20 [^]

Fixed issue 36850. Login will be disallowed if synchronized mode is enabled, and there are cashup errors pending to be saved correctly in this terminal.
Moved some utility functions useful to validate this check to POSUtils class, and called them from there.

---
M src/org/openbravo/retail/posterminal/InitialValidations.java
M src/org/openbravo/retail/posterminal/POSUtils.java
M src/org/openbravo/retail/posterminal/UpdateCashup.java
M src/org/openbravo/retail/posterminal/master/Cashup.java
---
(0099029)
migueldejuana   
2017-09-14 10:36   
Tested and reviewed