Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036701
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2017-08-23 10:222017-09-15 11:56
ReporterjonibcView Statuspublic 
Assigned Tojorge-garcia 
PriorityhighResolutionfixedFixed in VersionRR17Q4
StatusclosedFix in branchFixed in SCM revisione3d4f2d75c34
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0036701: [SERQA 3212] EnableButtonsCallback is not done in cancellation of BeforeCustomerAddrSave hook

DescriptionIf cancellation argument is true, enableButtonsCallback is not done.

The buttons get blocked and it is not possible to save any new address until a refresh is done.
Steps To ReproduceImplement a hook where we always set args.cancellation = true.

Check that buttons for addresses are blocked until a refresh is done.
Proposed SolutionDo call to enableButtonsCallback before return true in cancellation of BeforeCustomerAddrSave hook. Check the following extract of code.

                OB.UTIL.HookManager.executeHooks('OBPOS_BeforeCustomerAddrSave', {
                    customerAddr: this.model.get('customerAddr'),
                    isNew: true,
                    windowComponent: me
                }, function(args) {
                    if (args && args.cancellation && args.cancellation === true) {
                        // Add enableButtonsCallback
                        enableButtonsCallback();
                        return true;
                    }
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0035981pi closedjorge-garcia [SERQA 2847] Buttons for customer and locations are not blocked in synchronized mode. 

-  Notes
(0098951)
hgbot (developer)
2017-09-11 17:07

 Repository: tools/automation/pi-mobile
Changeset: ed53fed0527ecc97309f0d5e45a0a1ed91e48ce1
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Sep 11 11:59:41 2017 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ed53fed0527ecc97309f0d5e45a0a1ed91e48ce1 [^]

Verifies issue 36701: [SERQA 3212] EnableButtonsCallback is not done in
cancellation of BeforeCustomerAddrSave hook

Added test I36701_EnableButtonsInCancellationHook.

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/customercreation/I36701_EnableButtonsInCancellationHook.java
---
(0098952)
hgbot (developer)
2017-09-11 17:08

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e3d4f2d75c3455e767f3471ee4937896ebd04ad9
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Sep 11 11:19:58 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e3d4f2d75c3455e767f3471ee4937896ebd04ad9 [^]

Fixed issue 36701: [SERQA 3212] EnableButtonsCallback is not done in
cancellation of BeforeCustomerAddrSave hook

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/subwindows/customeraddress/components/sharedcomponents.js
---

- Issue History
Date Modified Username Field Change
2017-08-23 10:22 jonibc New Issue
2017-08-23 10:22 jonibc Assigned To => Retail
2017-08-23 10:22 jonibc OBNetwork customer => Yes
2017-08-23 10:22 jonibc Resolution time => 1504562400
2017-08-23 10:22 jonibc Triggers an Emergency Pack => No
2017-08-23 10:23 jonibc Summary [SERQA 3212] EnableButtonsCallback is not done in cancellation => [SERQA 3212] EnableButtonsCallback is not done in cancellation of BeforeCustomerAddrSave hook
2017-08-23 10:35 jonibc Relationship added related to 0035981
2017-08-23 23:32 rqueralta Assigned To Retail => rqueralta
2017-08-23 23:32 rqueralta Status new => scheduled
2017-08-29 09:58 jonibc Issue Monitored: jonibc
2017-09-11 11:17 jorge-garcia Assigned To rqueralta => jorge-garcia
2017-09-11 17:07 hgbot Checkin
2017-09-11 17:07 hgbot Note Added: 0098951
2017-09-11 17:08 hgbot Checkin
2017-09-11 17:08 hgbot Note Added: 0098952
2017-09-11 17:08 hgbot Status scheduled => resolved
2017-09-11 17:08 hgbot Resolution open => fixed
2017-09-11 17:08 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e3d4f2d75c3455e767f3471ee4937896ebd04ad9 [^]
2017-09-15 11:56 marvintm Review Assigned To => marvintm
2017-09-15 11:56 marvintm Status resolved => closed
2017-09-15 11:56 marvintm Fixed in Version => RR17Q4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker